Hello,
On Wed, Jul 12, 2017 at 03:31:02PM +0200, Arnd Bergmann wrote:
> > We also have about a bazillion
> >
> > warning: ‘*’ in boolean context, suggest ‘&&’ instead
> >
> > warnings in drivers/ata/libata-core.c, all due to a single macro that
> > uses a pattern that gcc-7.1.1 doesn't like.
ontext, suggest
> '&&' instead [-Wint-in-bool-context]
>
> This slightly rearranges the macro to simplify the code and avoid
> the warning at the same time.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
If the whole series will be routed together,
Acked-by: Tejun He
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun Heo <t...@kernel.org>
Mauro, can you please pick this one up? It prolly should be tagged
for -stable too.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-media&quo
ed.
>
> The unused label err_unreg has also been dropped.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun Heo <t...@kernel.org>
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the bo
On Sat, Jul 16, 2016 at 02:43:20PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "_irq_audio_queues" runs the audio upstream handler.
> It has a single work item(>_audio_work_entry) and hence doesn't
> require ordering. Also, it is not being used on a memory reclaim path.
> Hence, the
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun Heo <t...@kernel.org>
This needs to be marked for stable.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.ke
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
xplicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy
target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in pvr2_hdw_destroy to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhak
gt;
> Work item has been flushed in s5p_mfc_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun Heo <t...@kernel.org>
Thanks.
--
tejun
--
To unsubscribe from this
gt;
> Work item has been flushed in s5p_mfc_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun Heo <t...@kernel.org>
Thanks.
--
tejun
--
To unsubscribe from this
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
hus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in hdpvr_device_release() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Ac
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been sync cancelled in tc358743_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy
he
> increase of local concurrency shouldn't make any difference.
>
> Work item has been flushed in sd_stop0() to ensure that there are no
> pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com>
Acked-by: Tejun H
On Sat, Jul 02, 2016 at 04:19:28PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "work_thread" is involved in updating parameters for
> transfers. It has a single work item(>work) and hence
> doesn't require ordering. Also, it is not being used on a memory
> reclaim path. Hence, the
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been sync cancelled in adv76xx_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy
ecified and thus the
> increase of local concurrency shouldn't make any difference.
>
> Work item has been sync cancelled in adv7842_remove() to ensure
> that there are no pending tasks while disconnecting the driver.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriy
Ramamurthy arun.ramamur...@broadcom.com
Need your ACK for this patch.
For ATA part,
Acked-by: Tejun Heo t...@kernel.org
Thanks.
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hello, Shuah.
On Mon, May 05, 2014 at 01:16:46PM -0600, Shuah Khan wrote:
You are right that there is a need for an owner field to indicate who
has the token. Since the path is very long, I didn't want to use just
the mutex and keep it tied up for long periods of time. That is the
reason why
protected by trylock? What's the
reasonsing behind that? What would you need trylock there? Okay,
strick everything I wrote above.
Nacked-by: Tejun Heo t...@kernel.org
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock().
spin_lock_irqsave(dev-devres_lock, flags);
if (tkn_ptr-status ==
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 02:01:32PM -0600, Shuah Khan wrote:
Operating on the lock should be atomic, which is what devres_update()
is doing. It can be simplified as follows by holding devres_lock
in devm_token_lock
is devres_update() even necessary? You can just embed lock in the
data part and operate on it, no?
This is among the most poorly written code that I've seen in a long
time. I don't know whether the token thing is the right appraoch or
not but just purely on code quality,
Nacked-by: Tejun Heo t
direct write accesses to using the correct API.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
Acked-by: Tejun Heo t...@kernel.org
The patch is pretty widely spread. I don't mind how it gets routed
but what's the plan?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line
On Fri, Sep 20, 2013 at 07:16:52AM -0500, Tejun Heo wrote:
On Fri, Sep 20, 2013 at 12:11:38AM +0100, Russell King wrote:
The correct way for a driver to specify the coherent DMA mask is
not to directly access the field in the struct device, but to use
dma_set_coherent_mask(). Only arch
Hey,
On Fri, Sep 20, 2013 at 03:00:18PM +0100, Russell King - ARM Linux wrote:
Another would be if subsystem maintainers are happy that I carry them,
I can add the acks, and then later on towards the end of the cycle,
provide a branch subsystem maintainers could pull.
Or... if you can think
fabio.este...@freescale.com
Acked-by: Tejun Heo t...@kernel.org
Thanks!
--
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
:
drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work' is
deprecated (declared at include/linux/workqueue.h:437)
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Acked-by: Tejun Heo t...@kernel.org
Thanks!
--
tejun
--
To unsubscribe from this list: send the line
On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote:
This patch set fixes a reproducible crash I'm seeing on a 3.4.10
kernel. flush_kthread_worker (which is different from
flush_kthread_work) is initializing a kthread_work and a completion on
the stack, then queuing it and calling
Hello,
On Sun, Jul 22, 2012 at 04:46:54PM -0400, Andy Walls wrote:
Hmmm, I didn't know about the constraint about 'known to be alive' in
the other email I just sent.
That might make calling flush_kthread_work() hard for a user to use, if
the user lets the work get freed by another thread
Hello,
On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote:
+/* insert @work before @pos in @worker */
Hi Tejun,
Would a comment that the caller should be holding worker-lock be useful
here? Anyway, comment or not:
Acked-by: Andy Walls aw...@md.metrocast.net
Will add
Hello,
On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote:
+ worker-current_work = work;
spin_unlock_irq(worker-lock);
if (work) {
__set_current_state(TASK_RUNNING);
work-func(work);
If the call to 'work-func(work);' frees the memory
From 9a2e03d8ed518a61154f18d83d6466628e519f94 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Thu, 19 Jul 2012 13:52:53 -0700
Make the following two non-functional changes.
* Separate out insert_kthread_work() from queue_kthread_work().
* Relocate struct kthread_flush_work
Hello,
kthread_worker was introduced together with concurrency managed
workqueue to serve workqueue users which need a special dedicated
worker - e.g. RT scheduling. This is minimal queue / flush / flush
all iterface on top of kthread and each provided interface matches the
workqueue counterpart
From c9bba34243a86fb3ac82d1bdd0ce4bf796b79559 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Thu, 19 Jul 2012 13:52:53 -0700
Make the following two non-functional changes.
* Separate out insert_kthread_work() from queue_kthread_work().
* Relocate struct kthread_flush_work
From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Thu, 19 Jul 2012 13:52:53 -0700
kthread_worker provides minimalistic workqueue-like interface for
users which need a dedicated worker thread (e.g. for realtime
priority). It has basic
flush_scheduled_work() is deprecated and scheduled to be removed.
technisat-usb2 already sync-cancels the only work item it uses and
there's no reason for it to call flush_scheduled_work(). Don't use
it.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc
() sync flush all three work items before
returning.
Signed-off-by: Tejun Heo t...@kernel.org
Reported-by: Andy Walls awa...@md.metrocast.net
Reviewed-by: Andy Walls awa...@md.metrocast.net
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/video
wl1273_device-work is unused. Remove it along with the spurious
flush_scheduled_work() call in wl1273_fm_module_exit().
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Matti Aaltonen matti.j.aalto...@nokia.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/radio/radio-wl1273.c
Hello,
On Mon, Jan 03, 2011 at 07:54:56PM -0500, Andy Walls wrote:
2. To prevent work items being handled by keventd/n from being delayed
too long, as the deferred work in question can involve a bit of sleeping
due to contention, the workload of the CX23418's MPEG encoding engine,
and the
On 07/05/2010 07:11 PM, Andy Walls wrote:
Assuming the new kthread_worker implementation is OK, this change for
ivtv looks good.
Reviewed-by: Andy Walls awa...@md.metrocast.net
Acked-by: Andy Walls awa...@md.metrocast.net
May I route this patch through wq branch? As it's not clear how this
Upcoming workqueue updates will no longer guarantee fixed workqueue to
worker kthread association, so giving RT priority to the irq worker
won't work. Use kthread_worker which guarantees specific kthread
association instead. This also makes setting the priority cleaner.
Signed-off-by: Tejun Heo
Hello, Linus.
11/18/2009 12:05 AM, Linus Torvalds wrote:
Do you think that usage is wide-spread? Implementing strict ordering
shouldn't be too difficult but I can't help but feeling that such
assumption is abuse of implementation detail.
I think it would be good if it were more than an
Hello,
11/17/2009 09:05 PM, Andy Walls wrote:
Implementing strict ordering
shouldn't be too difficult but I can't help but feeling that such
assumption is abuse of implementation detail.
Hmmm, does not the queue in workqueue mean FIFO?
I don't think it necessarily means strict execution
Hello,
11/17/2009 09:47 AM, Andy Walls wrote:
An important property of the single threaded workqueue, upon which the
cx18 driver relies, is that work objects will be processed strictly in
the order in which they were queued. The cx18 driver has a pool of
work orders and multiple active work
48 matches
Mail list logo
