Re: [PATCH 00/14] staging: media: tegra-vdea: Add Tegra124 support

On Mon, Sep 03, 2018 at 02:18:15PM +0200, Hans Verkuil wrote: > Hi Thierry, Dmitry, > > Dmitry found some issues, so I'll wait for a v2. > > Anyway, this driver is in staging with this TODO: > > - Implement V4L2 API once it gains support for stateless decoders. > > I just wanted to mention

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote: > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > > From: Thierry Reding > > > > The BSEV clock has a separate gate bit and can not be assumed to be > > always enabled. Add explicit

[PATCH 14/14] ARM: tegra: Enable SMMU for VDE on Tegra124

From: Thierry Reding The video decode engine can use the SMMU to use buffers that are not physically contiguous in memory. This allows better memory usage for video decoding, since fragmentation may cause contiguous allocations to fail. Signed-off-by: Thierry Reding --- arch/arm/boot/dts

[PATCH 12/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra20

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra20.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 15b73bd377f0..abb5738a0705 100644 --- a/arch/arm/boot/dts

[PATCH 13/14] ARM: tegra: Add BSEV clock and reset for VDE on Tegra30

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra30.dtsi | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index a6781f653310..492917d61bab 100644 --- a/arch/arm/boot/dts

[PATCH 08/14] staging: media: tegra-vde: Track struct device *

From: Thierry Reding The pointer to the struct device is frequently used, so store it in struct tegra_vde. Also, pass around a pointer to a struct tegra_vde instead of struct device in some cases to prepare for subsequent patches referencing additional data from that structure. Signed-off

[PATCH 10/14] staging: media: tegra-vde: Keep VDE in reset when unused

From: Thierry Reding There is no point in keeping the VDE module out of reset when it is not in use. Reset it on runtime suspend. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/tegra-vde

[PATCH 11/14] ARM: tegra: Enable VDE on Tegra124

From: Thierry Reding Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra124.dtsi | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index b113e47b2b2a..8fdca4723205 100644 --- a/arch/arm

[PATCH 09/14] staging: media: tegra-vde: Add IOMMU support

From: Thierry Reding Implement support for using an IOMMU to map physically discontiguous buffers into contiguous I/O virtual mappings that the VDE can use. This allows importing arbitrary DMA-BUFs for use by the VDE. While at it, make sure that the device is detached from any DMA/IOMMU mapping

[PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

From: Thierry Reding The BSEV clock has a separate gate bit and can not be assumed to be always enabled. Add explicit handling for the BSEV clock and reset. This fixes an issue on Tegra124 where the BSEV clock is not enabled by default and therefore accessing the BSEV registers will hang

[PATCH 06/14] staging: media: tegra-vde: Print out invalid FD

From: Thierry Reding Include the invalid file descriptor when reporting an error message to help diagnosing why importing the buffer failed. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/14] staging: media: tegra-vde: Support reference picture marking

From: Thierry Reding Tegra114 and Tegra124 support reference picture marking, which will cause BSEV to write picture marking data to SDRAM. Make sure there is a valid destination address for that data to avoid error messages from the memory controller. Signed-off-by: Thierry Reding

[PATCH 03/14] staging: media: tegra-vde: Prepare for interlacing support

From: Thierry Reding The number of frames doubles when decoding interlaced content and the structures describing the frames double in size. Take that into account to prepare for interlacing support. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 73

[PATCH 07/14] staging: media: tegra-vde: Add some clarifying comments

From: Thierry Reding Add some comments specifying what tables are being set up in VRAM. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers

[PATCH 05/14] staging: media: tegra-vde: Properly mark invalid entries

From: Thierry Reding Entries in the reference picture list are marked as invalid by setting the frame ID to 0x3f. Signed-off-by: Thierry Reding --- drivers/staging/media/tegra-vde/tegra-vde.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-vde

[PATCH 00/14] staging: media: tegra-vdea: Add Tegra124 support

From: Thierry Reding Hi, this set of patches perform a bit of cleanup and extend support to the VDE implementation found on Tegra114 and Tegra124. This requires adding handling for a clock and a reset for the BSEV block that is separate from the main VDE block. The new VDE revision also

[PATCH 04/14] staging: media: tegra-vde: Use DRM/KMS framebuffer modifiers

From: Thierry Reding VDE on Tegra20 through Tegra114 supports reading and writing frames in 16x16 tiled layout. Similarily, the various block-linear layouts that are supported by the GPU on Tegra124 can also be read from and written to by the Tegra124 VDE. Enable userspace to specify

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

On Wed, Apr 25, 2018 at 09:30:39AM +0200, Daniel Vetter wrote: > On Wed, Apr 25, 2018 at 12:09:05AM -0700, Christoph Hellwig wrote: > > On Wed, Apr 25, 2018 at 09:02:17AM +0200, Daniel Vetter wrote: > > > Can we please not nack everything right away? Doesn't really motivate > > > me to show you

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

On Wed, Apr 25, 2018 at 12:09:05AM -0700, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 09:02:17AM +0200, Daniel Vetter wrote: > > Can we please not nack everything right away? Doesn't really motivate > > me to show you all the various things we're doing in gpu to make the > > dma layer work

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

On Tue, Apr 24, 2018 at 11:43:35PM -0700, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 08:23:15AM +0200, Daniel Vetter wrote: > > For more fun: > > > > https://www.spinics.net/lists/dri-devel/msg173630.html > > > > Yeah, sometimes we want to disable the iommu because the on-gpu > >

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: > Add PWM mode to pwm_config() function. The drivers which uses pwm_config() > were adapted to this change. > > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-s3c24xx/mach-rx1950.c | 11

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

On Tue, Jan 30, 2018 at 10:24:48AM +0100, Arnd Bergmann wrote: > On Tue, Jan 30, 2018 at 8:54 AM, Maxime Ripard > wrote: > > On Mon, Jan 29, 2018 at 03:34:02PM +0100, Arnd Bergmann wrote: > >> On Mon, Jan 29, 2018 at 10:25 AM, Linus Walleij > >>

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

On Tue, Jan 30, 2018 at 10:59:16AM +0100, Thierry Reding wrote: > On Tue, Jan 30, 2018 at 10:24:48AM +0100, Arnd Bergmann wrote: > > On Tue, Jan 30, 2018 at 8:54 AM, Maxime Ripard > > <maxime.rip...@free-electrons.com> wrote: > > > On Mon, Jan 29, 2018 at 03:34:0

Re: [PATCH v5 4/4] ARM: dts: tegra20: Add video decoder node

On Tue, Dec 12, 2017 at 03:26:10AM +0300, Dmitry Osipenko wrote: > Add Video Decoder Engine device node. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20.dtsi | 27 +++ > 1 file changed, 27 insertions(+) Applied, thanks. Thierry

Re: [PATCH v5 3/4] ARM: dts: tegra20: Add device tree node to describe IRAM

On Tue, Dec 12, 2017 at 03:26:09AM +0300, Dmitry Osipenko wrote: > From: Vladimir Zapolskiy > > All Tegra20 SoCs contain 256KiB IRAM, which is used to store > resume code and by a video decoder engine. > > Signed-off-by: Vladimir Zapolskiy > Signed-off-by:

Re: [PATCHv4 4/4] drm/tegra: add cec-notifier support

On Thu, Oct 19, 2017 at 03:37:43PM +0200, Hans Verkuil wrote: > On 10/19/17 15:30, Thierry Reding wrote: > > On Thu, Oct 19, 2017 at 03:17:16PM +0200, Thierry Reding wrote: > >> On Mon, Sep 11, 2017 at 02:29:52PM +0200, Hans Verkuil wrote: > >>> From: Hans V

Re: [PATCHv4 4/4] drm/tegra: add cec-notifier support

On Thu, Oct 19, 2017 at 03:17:16PM +0200, Thierry Reding wrote: > On Mon, Sep 11, 2017 at 02:29:52PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil <hans.verk...@cisco.com> > > > > In order to support CEC the HDMI driver has to inform the CEC driver > > when

Re: [PATCHv4 4/4] drm/tegra: add cec-notifier support

On Mon, Sep 11, 2017 at 02:29:52PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > In order to support CEC the HDMI driver has to inform the CEC driver > whenever the physical address changes. So when the EDID is read the > CEC driver has to be informed and whenever

Re: [PATCHv4 0/4] tegra-cec: add Tegra HDMI CEC support

On Thu, Oct 19, 2017 at 11:36:14AM +0200, Hans Verkuil wrote: > On 10/19/17 11:20, Thierry Reding wrote: > > On Mon, Sep 11, 2017 at 02:29:48PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil <hans.verk...@cisco.com> > >> > >> This patch series ad

Re: [PATCHv4 4/4] drm/tegra: add cec-notifier support

On Mon, Sep 11, 2017 at 02:29:52PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > In order to support CEC the HDMI driver has to inform the CEC driver > whenever the physical address changes. So when the EDID is read the > CEC driver has to be informed and whenever

Re: [PATCHv4 3/4] tegra-cec: add Tegra HDMI CEC driver

ate. In that case, the DT would look somewhat like this: hdmi@... { cec = <>; }; cec: cec@... { ... }; And then the HDMI driver could do something like: cec = cec_get(>dev); /* register notifier, ... */ That way the dependency becomes unidirectional and it seems to me like that would allow interactions between HDMI and CEC would become simpler overall. Anyway, this is something that could always be changed after the fact (except maybe for some bits needed for backwards-compatibility with old device trees), and this seems to work well enough as it is, so: Acked-by: Thierry Reding <tred...@nvidia.com> signature.asc Description: PGP signature

Re: [PATCHv4 2/4] ARM: tegra: add CEC support to tegra124.dtsi

On Mon, Sep 11, 2017 at 02:29:50PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for the Tegra CEC IP to tegra124.dtsi and enable it on the > Jetson TK1. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv4 1/4] dt-bindings: document the tegra CEC bindings

clock-names : from common clock binding: must contain "cec", > + corresponding to the entry in the clocks property. > + - hdmi-phandle : phandle to the HDMI controller, see also cec.txt. I don't understand the need for the -phandle suffix. I would've probably just gone w

Re: [PATCHv4 0/4] tegra-cec: add Tegra HDMI CEC support

On Mon, Sep 11, 2017 at 02:29:48PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series adds support for the Tegra CEC functionality. > > This v4 has been rebased to the latest 4.14 pre-rc1 mainline. > > Please review! Other than for the bindings that

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: [...] > > diff --git > > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt > > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt [...] > > +- resets : Must contain an entry for each entry in

Re: [PATCHv4 0/4] tegra-cec: add Tegra HDMI CEC support

On Sat, Oct 14, 2017 at 02:08:31PM +0200, Hans Verkuil wrote: > Hi Thierry, > > On 09/11/2017 02:29 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > This patch series adds support for the Tegra CEC functionality. > > > > This v4 has been rebased to the latest 4.14

Re: [RESEND PATCH v2 2/5] pwm: omap-dmtimer: Allow for setting dmtimer clock source

lo Dimitrov <ivo.g.dimitrov...@gmail.com> > Acked-by: Rob Herring <r...@kernel.org> > --- > Documentation/devicetree/bindings/pwm/pwm-omap-dmtimer.txt | 4 > drivers/pwm/pwm-omap-dmtimer.c | 12 +++- > 2 files changed, 11 inserti

[PATCH] [media] uvcvideo: Fix build if !MEDIA_CONTROLLER

From: Thierry Reding <tred...@nvidia.com> Accesses to the UVC device's mdev field need to be protected by a preprocessor conditional to avoid build errors, since the field is only included if the MEDIA_CONTROLLER option is selected. Fixes: 1590ad7b5271 ("[media] media-device:

Re: [PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

On Mon, Sep 21, 2015 at 11:55:53AM -0700, Bryan Wu wrote: [...] > +static int tegra_csi_s_stream(struct v4l2_subdev *subdev, int enable) > +{ > + struct tegra_csi_device *csi = to_csi(subdev); > + struct tegra_channel *chan = subdev->host_priv; > + enum tegra_csi_port_num port_num =

Re: [PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

On Mon, Sep 21, 2015 at 11:55:55AM -0700, Bryan Wu wrote: > Signed-off-by: Bryan Wu > --- > .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 > - > 1 file changed, 205 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

Hi Bryan, This patchset really needs to be Cc'ed to linux-te...@vger.kernel.org, it's becoming impossible to track it otherwise. On Mon, Sep 21, 2015 at 11:55:54AM -0700, Bryan Wu wrote: [...] > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi > b/arch/arm64/boot/dts/nvidia/tegra210.dtsi >

Re: [PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

On Mon, Sep 21, 2015 at 11:55:55AM -0700, Bryan Wu wrote: > Signed-off-by: Bryan Wu > --- > .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 > - > 1 file changed, 205 insertions(+), 6 deletions(-) Also you probably want to include

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

On Tue, Aug 25, 2015 at 04:15:58PM +0200, Hans Verkuil wrote: On 08/25/15 15:44, Thierry Reding wrote: On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: [...] For CMA we need increase the default memory size. I'd rather not rely on CMA at all, especially since we do have a way

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

On Tue, Aug 25, 2015 at 08:30:41AM +0200, Hans Verkuil wrote: A quick follow-up to Thierry's excellent review: On 08/25/2015 02:26 AM, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: snip +static void

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: [...] +#define TEGRA_CSI_PHY_CIL_COMMAND 0x0908 This doesn't seem to be used at all. Actually this PHY register

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified

Re: [RFC] How implement Secure Data Path ?

On Wed, May 06, 2015 at 03:15:32PM +0200, Daniel Vetter wrote: On Wed, May 06, 2015 at 11:19:21AM +0200, Thierry Reding wrote: On Wed, May 06, 2015 at 10:35:52AM +0200, Daniel Vetter wrote: On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: First what is Secure Data

Re: [RFC] How implement Secure Data Path ?

On Wed, May 06, 2015 at 07:29:56AM -0400, Rob Clark wrote: On Wed, May 6, 2015 at 4:35 AM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: First what is Secure Data Path ? SDP is a set of hardware features to garanty that some

Re: [RFC] How implement Secure Data Path ?

On Wed, May 06, 2015 at 10:35:52AM +0200, Daniel Vetter wrote: On Tue, May 05, 2015 at 05:54:05PM +0100, One Thousand Gnomes wrote: First what is Secure Data Path ? SDP is a set of hardware features to garanty that some memories regions could only be read and/or write by specific

Re: [PATCHv3 0/3] hdmi: add unpack and logging functions

-by: Thierry Reding tred...@nvidia.com pgpULFGjIc2lj.pgp Description: PGP signature

Re: FOSDEM15: Graphics DevRoom: call for speakers.

On Tue, Dec 09, 2014 at 03:39:26PM +0100, Luc Verhaegen wrote: On Thu, Oct 02, 2014 at 07:44:57PM +0200, Luc Verhaegen wrote: Hi, At FOSDEM on the 31st of january and the 1st of February 2015, there will be another graphics DevRoom. URL: https://fosdem.org/2015/ Slots will be handed

Re: [PATCHv2 2/3] hdmi: added unpack and logging functions for InfoFrames

On Tue, Dec 02, 2014 at 01:08:45PM +0100, Hans Verkuil wrote: From: Martin Bugge marbu...@cisco.com When receiving video it is very useful to be able to unpack the InfoFrames. Logging is useful as well, both for transmitters and receivers. Especially when implementing the VIDIOC_LOG_STATUS

Re: [PATCHv2 0/3] hdmi: add unpack and logging functions

On Thu, Dec 11, 2014 at 09:57:54AM +0100, Hans Verkuil wrote: Hi Thierry, On 12/02/14 13:08, Hans Verkuil wrote: This patch series adds new HDMI 2.0/CEA-861-F defines to hdmi.h and adds unpacking and logging functions to hdmi.c. It also uses those in the V4L2 adv7842 driver (and they

Re: [PATCH 1/3] hdmi: add new HDMI 2.0 defines

-by: Thierry Reding tred...@nvidia.com pgp8Xl95hNsoz.pgp Description: PGP signature

Re: [PATCH 2/3] hdmi: added unpack and logging functions for InfoFrames

On Fri, Nov 28, 2014 at 03:50:50PM +0100, Hans Verkuil wrote: From: Martin Bugge marbu...@cisco.com When receiving video it is very useful to be able to unpack the InfoFrames. Logging is useful as well, both for transmitters and receivers. Especially when implementing the VIDIOC_LOG_STATUS

Re: [PATCH 2/3] hdmi: added unpack and logging functions for InfoFrames

On Mon, Dec 01, 2014 at 02:48:47PM +0100, Hans Verkuil wrote: Hi Thierry, Thanks for the review, see my comments below. On 12/01/2014 02:15 PM, Thierry Reding wrote: On Fri, Nov 28, 2014 at 03:50:50PM +0100, Hans Verkuil wrote: [...] +{ + switch (type) { + case

[PATCH v2] [media] s5p-jpeg: Only build suspend/resume for PM

From: Thierry Reding tred...@nvidia.com If power management is disabled these function become unused, so there is no reason to build them. This fixes a couple of build warnings when PM(_SLEEP,_RUNTIME) is not enabled. Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Thierry

[PATCH v2] [media] s5p-fimc: Only build suspend/resume for PM

From: Thierry Reding tred...@nvidia.com If power management is disabled these functions become unused, so there is no reason to build them. This fixes a couple of build warnings when PM(_SLEEP,_RUNTIME) is not enabled. Signed-off-by: Thierry Reding tred...@nvidia.com --- Changes in v2: - add

[PATCH] [media] s5p-jpeg: Only build suspend/resume for PM

From: Thierry Reding tred...@nvidia.com If power management is disabled these function become unused, so there is no reason to build them. This fixes a couple of build warnings when PM(_SLEEP,_RUNTIME) is not enabled. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/media/platform

[PATCH] [media] s5p-fimc: Only build suspend/resume for PM

From: Thierry Reding tred...@nvidia.com If power management is disabled these functions become unused, so there is no reason to build them. This fixes a couple of build warnings when PM(_SLEEP,_RUNTIME) is not enabled. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/media/platform

Re: [PATCH] [media] s5p-fimc: Only build suspend/resume for PM

On Thu, Oct 02, 2014 at 10:43:21AM -0300, Mauro Carvalho Chehab wrote: Em Thu, 02 Oct 2014 10:48:11 +0200 Thierry Reding thierry.red...@gmail.com escreveu: From: Thierry Reding tred...@nvidia.com If power management is disabled these functions become unused, so there is no reason

Re: [PATCH v2 1/5] video: move mediabus format definition to a more standard place

On Tue, Sep 30, 2014 at 09:37:57AM +0200, Boris Brezillon wrote: On Mon, 29 Sep 2014 23:41:09 +0300 Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: [...] Incidentally, patch 2/5 in this series is missing a documentation update ;-) Yep, regarding this patch, I wonder if it's really

Re: [PATCH v2 1/5] video: move mediabus format definition to a more standard place

On Mon, Sep 29, 2014 at 04:02:39PM +0200, Boris Brezillon wrote: Rename mediabus formats and move the enum into a separate header file so that it can be used by DRM/KMS subsystem without any reference to the V4L2 subsystem. Old V4L2_MBUS_FMT_ definitions are now macros that points to

Re: [PATCH 3/5] drm: add bus_formats and nbus_formats fields to drm_display_info

On Tue, Jul 22, 2014 at 02:23:45PM +0200, Boris BREZILLON wrote: Add bus_formats and nbus_formats fields and drm_display_info_set_bus_formats helper function to specify the bus formats supported by a given display. This information can be used by display controller drivers to configure the

Re: [PATCH 5/5] drm: panel: simple-panel: add bus format information for foxlink panel

On Tue, Jul 22, 2014 at 02:23:47PM +0200, Boris BREZILLON wrote: Foxlink's fl500wvr00-a0t supports RGB888 format. Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] dma-buf/fence: Fix a kerneldoc warning

From: Thierry Reding tred...@nvidia.com kerneldoc doesn't know how to parse variables, so don't let it try. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/dma-buf/fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf

[PATCH] dma-buf/fence: Fix one more kerneldoc warning

From: Thierry Reding tred...@nvidia.com The seqno_fence_init() function's cond argument isn't described in the kerneldoc comment. Fix that to silence a warning when building DocBook documentation. Signed-off-by: Thierry Reding tred...@nvidia.com --- include/linux/seqno-fence.h | 1 + 1 file

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt [...] @@ -0,0 +1,7 @@ +Eukrea DVI-SVGA (800x600 pixels) DVI output.

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

On Tue, Jun 24, 2014 at 02:52:11PM -0500, Rob Herring wrote: On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: [...] On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] diff --git

Re: [PATCH v14 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

On Tue, Jun 24, 2014 at 11:56:39PM +0200, Eric Bénard wrote: Hi Thierry, Le Tue, 24 Jun 2014 23:49:37 +0200, Thierry Reding thierry.red...@gmail.com a écrit : On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] diff --git a/Documentation/devicetree/bindings/panel

Re: [PATCH v14 06/10] drm: drm_display_mode: add signal polarity flags

On Tue, Jun 24, 2014 at 03:57:46PM +0100, Russell King - ARM Linux wrote: On Mon, Jun 16, 2014 at 12:11:20PM +0200, Denis Carikli wrote: We need a way to pass signal polarity informations between DRM panels, and the display drivers. To do that, a pol_flags field was added to

Re: [REPOST PATCH 4/8] android: convert sync to fence api, v5

On Thu, Jun 19, 2014 at 02:28:14PM +0200, Daniel Vetter wrote: On Thu, Jun 19, 2014 at 1:48 PM, Thierry Reding thierry.red...@gmail.com wrote: With these changes, can we pull the android sync logic out of drivers/staging/ now? Afaik the google guys never really looked at this and acked

Re: [REPOST PATCH 4/8] android: convert sync to fence api, v5

On Thu, Jun 19, 2014 at 08:37:27AM +0200, Daniel Vetter wrote: On Wed, Jun 18, 2014 at 06:15:56PM -0700, Greg KH wrote: On Wed, Jun 18, 2014 at 12:37:11PM +0200, Maarten Lankhorst wrote: Just to show it's easy. Android syncpoints can be mapped to a timeline. This removes the need

Re: [Intel-gfx] [RFC] set up an sync channel between audio and display driver (i.e. ALSA and DRM)

On Tue, May 20, 2014 at 12:04:38PM +0200, Daniel Vetter wrote: Also adding dri-devel and linux-media. Please don't forget these lists for the next round. -Daniel On Tue, May 20, 2014 at 12:02:04PM +0200, Daniel Vetter wrote: Adding Greg just as an fyi since we've chatted briefly about the

Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

On Mon, May 12, 2014 at 08:48:12PM +0900, gioh.kim wrote: From: gioh.kim gioh@lge.com It might be good to fix your setup to make this be the same as the name and email used in the Signed-off-by line below. update some descriptions for API arguments and descriptions. Nit: Update since it's

Re: [PATCH v12][ 09/12] drm/panel: Add Eukrea mbimxsd51 displays.

On Mon, Apr 07, 2014 at 02:44:48PM +0200, Denis Carikli wrote: [...] +static const struct panel_desc eukrea_mbimxsd51_dvisvga = { + .modes = eukrea_mbimxsd51_dvisvga_mode, + .num_modes = 1, + .size = { + .width = 0, + .height = 0, + }, +}; [...]

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

On Thu, Dec 05, 2013 at 07:28:07PM +0100, Denis Carikli wrote: [...] diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts b/arch/arm/boot/dts/imx51-apf51dev.dts index f36a3aa..3b6de6a 100644 --- a/arch/arm/boot/dts/imx51-apf51dev.dts +++ b/arch/arm/boot/dts/imx51-apf51dev.dts @@ -19,7 +19,7 @@

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: [...] diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c [...] @@ -155,6 +156,8 @@ static int ipu_pixfmt_to_map(u32 fmt) return IPU_DC_MAP_BGR666; case

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

On Fri, Dec 06, 2013 at 02:29:22PM +0100, Lucas Stach wrote: Am Freitag, den 06.12.2013, 14:14 +0100 schrieb Thierry Reding: On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: [...] diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu

Re: V2: Agenda for the Edinburgh mini-summit

On Mon, Sep 23, 2013 at 10:27:06PM +0200, Sylwester Nawrocki wrote: On 09/23/2013 06:37 PM, Oliver Schinagl wrote: On 09/23/13 16:45, Sylwester Nawrocki wrote: Hi, I would like to have a short discussion on LED flash devices support in the kernel. Currently there are two APIs: the V4L2 and

Re: V2: Agenda for the Edinburgh mini-summit

Resending using Bryan's correct email address. On Mon, Sep 23, 2013 at 10:27:06PM +0200, Sylwester Nawrocki wrote: On 09/23/2013 06:37 PM, Oliver Schinagl wrote: On 09/23/13 16:45, Sylwester Nawrocki wrote: Hi, I would like to have a short discussion on LED flash devices support in the

Re: [PATCH RESEND] i2c: move of helpers into the core

On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap) +{ [...] +} [...] +#endif /* CONFIG_OF */ Isn't this missing the

Re: [PATCH 1/4] [media] sh_veu.c: Convert to devm_ioremap_resource()

-dev, irq, sh_veu_isr, sh_veu_bh, 0, veu, veu); Reviewed-by: Thierry Reding thierry.red...@avionic-design.de pgpj_jhgxSGrB.pgp Description: PGP signature

Re: [PATCH 2/4] [media] soc_camera/pxa_camera: Convert to devm_ioremap_resource()

= irq; pcdev-base = base; Reviewed-by: Thierry Reding thierry.red...@avionic-design.de pgpTZnjrAwC5p.pgp Description: PGP signature

Re: [PATCH 3/4] [media] soc_camera/sh_mobile_ceu_camera: Convert to devm_ioremap_resource()

)) + return PTR_ERR(base); pcdev-irq = irq; pcdev-base = base; Reviewed-by: Thierry Reding thierry.red...@avionic-design.de pgpFpVhGCuXDK.pgp Description: PGP signature

Re: [PATCH 4/4] [media] soc_camera/sh_mobile_csi2: Convert to devm_ioremap_resource()

); - return -ENXIO; - } + priv-base = devm_ioremap_resource(pdev-dev, res); + if (IS_ERR(priv-base)) + return PTR_ERR(priv-base); priv-pdev = pdev; platform_set_drvdata(pdev, priv); Reviewed-by: Thierry Reding thierry.red...@avionic-design.de

Re: [git:v4l-dvb/for_v3.9] [media] media: Convert to devm_ioremap_resource()

error messages can be removed from the failure code paths. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Hi Mauro, Greg already took this through the driver-core tree

[PATCH 14/33] media: Convert to devm_ioremap_resource()

Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Thierry

Re: [PATCHv16 0/7] of: add display helper

On Wed, Jan 09, 2013 at 09:15:41PM +0100, Steffen Trumtrar wrote: On Tue, Dec 18, 2012 at 06:04:09PM +0100, Steffen Trumtrar wrote: Hi! Finally, right in time before the end of the world on friday, v16 of the display helpers. So, any more criticism on the series? Any takers for the

Re: [RFC v2 0/5] Common Display Framework

On Thu, Nov 22, 2012 at 10:45:31PM +0100, Laurent Pinchart wrote: [...] Display entities are accessed by driver using notifiers. Any driver can register a display entity notifier with the CDF, which then calls the notifier when a matching display entity is registered. The reason for this

Re: [PATCH v12 2/6] video: add of helper for videomode

On Wed, Nov 21, 2012 at 12:48:43PM +0100, Steffen Trumtrar wrote: Hi! On Wed, Nov 21, 2012 at 10:12:43AM +, Manjunathappa, Prakash wrote: Hi Steffen, On Tue, Nov 20, 2012 at 21:24:52, Steffen Trumtrar wrote: +/** + * of_get_display_timings - parse all display_timing entries

Re: [PATCH v12 2/6] video: add of helper for videomode

On Wed, Nov 21, 2012 at 09:03:38AM -0600, Rob Herring wrote: On 11/21/2012 05:52 AM, Thierry Reding wrote: On Wed, Nov 21, 2012 at 12:48:43PM +0100, Steffen Trumtrar wrote: Hi! On Wed, Nov 21, 2012 at 10:12:43AM +, Manjunathappa, Prakash wrote: Hi Steffen, On Tue, Nov 20, 2012

Re: [PATCH v12 0/6] of: add display helper

On Tue, Nov 20, 2012 at 07:11:29PM +0100, Robert Schwebel wrote: On Tue, Nov 20, 2012 at 05:13:19PM +0100, Laurent Pinchart wrote: On Tuesday 20 November 2012 16:54:50 Steffen Trumtrar wrote: Hi! Changes since v11: - make pointers const where applicable - add reviewed-by

Re: [PATCH v10 6/6] drm_modes: add of_videomode helpers

On Thu, Nov 15, 2012 at 10:23:57AM +0100, Steffen Trumtrar wrote: [...] +int of_get_drm_display_mode(struct device_node *np, + struct drm_display_mode *dmode, unsigned int index) +{ + struct videomode vm; + int ret; + + ret = of_get_videomode(np, vm,

Re: [PATCH v10 0/6] of: add display helper

Reding thierry.red...@avionic-design.de Acked-by: Thierry Reding thierry.red...@avionic-design.de pgpy52p9Speq9.pgp Description: PGP signature

Re: [PATCH v10 0/6] of: add display helper

On Thu, Nov 15, 2012 at 11:24:11AM +0100, Thierry Reding wrote: On Thu, Nov 15, 2012 at 10:23:51AM +0100, Steffen Trumtrar wrote: Hi! Changes since v9: - don't leak memory when previous timings were correct - CodingStyle fixes - move blank lines around Regards

Re: [PATCH v8 1/6] video: add display_timing and videomode

On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: [...] diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c [...] +void display_timings_release(struct display_timings *disp) +{ + if (disp-timings) { + unsigned int i; + +

Re: [PATCH v8 2/6] video: add of helper for videomode

On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h [...] +#ifndef __LINUX_OF_DISPLAY_TIMINGS_H +#define __LINUX_OF_DISPLAY_TIMINGS_H + +#include linux/display_timing.h + +#define

Re: [PATCH v8 1/6] video: add display_timing and videomode

On Wed, Nov 14, 2012 at 11:59:25AM +0100, Steffen Trumtrar wrote: On Wed, Nov 14, 2012 at 11:56:34AM +0100, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: [...] diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c

  1   2   >