Re: [PATCH 1/2] v4l2-mem2mem: add job_write callback

2019-01-07 Thread Tomasz Figa
at runtime using CREATE_BUFS, if needed). In Chromium, we currently expect the above to hold and this feature wouldn't impact it, since we can just keep allocating buffers "big enough". If we intend to optimize things, though, we would need to know that the buffers refer to the same frame, so we can put it in the same target buffer for the higher layers of processing. I think this all needs to be defined in the Stateful Encoder Interface. Otherwise, the patch is: Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-20 Thread Tomasz Figa
On Fri, Dec 21, 2018 at 7:24 AM Laurent Pinchart wrote: > > Hellon > > On Sunday, 16 December 2018 09:26:18 EET Laurent Pinchart wrote: > > Hello Yong, > > > > Could you please have a look at the crash reported below ? > > A bit more information to help you debugging this. I've enabled KASAN in th

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 6:18 PM Jonas Karlman wrote: > > On 2018-12-19 08:16, Tomasz Figa wrote: > > On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: > >> On 2018-12-19 06:10, Tomasz Figa wrote: > >>> On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil > &

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 11:51 PM Christoph Hellwig wrote: > > On Wed, Dec 19, 2018 at 05:18:35PM +0900, Tomasz Figa wrote: > > The existing code that deals with dma_alloc_attrs() without > > DMA_ATTR_NON_CONSISTENT would just call dma_get_sgtable_attrs() like > >

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 4:51 PM Christoph Hellwig wrote: > > On Tue, Dec 18, 2018 at 06:48:03PM +0900, Tomasz Figa wrote: > > > So as I said you can call dma_alloc_attrs with DMA_ATTR_NON_CONSISTENT > > > in a loop with a suitably small chunk size, then stuff the results

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-18 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: > > On 2018-12-19 06:10, Tomasz Figa wrote: > > On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil > > wrote: > >> On 12/12/18 7:28 PM, Jonas Karlman wrote: > >>> Hi Hans, > >>> > >>

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-18 Thread Tomasz Figa
On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil wrote: > > On 12/12/18 7:28 PM, Jonas Karlman wrote: > > Hi Hans, > > > > Since this function only return DEQUEUED and DONE buffers, > > it cannot be used to find a capture buffer that is both used for > > frame output and is part of the frame reference

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-18 Thread Tomasz Figa
On Tue, Dec 18, 2018 at 4:38 PM Christoph Hellwig wrote: > > On Tue, Dec 18, 2018 at 04:22:43PM +0900, Tomasz Figa wrote: > > It kind of limits the usability of this API, since it enforces > > contiguous allocations even for big sizes even for devices behind > > IOMMU (c

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-17 Thread Tomasz Figa
On Fri, Dec 14, 2018 at 9:36 PM Christoph Hellwig wrote: > > On Fri, Dec 14, 2018 at 12:12:38PM +0900, Tomasz Figa wrote: > > > If the buffer always is physically contiguous, as it is in the currently > > > posted series, we can always map it with a single dma_map_s

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-13 Thread Tomasz Figa
On Thu, Dec 13, 2018 at 11:03 PM Christoph Hellwig wrote: > > On Thu, Dec 13, 2018 at 12:13:29PM +0900, Tomasz Figa wrote: > > Putting aside the problem of memory without struct page, one thing to > > note here that what is a contiguous DMA range for device X, may not be > &g

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Tomasz Figa
On Wed, Dec 12, 2018 at 10:54 PM Christoph Hellwig wrote: > > On Wed, Dec 12, 2018 at 06:34:25PM +0900, Tomasz Figa wrote: > > The typical DMA-buf import/export flow is as follows: > > 1) Driver X allocates buffer A using this API for device x and gets a > > DMA address

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Tomasz Figa
On Wed, Dec 12, 2018 at 6:09 PM Christoph Hellwig wrote: > > On Wed, Dec 12, 2018 at 05:57:02PM +0900, Tomasz Figa wrote: > > How about dma_sync_sg_*()? I'd expect some drivers to export/import > > such memory via sg, since that's the typical way of describing memory

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Tomasz Figa
Hi Christoph, On Sat, Dec 8, 2018 at 12:25 AM Christoph Hellwig wrote: > > Folks, can you take a look at this tree and see if this is useful > for USB: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-noncoherent-allocator > > The idea is that you use dma_alloc_attrs with t

Re: [PATCH 1/1] ipu3-imgu: Fix compiler warnings

2018-12-10 Thread Tomasz Figa
{ > u64 ns = ktime_get_ns(); > struct ipu3_css_buffer *b; > - struct imgu_buffer *buf; > + struct imgu_buffer *buf = NULL; > unsigned int node, pipe; > bool dummy; Reviewed-by: Tomasz Figa Both cases look very straightforward, I wonder why they triggered those false positives... Best regards, Tomasz

Re: Invite for IRC meeting: Re: [PATCHv4 01/10] videodev2.h: add tag support

2018-12-10 Thread Tomasz Figa
it 9am UTC. > > E, g: > > > https://www.timeanddate.com/worldclock/meetingdetails.html?year=2018&month=12&day=12&hour=9&min=0&sec=0&p1=45&p2=101&p3=248 > Okay, sorry, I got the time zones mixed up. Nevertheless, it works for me. :) >

Re: Invite for IRC meeting: Re: [PATCHv4 01/10] videodev2.h: add tag support

2018-12-09 Thread Tomasz Figa
very busy on Monday and Tuesday. Do you mean Wednesday in your time zone? If so, that would be Thursday for Europe and Asia. Regardless of that, it should work for me. Best regards, Tomasz >> >> Regards, >> Mauro >> >> Em 10 de dezembro de 2018 01:18:38 BRST, Tom

Re: [PATCH v3] v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields

2018-12-09 Thread Tomasz Figa
ver. > > Suggested-by: Tomasz Figa > Signed-off-by: Ezequiel Garcia > Acked-by: Sakari Ailus > -- > v3: > * s/int/unsigned int, suggested by Sakari > > v2: > * Drop unneeded clear in g_fmt. > The sturct was already being cleared here. > * Only ze

Re: Invite for IRC meeting: Re: [PATCHv4 01/10] videodev2.h: add tag support

2018-12-09 Thread Tomasz Figa
lusion, since we need to decide this soon since this is critical > for stateless codec support. > > Unfortunately timezone-wise this is a bit of a nightmare. I think > that at least Mauro, myself and Tomasz Figa should be there, so UTC-2, > UTC+1 and UTC+9 (if I got that right). >

Re: [PATCH] media: unify some sony camera sensors pattern naming

2018-12-09 Thread Tomasz Figa
Hi Sakari, Bingbu, On Mon, Dec 3, 2018 at 7:25 PM Sakari Ailus wrote: > > Hi Bing Bu, Tomasz, > > On Mon, Dec 03, 2018 at 10:53:34AM +0800, Bingbu Cao wrote: > > > > > > On 12/01/2018 02:08 AM, Tomasz Figa wrote: > > > Hi Bingbu, > > > > >

Re: [PATCH RFC 08/15] media: replace **** with a hug

2018-12-01 Thread Tomasz Figa
On Fri, Nov 30, 2018 at 11:28 AM Jarkko Sakkinen wrote: > > In order to comply with the CoC, replace with a hug. In > addition, fix a coding style issue (lines with over 80 chars). > > Signed-off-by: Jarkko Sakkinen > --- > drivers/media/i2c/bt819.c | 8 +--- > 1 file changed, 5 inserti

Re: [PATCH] media: unify some sony camera sensors pattern naming

2018-11-30 Thread Tomasz Figa
Hi Bingbu, On Mon, Nov 26, 2018 at 7:56 PM wrote: > > From: Bingbu Cao > > Some Sony camera sensors have same test pattern > definitions, this patch unify the pattern naming > to make it more clear to the userspace. > > Suggested-by: Sakari Ailus > Signed-off-by: Bingbu Cao > --- > drivers/me

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > Hello Yong, > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > > Hi, > > > > This series adds support for the Intel IPU3 (Image Processing Unit) > > ImgU which is essentially a modern memory-to-memory ISP. It implements > > ra

Re: [PATCH v3] media: venus: add support for key frame

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 3:10 AM wrote: > > > Hi Stan, > > On 2018-11-29 16:01, Stanimir Varbanov wrote: > > Hi Tomasz, > > > > On 11/3/18 5:01 AM, Tomasz Figa wrote: > >> Hi Malathi, > >> > >> On Fri, Nov 2, 2018 at 9:58 PM Malath

Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil wrote: > > On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > > OUTPUT) formats may not be able to trigger this event. > > > > Add a enum_fmt format flag to tag those specific formats.

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-28 Thread Tomasz Figa
On Wed, Nov 28, 2018 at 10:05 AM Ezequiel Garcia wrote: > > On Tue, 2018-11-27 at 19:09 +0900, Tomasz Figa wrote: > > On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia > > wrote: > > [snip] > > > > > +const struct rockchip_vpu_variant rk3288_vpu_variant

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-27 Thread Tomasz Figa
On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia wrote: [snip] > > > +const struct rockchip_vpu_variant rk3288_vpu_variant = { > > > + .enc_offset = 0x0, > > > + .enc_fmts = rk3288_vpu_enc_fmts, > > > + .num_enc_fmts = ARRAY_SIZE(rk3288_vpu_enc_fmts), > > > + .codec_ops = rk

Re: [PATCH v3] media: venus: amend buffer size for bitstream plane

2018-11-27 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 1:41 AM Hans Verkuil wrote: > > On 11/26/2018 05:07 PM, Tomasz Figa wrote: > > On Tue, Nov 27, 2018 at 1:00 AM Hans Verkuil wrote: > >> > >> On 11/26/2018 04:44 PM, Tomasz Figa wrote: > >>> Hi Hans, > >>> >

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-26 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 8:29 AM Ezequiel Garcia wrote: > > On Mon, 2018-11-26 at 13:14 +0900, Tomasz Figa wrote: > > Hi Ezequiel, > > > > On Sat, Nov 24, 2018 at 2:20 AM Ezequiel Garcia > > wrote: > > > Make the core set the reserved fields to z

Re: [PATCH v3] media: venus: amend buffer size for bitstream plane

2018-11-26 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 1:00 AM Hans Verkuil wrote: > > On 11/26/2018 04:44 PM, Tomasz Figa wrote: > > Hi Hans, > > > > On Tue, Nov 27, 2018 at 12:24 AM Hans Verkuil wrote: > >> > >> On 11/26/2018 03:57 PM, Stanimir Varbanov wrote: > >>>

Re: [PATCH v3] media: venus: amend buffer size for bitstream plane

2018-11-26 Thread Tomasz Figa
Hi Hans, On Tue, Nov 27, 2018 at 12:24 AM Hans Verkuil wrote: > > On 11/26/2018 03:57 PM, Stanimir Varbanov wrote: > > Hi Hans, > > > > On 11/26/18 3:37 PM, Hans Verkuil wrote: > >> On 11/26/2018 11:12 AM, Malathi Gottam wrote: > >>> Accept the buffer size requested by client and compare it > >>>

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-25 Thread Tomasz Figa
> and every driver. > > Suggested-by: Tomasz Figa > Signed-off-by: Ezequiel Garcia > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 51 > 1 file changed, 45 insertions(+), 6 deletions(-) > Thanks for the patch. Please see my comments inline. > diff

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-11-25 Thread Tomasz Figa
GPL or the GFDL 1.1+ license, at your option. Note that this > +.. dual licensing only applies to this file, and not this project as a > +.. whole. > +.. > +.. a) This file is free software; you can redistribute it and/or > +..modify it under the terms of the GNU General Public License as > +..published by the Free Software Foundation; either version 2 of > +..the License, or (at your option) any later version. > +.. > +..This file is distributed in the hope that it will be useful, > +..but WITHOUT ANY WARRANTY; without even the implied warranty of > +..MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +..GNU General Public License for more details. > +.. > +.. Or, alternatively, > +.. > +.. b) Permission is granted to copy, distribute and/or modify this > +..document under the terms of the GNU Free Documentation License, > +..Version 1.1 or any later version published by the Free Software > +..Foundation, with no Invariant Sections, no Front-Cover Texts > +..and no Back-Cover Texts. A copy of the license is included at > +..Documentation/media/uapi/fdl-appendix.rst. > +.. > +.. TODO: replace it to GPL-2.0 OR GFDL-1.1-or-later WITH > no-invariant-sections > > .. _request-func-poll: > > > Verified with a grep over Documentation/media that this patch replaces all the instances of "GFDL-1.1-or-later WITH" and so: Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH] media: uvcvideo: Add boottime clock support

2018-11-23 Thread Tomasz Figa
Hi Laurent, On Fri, Nov 2, 2018 at 12:03 AM Lars-Peter Clausen wrote: > > On 11/01/2018 03:30 PM, Tomasz Figa wrote: > > On Thu, Nov 1, 2018 at 11:03 PM Laurent Pinchart > > wrote: > >> > >> Hi Alexandru, > >> > >> On Thursday, 18 October

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 10:46 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Thu, Nov 22, 2018 at 04:06:36PM +0900, Tomasz Figa wrote: > > Hi Ning, > > > > On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A > > wrote: > > > > > > Hello everyon

Re: [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 7:29 PM Hans Verkuil wrote: > > Hi Ezeguiel, > > Just saw Tomasz' in-depth review and decided to drop this pull request. > > He found a few too many issues and I prefer those are addressed first. > > Sorry, still more work for you, on to v11! I'm really sorry for the late

Re: [PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-22 Thread Tomasz Figa
reg = <0x0 0xff650800 0x0 0x40>; > @@ -1233,8 +1245,8 @@ > interrupt-names = "vpu_mmu"; > clocks = <&cru ACLK_VCODEC>, <&cru HCLK_VCODEC>; > clock-names = "aclk", "iface"; > + power-domains = <&power RK3399_PD_VCODEC>; > #iommu-cells = <0>; > - status = "disabled"; > }; > > vdec_mmu: iommu@ff660480 { Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-22 Thread Tomasz Figa
; interrupt-names = "vpu_mmu"; > clocks = <&cru ACLK_VCODEC>, <&cru HCLK_VCODEC>; > clock-names = "aclk", "iface"; > + power-domains = <&power RK3288_PD_VIDEO>; > #iommu-cells = <0>; > - status = "disabled"; > }; > > hevc_mmu: iommu@ff9c0440 { Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-22 Thread Tomasz Figa
| VEPU_REG_AXI_CTRL_BURST_LEN(16) > + | VEPU_REG_AXI_CTRL_OUTPUT_SWAP32 > + | VEPU_REG_AXI_CTRL_INPUT_SWAP32 > + | VEPU_REG_AXI_CTRL_OUTPUT_SWAP8 > + | VEPU_REG_AXI_CTRL_INPUT_SWAP8; > + vepu_write_relax

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Tomasz Figa
Hi Ning, On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A wrote: > > Hello everyone > > when we need to setup media pipeline, eg, for camera capture, media-ctl > needs to be called multiple time to setup media link and subdev > formats, or similar code in a single application. this will use > multi

[PATCH] media: mtk-vcodec: Remove VA from encoder frame buffers

2018-11-20 Thread Tomasz Figa
contiguous kernel mappings, which includes the MTK DRM driver. Signed-off-by: Tomasz Figa --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 6 +- drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h | 5 + drivers/media/platform/mtk-vcodec/venc_drv_if.h | 2 +- 3 files changed

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-19 Thread Tomasz Figa
On Mon, Nov 19, 2018 at 6:54 PM Hans Verkuil wrote: > > On 11/19/2018 09:44 AM, Hans Verkuil wrote: > > On 11/19/2018 06:27 AM, Tomasz Figa wrote: > >> On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote: > >>> > >>> On 11/16/2018 09:43 AM, Tomasz Fig

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-18 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote: > > On 11/16/2018 09:43 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling VIDIOC_DQBUF can release the core serialization lock pointed to

Re: [ANN] Edinburgh Media Summit 2018 meeting report

2018-11-18 Thread Tomasz Figa
On Sun, Nov 18, 2018 at 7:45 AM Sakari Ailus wrote: > > Hello everyone, > > > Here's the report on the Media Summit held on 25th October in Edinburgh. > The report is followed by the stateless codec discussion two days earlier. > > Note: this is bcc'd to the meeting attendees plus a few others. I

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: > > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag'

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: > > On 11/16/2018 09:34 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling the stop_streaming op can release the core serialization loc

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling VIDIOC_DQBUF can release the core serialization lock pointed to > by vb2_queue->lock if it has to wait for a new buffer to arrive. > > However, if userspace dup()ped the video device filehandle, then it is > possible to rea

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling the stop_streaming op can release the core serialization lock > pointed to by vb2_queue->lock if it has to wait for buffers to finish. > An example of that behavior is the vivid driver. Why would vb2_queue->lock have to be

Re: [PATCH v2 0/2] media: cedrus: Add H264 decoding support

2018-11-15 Thread Tomasz Figa
Hi Maxime, On Thu, Nov 15, 2018 at 11:56 PM Maxime Ripard wrote: > > > Hi, > > Here is a new version of the H264 decoding support in the cedrus > driver. > > As you might already know, the cedrus driver relies on the Request > API, and is a reverse engineered driver for the video decoding engine

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-15 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 1:35 PM wrote: > > On 2018-11-14 09:21, Tomasz Figa wrote: > > On Tue, Nov 13, 2018 at 7:46 PM Stanimir Varbanov > > wrote: > >> > >> Hi Tomasz, > >> > >> On 11/13/18 11:13 AM, Tomasz Figa wrote: > >> &g

Re: [PATCH] media: venus: fix reported size of 0-length buffers

2018-11-15 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 1:50 AM Nicolas Dufresne wrote: > > Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit : > > On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne > > wrote: > > > > > > > > > Le mar. 13 nov. 2018 04 h 30, Alexandre Courbot a > > > écrit : > > > > The last

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Tomasz Figa
fers might be still in processing. > > > > To let userspace know that the kernel now supports orphaning buffers > > that are still in use, add a new V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS > > to be set by reqbufs and create_bufs. > > > > Signed-off-by: John Sheu

Re: [PATCH v1 4/5] media: venus: video decoder drop frames handling

2018-11-14 Thread Tomasz Figa
On Sat, Sep 29, 2018 at 9:01 PM Srinu Gorle wrote: > > - when drop frame flag received from venus h/w, reset buffer > parameters and update v4l2 buffer flags as error buffer. > > Signed-off-by: Srinu Gorle > --- > drivers/media/platform/qcom/venus/vdec.c | 6 ++ > 1 file changed, 6 inserti

Re: [PATCH v1 3/5] media: venus: do not destroy video session during queue setup

2018-11-14 Thread Tomasz Figa
On Fri, Nov 9, 2018 at 7:00 PM Stanimir Varbanov wrote: > > Hi Srinu, > > On 9/29/18 3:00 PM, Srinu Gorle wrote: > > - open and close video sessions for plane properties is incorrect. > > Could you rephrase this statement? I really don't understand what you mean. > > > - add check to ensure, same

Re: [PATCH v1 2/5] media: venus: dynamically configure codec type

2018-11-14 Thread Tomasz Figa
On Sat, Sep 29, 2018 at 9:01 PM Srinu Gorle wrote: > > - currently video decoder instance is hardcoded to H.264 video format. > - this change enables video decoder dynamically configure to > any supported video format. > > Signed-off-by: Srinu Gorle > --- > drivers/media/platform/qcom/venus/he

Re: [PATCH v1 1/5] media: venus: handle video decoder resolution change

2018-11-14 Thread Tomasz Figa
Hi Srinu, On Sat, Sep 29, 2018 at 9:01 PM Srinu Gorle wrote: > > Add logic for below to handle resolution change during video decode. > - stream off support for video decoder OUTPUT plane and > flush old resolution OUTPUT plane buffers. I think you mean CAPTURE (the decoded buffers)? > - De-a

Re: [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units

2018-11-14 Thread Tomasz Figa
Hi Sakari, On Fri, Sep 28, 2018 at 11:00 PM Hans Verkuil wrote: > > On 09/25/2018 12:14 PM, Sakari Ailus wrote: > > Add support for exponential bases, prefixes as well as units for V4L2 > > controls. This makes it possible to convey information on the relation > > between the control value and th

Re: [PATCH 0/2] media: intel-ipu3: allow the media graph to be used even if a subdev fails

2018-11-14 Thread Tomasz Figa
Hi Hans, On Thu, Sep 27, 2018 at 7:22 PM Hans Verkuil wrote: > > On 09/27/2018 12:13 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 27 Sep 2018 11:52:35 +0200 > > Hans Verkuil escreveu: > > > >> Hi Javier, > >> > >> On 09/04/2018 01:30 PM, Javier Martinez Canillas wrote: > >>> Hello, > >>> > >>> T

Re: [RFC PATCH 0/3] Media Controller Properties

2018-11-14 Thread Tomasz Figa
Hi Hans, On Fri, Aug 3, 2018 at 11:36 PM Hans Verkuil wrote: > > From: Hans Verkuil > > This RFC patch series implements properties for the media controller. > > This is not finished, but I wanted to post this so people can discuss > this further. > > No documentation yet (too early for that). >

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-13 Thread Tomasz Figa
On Tue, Nov 13, 2018 at 7:46 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 11/13/18 11:13 AM, Tomasz Figa wrote: > > On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov > > wrote: > >> > >> Hi Malathi, > >> > >> On 11/13/18 9:28

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Tomasz Figa
in processing. > > > > > > To let userspace know that the kernel now supports orphaning buffers > > > that are still in use, add a new V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS > > > to be set by reqbufs and create_bufs. > > > > > > Signed-off-by: Joh

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-11-13 Thread Tomasz Figa
On Tue, Nov 13, 2018 at 5:12 PM Stanimir Varbanov wrote: > > Hi Malathi, > > On 11/13/18 9:28 AM, mgot...@codeaurora.org wrote: > > On 2018-11-12 18:04, Stanimir Varbanov wrote: > >> Hi Tomasz, > >> > >> On 10/23/2018 05:50 AM, Tomasz Figa wrote: >

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-10 Thread Tomasz Figa
On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne wrote: > > Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > > In this patch we should consider a way to tell userspace that this has > > > been opt in, otherwise existing userspace will have to remain usin

Re: [PATCH v2] media: venus: add support for selection rectangles

2018-11-09 Thread Tomasz Figa
Hi Malathi, On Fri, Nov 9, 2018 at 6:20 PM wrote: > > On 2018-11-09 07:56, Tomasz Figa wrote: > > Hi Malathi, > > > > On Fri, Nov 9, 2018 at 4:39 PM Malathi Gottam > > wrote: > >> > >> Handles target type crop by setting the new active rectang

Re: [PATCH v2] media: venus: add support for selection rectangles

2018-11-08 Thread Tomasz Figa
Hi Malathi, On Fri, Nov 9, 2018 at 4:39 PM Malathi Gottam wrote: > > Handles target type crop by setting the new active rectangle > to hardware. The new rectangle should be within YUV size. > > Signed-off-by: Malathi Gottam > --- > drivers/media/platform/qcom/venus/venc.c | 26 +

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-07 Thread Tomasz Figa
Hi Nicolas, On Sat, Oct 27, 2018 at 6:38 PM Nicolas Dufresne wrote: > > Le lundi 22 octobre 2018 à 12:37 +0900, Tomasz Figa a écrit : > > Hi Philipp, > > > > On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > > > > > On Wed, Oct 03, 2

Re: [PATCH v4 6/6] media: uvcvideo: Move decode processing to process context

2018-11-06 Thread Tomasz Figa
Hi Kieran, On Wed, Nov 7, 2018 at 12:13 AM Kieran Bingham wrote: > > Hi Tomasz, > > On 07/08/2018 10:54, Tomasz Figa wrote: > > Hi Kieran, > > > > On Wed, Mar 28, 2018 at 1:47 AM Kieran Bingham > > wrote: > > [snip] > >> @@ -1544,25

Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver

2018-11-05 Thread Tomasz Figa
t; > Subject: Re: [PATCH v7 06/16] intel-ipu3: mmu: Implement driver > > > > Hi Yong, > > > > On Mon, Oct 29, 2018 at 03:23:00PM -0700, Yong Zhi wrote: > > > From: Tomasz Figa > > > > > > This driver translates IO virtua

Re: [PATCH v3] media: venus: add support for key frame

2018-11-02 Thread Tomasz Figa
Hi Malathi, On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote: > > When client requests for a keyframe, set the property > to hardware to generate the sync frame. > > Signed-off-by: Malathi Gottam > --- > drivers/media/platform/qcom/venus/venc_ctrls.c | 20 +++- > 1 file chang

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-02 Thread Tomasz Figa
Hi Mauro, On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab wrote: > > Em Mon, 29 Oct 2018 15:22:57 -0700 > Yong Zhi escreveu: [snip] > > +struct ipu3_uapi_awb_config_s { > > + __u16 rgbs_thr_gr; > > + __u16 rgbs_thr_r; > > + __u16 rgbs_thr_gb; > > + __u16 rgbs_thr_b; > > +

Re: [PATCH] media: venus: add support for selection rectangles

2018-11-01 Thread Tomasz Figa
On Fri, Nov 2, 2018 at 12:02 AM Stanimir Varbanov wrote: > > Hi Malathi, > > On 11/1/18 3:10 PM, mgot...@codeaurora.org wrote: > > On 2018-10-16 15:11, Stanimir Varbanov wrote: > >> Hi Malathi, > >> > >> On 10/09/2018 10:53 AM, Malathi Gottam wrote: > >>> Handles target type crop by setting the ne

Re: [PATCH] media: venus: dynamic handling of bitrate

2018-11-01 Thread Tomasz Figa
On Thu, Nov 1, 2018 at 11:23 PM Vikash Garodia wrote: > > On 2018-11-01 19:23, Tomasz Figa wrote: > > On Thu, Nov 1, 2018 at 10:01 PM wrote: > >> > >> On 2018-11-01 17:48, Stanimir Varbanov wrote: > >> > Hi Malathi, > >> > > >> >

Re: [PATCH] media: uvcvideo: Add boottime clock support

2018-11-01 Thread Tomasz Figa
On Thu, Nov 1, 2018 at 11:03 PM Laurent Pinchart wrote: > > Hi Alexandru, > > On Thursday, 18 October 2018 20:28:06 EET Alexandru M Stan wrote: > > On Wed, Oct 17, 2018 at 9:31 PM, Tomasz Figa wrote: > > > On Thu, Oct 18, 2018 at 5:50 AM Laurent Pinchart wrote: >

Re: [PATCH] media: venus: dynamic handling of bitrate

2018-11-01 Thread Tomasz Figa
On Thu, Nov 1, 2018 at 10:01 PM wrote: > > On 2018-11-01 17:48, Stanimir Varbanov wrote: > > Hi Malathi, > > > > Thanks for the patch! > > > > On 10/31/18 9:42 AM, Malathi Gottam wrote: > >> Any request for a change in bitrate after both planes > >> are streamed on is handled by setting the target

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Tomasz Figa
Hi Dmitry, On Wed, Oct 31, 2018 at 6:46 PM Hans Verkuil wrote: > > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: [snip] > > > > Do I understand it correctly that when a process opens /dev/video* or > > /dev/media* it gets a private instance of the device? In particular, > > if several processes te

Re: [RFC 2/3] USB: core: Add non-coherent buffer allocation helpers

2018-10-30 Thread Tomasz Figa
Hi Christoph and everyone, On Fri, Aug 31, 2018 at 3:51 PM Tomasz Figa wrote: > > On Fri, Aug 31, 2018 at 2:50 PM Christoph Hellwig wrote: > > > > On Thu, Aug 30, 2018 at 07:11:35PM -0300, Ezequiel Garcia wrote: > > > On Thu, 2018-08-30 at 10:58 -0700, Christoph He

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-29 Thread Tomasz Figa
On Mon, Oct 29, 2018 at 7:06 PM Tomasz Figa wrote: > > Hi Stanimir, > > On Mon, Oct 29, 2018 at 6:45 PM Stanimir Varbanov > wrote: > > > > Hi Tomasz, > > > > On 10/22/2018 05:48 PM, Tomasz Figa wrote: > > > Due to complexity of the video deco

Re: [PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-29 Thread Tomasz Figa
Hi Stanimir, On Mon, Oct 29, 2018 at 6:45 PM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 10/22/2018 05:48 PM, Tomasz Figa wrote: > > Due to complexity of the video decoding process, the V4L2 drivers of > > stateful decoder hardware require specific sequences of

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-26 Thread Tomasz Figa
On Thu, Sep 20, 2018 at 11:42 PM Hans Verkuil wrote: > > Some parts of the V4L2 API are awkward to use and I think it would be > a good idea to look at possible candidates for that. > > Examples are the ioctls that use struct v4l2_buffer: the multiplanar support > is > really horrible, and writin

Re: [PATCH 1/2] vicodec: Have decoder propagate changes to the CAPTURE queue

2018-10-26 Thread Tomasz Figa
On Fri, Oct 19, 2018 at 10:00 PM Ezequiel Garcia wrote: > > On Fri, 2018-10-19 at 09:14 +0200, Hans Verkuil wrote: > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > > The decoder interface (not yet merged) specifies that > > > width and height values set on the OUTPUT queue, must > > > be pro

Re: [PATCH v2] media: venus: add support for key frame

2018-10-25 Thread Tomasz Figa
On Thu, Oct 25, 2018 at 4:23 PM Vikash Garodia wrote: > > On 2018-10-24 20:02, Tomasz Figa wrote: > > On Wed, Oct 24, 2018 at 10:52 PM Malathi Gottam > > wrote: > >> > >> When client requests for a keyframe, set the property > >> to hardware to gen

Re: [PATCH v2] media: venus: add support for key frame

2018-10-24 Thread Tomasz Figa
On Wed, Oct 24, 2018 at 10:52 PM Malathi Gottam wrote: > > When client requests for a keyframe, set the property > to hardware to generate the sync frame. > > Signed-off-by: Malathi Gottam > --- > drivers/media/platform/qcom/venus/venc_ctrls.c | 16 +++- > 1 file changed, 15 insertio

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-23 Thread Tomasz Figa
On Tue, Oct 23, 2018 at 6:17 AM Hans Verkuil wrote: > > A quick update: > > As said in my previous email: we'll meet at 11 am at the registration desk. > From there we go to the Platform 5 Cafe. If that's too crowded/noisy, then > we'll try the Sheraton hotel. > > Tomasz, I'll ping you on irc when

Re: [RFC PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2018-10-22 Thread Tomasz Figa
Hi Alex, On Fri, Oct 19, 2018 at 5:09 PM Alexandre Courbot wrote: > > Thanks everyone for the feedback on v2! I have not replied to all the > individual emails but hope this v3 will address some of the problems > raised and become a continuation point for the topics still in > discussion (probabl

Re: [PATCH] media: venus: add support for key frame

2018-10-22 Thread Tomasz Figa
On Mon, Oct 22, 2018 at 3:15 PM Alexandre Courbot wrote: > > On Fri, Oct 12, 2018 at 5:10 PM Stanimir Varbanov > wrote: > > > > > > > > On 10/12/2018 11:06 AM, Alexandre Courbot wrote: > > > On Fri, Oct 12, 2018 at 4:37 PM Stanimir Varbanov > > > wrote: > > >> > > >> Hi Alex, > > >> > > >> On 10

Re: [PATCH] media: venus: amend buffer size for bitstream plane

2018-10-22 Thread Tomasz Figa
Hi Malathi, On Tue, Oct 9, 2018 at 4:58 PM Malathi Gottam wrote: > > For lower resolutions, incase of encoder, the compressed > frame size is more than half of the corresponding input > YUV. Keep the size as same as YUV considering worst case. > > Signed-off-by: Malathi Gottam > --- > drivers/m

Re: [PATCH v2 0/2] Document memory-to-memory video codec interfaces

2018-10-22 Thread Tomasz Figa
Hi Hans, On Tue, Oct 23, 2018 at 12:41 AM Hans Verkuil wrote: > > Hi Tomasz, Alexandre, > > Thank you for all your work! Much appreciated. > > I've applied both the stateful and stateless patches on top of the > request_api branch > and made the final result available here: > > https://hverkuil.

[PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2018-10-22 Thread Tomasz Figa
thing missing was the real specification included as a part of Linux Media documentation. Fix it now and document the encoder part of the Codec API. Signed-off-by: Tomasz Figa --- Documentation/media/uapi/v4l/dev-encoder.rst | 579 ++ Documentation/media/uapi/v4l/devices.rst

[PATCH v2 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-22 Thread Tomasz Figa
-mfc or coda. The only thing missing was the real specification included as a part of Linux Media documentation. Fix it now and document the decoder part of the Codec API. Signed-off-by: Tomasz Figa --- Documentation/media/uapi/v4l/dev-decoder.rst | 1082 + Documentation/media

[PATCH v2 0/2] Document memory-to-memory video codec interfaces

2018-10-22 Thread Tomasz Figa
ts suggested in review comments. For changes since RFC see the v1: https://lore.kernel.org/patchwork/project/lkml/list/?series=360520 Tomasz Figa (2): media: docs-rst: Document memory-to-memory video decoder interface media: docs-rst: Document memory-to-memory video encoder interface Documentation

Re: [RFC PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2018-10-21 Thread Tomasz Figa
On Mon, Oct 22, 2018 at 3:39 PM Alexandre Courbot wrote: > > On Mon, Oct 22, 2018 at 3:22 PM Tomasz Figa wrote: > > > > On Mon, Oct 22, 2018 at 3:05 PM Alexandre Courbot > > wrote: > > > > > > On Fri, Oct 19, 2018 at 5:44 PM Hans Verkuil wrote: &g

Re: [RFC PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2018-10-21 Thread Tomasz Figa
drus VPU driver > > > > > > As such, some things may not be entirely consistent with the current > > > state of drivers, so it would be great if all stakeholders could point > > > out these inconsistencies. :) > > > > > > This patch is supposed to

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-21 Thread Tomasz Figa
On Sun, Oct 21, 2018 at 6:23 PM Laurent Pinchart wrote: > > Hi Tomasz, > > On Saturday, 20 October 2018 11:52:57 EEST Tomasz Figa wrote: > > On Thu, Oct 18, 2018 at 8:22 PM Laurent Pinchart wrote: > > > On Thursday, 18 October 2018 13:03:33 EEST Tomasz Figa wrote: >

Re: [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2018-10-21 Thread Tomasz Figa
On Thu, Oct 18, 2018 at 12:19 AM Laurent Pinchart wrote: > > Hi Tomasz, > > Thank you for the patch. > Thanks for the review. I'll snip out the comments that I've already addressed. > On Tuesday, 24 July 2018 17:06:21 EEST Tomasz Figa wrote: [snip] > >

Re: [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2018-10-21 Thread Tomasz Figa
On Tue, Oct 16, 2018 at 10:50 PM Hans Verkuil wrote: > > On 10/16/18 09:36, Tomasz Figa wrote: > > On Tue, Aug 7, 2018 at 3:54 PM Tomasz Figa wrote: > >>>> + * The driver must expose following selection targets on ``OUTPUT``: > >>>>

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-10-21 Thread Tomasz Figa
Hi Philipp, On Mon, Oct 22, 2018 at 1:28 AM Philipp Zabel wrote: > > On Wed, Oct 03, 2018 at 05:24:39PM +0900, Tomasz Figa wrote: > [...] > > > Yes, but that would fall in a complete redesign I guess. The buffer > > > allocation scheme is very inflexible. Yo

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-20 Thread Tomasz Figa
On Sun, Oct 21, 2018 at 6:53 AM Sakari Ailus wrote: > > Hi Tomasz, > > On Thu, Oct 18, 2018 at 12:24:31PM +0900, Tomasz Figa wrote: > > On Tue, Oct 16, 2018 at 8:50 PM Sakari Ailus > > wrote: > > > > > > Hi Tomasz, > > > > > >

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-20 Thread Tomasz Figa
On Thu, Oct 18, 2018 at 7:03 PM Tomasz Figa wrote: > > Hi Laurent, > > On Wed, Oct 17, 2018 at 10:34 PM Laurent Pinchart > wrote: > > > > Hi Tomasz, > > > > Thank you for the patch. > > Thanks for your comments! Please see my replies inline. >

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-20 Thread Tomasz Figa
On Thu, Oct 18, 2018 at 7:03 PM Tomasz Figa wrote: > > Hi Laurent, > > On Wed, Oct 17, 2018 at 10:34 PM Laurent Pinchart > wrote: > > > > Hi Tomasz, > > > > Thank you for the patch. > > Thanks for your comments! Please see my replies inline. >

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-20 Thread Tomasz Figa
On Thu, Oct 18, 2018 at 8:22 PM Laurent Pinchart wrote: > > Hi Tomasz, > > I've stripped out all the parts on which I have no specific comment or just > agree with your proposal. Please see below for a few additional remarks. > > On Thursday, 18 October 2018 13:03

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-18 Thread Tomasz Figa
Hi Laurent, On Wed, Oct 17, 2018 at 10:34 PM Laurent Pinchart wrote: > > Hi Tomasz, > > Thank you for the patch. Thanks for your comments! Please see my replies inline. > > On Tuesday, 24 July 2018 17:06:20 EEST Tomasz Figa wrote: > > Due to complexity of the video de

<    1   2   3   4   5   6   7   >