Re: next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c

2015-12-22 Thread Valdis . Kletnieks
On Tue, 22 Dec 2015 09:40:43 -0300, Javier Martinez Canillas said: > It was my forgetting to test with !CONFIG_MEDIA_CONTROLLER... > > Anyways, I've already posted a fix for this: > > https://lkml.org/lkml/2015/12/21/224 Thanks, that fixed it. When I posted, Google hadn't indexed that post yet (

next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c

2015-12-22 Thread Valdis Kletnieks
next-20151222 fails to build for me: CC drivers/media/usb/uvc/uvc_driver.o drivers/media/usb/uvc/uvc_driver.c: In function 'uvc_probe': drivers/media/usb/uvc/uvc_driver.c:1941:32: error: 'struct uvc_device' has no member named 'mdev' if (media_device_register(&dev->mdev) < 0)

[PATCH] ov519.c - allow setting i2c_detect_tries

2015-07-15 Thread Valdis Kletnieks
dinfo drivers/media/usb/gspca/gspca_ov519.ko | grep parm parm: i2c_detect_tries:Number of times to try to init I2C (default 10) (int) parm: frame_rate:Frame rate (5, 10, 15, 20 or 30 fps) (int) Reported-By: Demhlyr Signed-Off-By: Valdis Kletnieks --- a/drivers/media/usb/

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Valdis . Kletnieks
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > - if (ir == NULL) { > > > - dev_err(ir->l.dev, "close: no private_data attached to the file !\n"); > > > > Yes, the dev_err() call is an obvious thinko. > > > > However, I'm not sure whether removing it entirely is right either.

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drive

Re: [PATCH 4/4] usbvision: remove RGB format conversion

2011-04-27 Thread Valdis . Kletnieks
On Wed, 27 Apr 2011 22:41:32 +0200, Ondrej Zary said: > As V4L2 spec says that drivers shouldn't do any in-kernel image format > conversion, remove it. Does this classify as breaking the API, and thus require a deprecation period? Is it likely to break any userspace that wasn't planning on doing i

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-19 Thread Valdis . Kletnieks
On Mon, 18 Oct 2010 17:40:04 PDT, Greg KH said: > I do have access to this hardware, but its on an old single processor > laptop, so any work that it would take to help do this development, > really wouldn't be able to be tested to be valid at all. The i810 is a graphics chipset embedded on the m

mmotm 2010-10-13 - GSPCA SPCA561 webcam driver broken

2010-10-14 Thread Valdis . Kletnieks
On Wed, 13 Oct 2010 17:13:25 PDT, a...@linux-foundation.org said: > The mm-of-the-moment snapshot 2010-10-13-17-13 has been uploaded to > >http://userweb.kernel.org/~akpm/mmotm/ This broke my webcam. I bisected it down to this commit, and things work again after reverting the 2 code lines of

Re: mmotm 2010-07-19-16-37 uploaded

2010-07-20 Thread Valdis . Kletnieks
On Tue, 20 Jul 2010 13:50:27 PDT, Dmitry Torokhov said: > > And things go downhill from there... > > I guess you need these 2 from Jarod... Hmm. I seem to remember 2 similar patches from the last time I reported it. :) System boots fine after applying those two patches. I'll let somebody else

Re: mmotm 2010-07-19-16-37 uploaded

2010-07-20 Thread Valdis . Kletnieks
On Mon, 19 Jul 2010 16:38:09 PDT, a...@linux-foundation.org said: > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to > >http://userweb.kernel.org/~akpm/mmotm/ (Andrew - did we lose a bunch of -swedish-chef-fix-fix-fix.patch files? This is the second thing that I reported b

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Valdis . Kletnieks
On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said: > what I tried was this: > > if (!rc) > printk("test"\n") > > and everything looked good, > but as a soon as I changed > > rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE, > "attempting to

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Valdis . Kletnieks
On Mon, 14 Jun 2010 13:26:44 PDT, "Justin P. Mattock" said: > Im getting this warning when compiling: > CC drivers/char/tpm/tpm.o > drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt': > drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used > > The below patch gets rid o

Re: [PATCH] input: fix error at the default input_get_keycode call

2010-05-31 Thread Valdis . Kletnieks
On Thu, 20 May 2010 13:51:46 EDT, valdis.kletni...@vt.edu said: *ping*? Still broken in a linux-next pull I did about an hour ago. The patch fixed one oops, but it just died a little further down - I'm guessing it missed a case? > > input_default_getkeycode_from_index() returns the scancode at

Re: [PATCH] input: fix error at the default input_get_keycode call

2010-05-20 Thread Valdis . Kletnieks
On Thu, 20 May 2010 01:55:50 -0300, Mauro Carvalho Chehab said: > [ 76.376140] BUG: unable to handle kernel NULL pointer dereference at (null) > [ 76.376670] IP: [] input_default_getkeycode_from_index+0x40/0x60 > [ 76.376670] *pde = > [ 76.376670] Oops: 0002 [#1] SMP > [ 76.37667