[PATCH 1/1] s2255drv: update firmware load.

fixes intermittent soft reboot issue with firmware load increases wait time of reset, as required by HW Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/s2255

[PATCH] [media] s2255drv: fix payload size for JPG, MJPEG

Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index a56a05b..82014bb 100644 --- a/drivers/media/usb/s2255/s2255drv.c +++ b/drivers

Re: [PATCH] [media] s2255drv: fix spinlock issue

. On 2014-11-04 14:34, Dean Anderson wrote: qlock spinlock controls access to buf_list and sequence. qlock spinlock should not be locked during a copy to video buffers, an operation that may sleep. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 23 +++ 1

[PATCH] [media] s2255drv: fix spinlock issue

qlock spinlock controls access to buf_list and sequence. qlock spinlock should not be locked during a copy to video buffers, an operation that may sleep. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 23 +++ 1 file changed, 11 insertions(+), 12

[PATCH] s2255drv: urgent memory leak fix.

Critical bug fix. Fixes memory leak introduced by commit 47d8c881c304642a68d398b87d9e8846e643c81a. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255

Re: [PATCH] s2255drv: upgrade to videobuf2

14 17:01, Dean Anderson wrote: "./utils/v4l2-compliance/v4l2-compliance -s" Driver Info: Driver name : s2255 Card type : s2255 Bus info : usb-:00:1a.7-3.6 Driver version: 3.13.0 Capabilities : 0x8401 Video Capture Streaming

Re: [PATCH v2] s2255drv: upgrade to videobuf2

test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test read/write: OK test MMAP: OK test USERPTR: OK Total: 39, Succeeded: 39, Failed: 0, Warnings: 9 On 2014-02-12 14:25, Dean Anderson wrote: Upgrade to videobuf2 libraries. No errors reported with "v4l2-compliance -s".

[PATCH v2] s2255drv: upgrade to videobuf2

Upgrade to videobuf2 libraries. No errors reported with "v4l2-compliance -s". Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 512 +++- 1 file changed, 152 insertions(+), 360 deletions(-) diff --git a/drivers/media/usb/s2255/

Re: [PATCH] s2255drv: upgrade to videobuf2

RPTR: FAIL Total: 39, Succeeded: 36, Failed: 3, Warnings: 9 On 2014-02-11 17:07, Hans Verkuil wrote: Hi Dean, On 02/12/2014 12:05 AM, Dean Anderson wrote: The output of v4l2-compliance looks fine. The warnings can be ignored for this patch. Can you update to the latest v4l2-compliance that I just

[PATCH] s2255drv: upgrade to videobuf2

Upgrade to videobuf2 libraries. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 507 +++- 1 file changed, 148 insertions(+), 359 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index

Re: [PATCH] s2255drv: upgrade to videobuf2

REATE_BUFS not supported test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK Total: 36, Succeeded: 36, Failed: 0, Warnings: 9 On 2014-02-11 16:56, Dean Anderson wrote: Upgrade to videobuf2 libraries. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255dr

Re: [PATCH] s2255drv: port to videobuf2

On 2014-02-04 04:04, Hans Verkuil wrote: Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a

[PATCH] s2255drv: cleanup of s2255_fh

Removal of unnecessary parameters from s2255_fh. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 94 +--- 1 file changed, 44 insertions(+), 50 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255

[PATCH v2] s2255drv: fix for return code not checked

Start acquisition return code was not being checked. Return error if start acquisition fails. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b

[PATCH] s2255drv: dynamic memory allocation efficiency fix

Driver was allocating a kernel buffer each time it was sending a command. It is better to allocate this buffer once at startup. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 67 1 file changed, 37 insertions(+), 30 deletions

[PATCH] s2255drv: fix for return code not checked

Start acquisition return code was not being checked. Return error if start acquisition fails. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers

[PATCH] s2255drv: buffer setup fix

Buffer setup should check if minimum number of buffers is used. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c

[PATCH] s2255drv: remove redundant parameter

Removing duplicate fmt from buffer structure. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 1b267b1..517901b 100644

Re: [PATCH] s2255drv: file handle cleanup

2-04 16:36, Dean Anderson wrote: Removes most parameters from s2255_fh. These elements belong in s2255_ch. In the future, s2255_fh will be removed when videobuf2 is used. videobuf2 has convenient and safe functions for locking streaming resources. The removal of s2255_fh (and s2255_fh->resources)

[PATCH] s2255drv: file handle cleanup

ing videobuf_queue_is_busy. videobuf_queue_is busy may be unsafe as noted by the following comment in videobuf-core.c: "/* Locking: Only usage in bttv unsafe find way to remove */" Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 224 +-

[PATCH v2] s2255drv: refactoring s2255_channel to s2255_vc

Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 517 ++-- 1 file changed, 259 insertions(+), 258 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b

Re: [PATCH] s2255drv: refactoring s2255_channel to s2255_vc

There are some missing changes. It compiles, but please review v2 instead. On 2014-02-04 15:04, Dean Anderson wrote: Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 469

[PATCH] s2255drv: refactoring s2255_channel to s2255_vc

Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 469 ++-- 1 file changed, 235 insertions(+), 234 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b

[PATCH] s2255drv: removal of s2255_dmaqueue structure

Removal of unused and unnecessary s2255dma_queue structure. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255

Re: [PATCH] s2255drv: port to videobuf2

On 2014-02-04 04:04, Hans Verkuil wrote: Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a

[PATCH v2]: s2255drv: checkpatch fix: coding style fix

Fixes all style warnings from scripts/checkpatch -f Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 333 1 file changed, 151 insertions(+), 182 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255

[PATCH] S2255: Removal of unnecessary videobuf_queue_is_busy

Removes unnecessary query of buffer state. The code already checks if stream is active or not. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers

Re: [patch 2/2] [media] s2255drv: fix some endian bugs

Hi Dan, The original code has an issue on big endian hardware. The patch looks ok. Signed-off-by: Dean Anderson On 2/16/2012 10:44 PM, Dan Carpenter wrote: I don't have this hardware and I don't know the subsystem very well. So please review this patch carefully. The ori

Re: [patch 1/2] [media] s2255drv: cleanup vidioc_enum_fmt_cap()

Thanks Dan, I can sign off on this. The check isn't required. Signed-off-by: Dean Anderson On 2/16/2012 10:43 PM, Dan Carpenter wrote: "f" wasn't checked consistently, so static checkers complain. This function is always called with a valid "f" pointer, so I

Re: Fw: [PATCH] v4l/dvb: remove err macro from few usb devices

Alexey Klimov wrote: Hello, all Dean, so you think that we don't need s2255 name in the beginning of message and we doesn't need s2255_dev_err macros, right ? As i remember pr_err is just printk with KERN_ERR.. Not at all. We must have s2255 in the beginning of the message. I wasn't s