().
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
---
drivers/media/radio/si4713/radio-usb-si4713.c | 4 +-
drivers/media/radio/si4713/si4713.c | 104
+-
2 files changed, 55 insertions(+), 53 deletions(-)
diff
of unknown regulators,
which have apparently changed since 3.10. Hans has tested it and the
driver loads again.
Let me know when you are able to test it again.
After fixing the compilation issue, you can add my:
Tested-by: Eduardo Valentin edubez...@gmail.com
Acked-by: Eduardo Valentin edubez
Hello,
On Tue, Nov 5, 2013 at 10:18 AM, edubez...@gmail.com
edubez...@gmail.com wrote:
Dinesh
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
This is the USB driver for the Silicon Labs development board.
It contains the Si4713 FM transmitter chip.
I tried
On Thu, Nov 7, 2013 at 3:40 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 11/05/2013 03:18 PM, edubez...@gmail.com wrote:
Dinesh
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
This is the USB driver for the Silicon Labs development board.
It contains the Si4713 FM
On Tue, Nov 5, 2013 at 4:38 AM, Hans Verkuil hansv...@cisco.com wrote:
Hi,
On 11/04/13 15:07, edubez...@gmail.com wrote:
Hi,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
The supply list is needed by the platform driver, but not by the usb driver.
So
Dinesh
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
This is the USB driver for the Silicon Labs development board.
It contains the Si4713 FM transmitter chip.
I tried this driver again. The system attempts to probe the device but
it fails because the product revision
Hi,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
The supply list is needed by the platform driver, but not by the usb driver.
So this information belongs to the platform data and should not be hardcoded
in the subdevice driver.
Signed-off-by: Hans Verkuil
Hans,
On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 10/15/2013 07:37 PM, edubez...@gmail.com wrote:
Hello Dinesh,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
Hello Eduardo,
In this patch series, I have addressed the comments by you
by the
patch itself as it moves the macro definition, but still uses it in
the board file.
On Mon, Nov 4, 2013 at 3:13 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 11/04/2013 03:09 PM, edubez...@gmail.com wrote:
Hans,
On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil hverk...@xs4all.nl wrote
Hello Dinesh,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram dinesh@cern.ch wrote:
Hello Eduardo,
In this patch series, I have addressed the comments by you
concerning my last patch series.
In the resulting patches, I have corrected most of the
style issues and adding of comments.
. Besides reviewing I will be also
testing your patches.
All best,
Regards,
Dinesh
From: Hans Verkuil [hverk...@xs4all.nl]
Sent: 02 September 2013 09:11
To: edubez...@gmail.com
Cc: Dinesh Ram; Linux-Media; Dinesh Ram
Subject: Re: [PATCH 2/6] si4713
Hello Hans,
On Sun, Sep 1, 2013 at 6:57 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 08/31/2013 01:31 PM, edubez...@gmail.com wrote:
Dinesh, Hi
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
Checks have been introduced at several places in the code to test
Hi Hans,
On Sun, Sep 1, 2013 at 7:00 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 08/31/2013 01:32 PM, edubez...@gmail.com wrote:
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
Checks have been introduced at several places in the code to test if an
interrupt is set
Hi Dinesh,
On Sun, Sep 1, 2013 at 10:42 AM, dinesh ram dino_...@yahoo.co.in wrote:
Hi Eduardo,
Hi Hans,
From: Hans Verkuil hverk...@xs4all.nl
To: edubez...@gmail.com edubez...@gmail.com
Cc: Dinesh Ram din...@cisco.com; Linux-Media
linux-media
Hello Hans,
On Sun, Sep 1, 2013 at 7:04 AM, Hans Verkuil hverk...@xs4all.nl wrote:
On 08/31/2013 01:49 PM, edubez...@gmail.com wrote:
Hi Dinesh,
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
In the si4713_tx_tune_power() method, the args array element 'power' can
take
Hi Dinesh,
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
This is the USB driver for the Silicon Labs development board.
It contains the Si4713 FM transmitter chip.
Can you please fix the list of errors and warnings checkpatch.pl
outputs on your patch?
total: 73 errors,
Dinesh, Hi
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
Checks have been introduced at several places in the code to test if an
interrupt is set or not.
For devices which do not use the interrupt, to get a valid response, within a
specified timeout,
the device is
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
Checks have been introduced at several places in the code to test if an
interrupt is set or not.
For devices which do not use the interrupt, to get a valid response, within a
specified timeout,
the device is polled instead.
Hi Dinesh,
On Fri, Aug 30, 2013 at 7:28 AM, Dinesh Ram din...@cisco.com wrote:
In the si4713_tx_tune_power() method, the args array element 'power' can take
values between
SI4713_MIN_POWER and SI4713_MAX_POWER. power = 0 is also valid.
All the values (0 power SI4713_MIN_POWER) are illegal
Imre,
On Tue, May 14, 2013 at 10:48 AM, Imre Deak imre.d...@intel.com wrote:
Use usecs_to_jiffies_timeout instead of open-coding the same.
Signed-off-by: Imre Deak imre.d...@intel.com
Acked-by: Eduardo Valentin edubez...@gmail.com
---
drivers/media/radio/si4713-i2c.c |4 ++--
1 file
Arnd,
On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann a...@arndb.de wrote:
It is not possible to select SND_SOC_SI476X if we have not also
enabled SND_SOC.
warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet
direct dependencies (SOUND !M68K !UML SND SND_SOC)
Cc: Hans
Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
This patch series makes radio-si4713 compliant with v4l2-compliance.
Thanks for your patches.
Eduardo, thanks for testing the previous code. I hope this version resolves
all the issues we found. Can you test
Hans,
On Mon, Apr 8, 2013 at 8:03 AM, edubez...@gmail.com edubez...@gmail.com wrote:
Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
This patch series makes radio-si4713 compliant with v4l2-compliance.
Thanks for your patches.
Eduardo, thanks for testing
...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested-by: Eduardo Valentin edubez...@gmail.com
Output of v4l2-compliant is the same as the one send against patch 00/07
---
drivers/media/radio/radio-si4713.c | 32
1 file changed, 32 deletions
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Also set the v4l2_dev pointer in struct video_device as this was missing.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Set bus_info and fill in device_caps.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested-by: Eduardo Valentin edubez
to the control framework.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested-by: Eduardo Valentin edubez...@gmail.com
Output of v4l2-compliant is same as in patch 03
Driver is still in one piece after this big change. No lockups have been seen
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
- check for invalid modulators.
- clamp frequency to valid range.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested
Hi,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested-by: Eduardo Valentin edubez...@gmail.com
Output of v4l2-compliant
Hi Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo Valentin edubez...@gmail.com
Tested-by: Eduardo Valentin edubez...@gmail.com
Output of v4l2-compliant
Hey Hans,
On Mon, Apr 8, 2013 at 11:46 AM, edubez...@gmail.com
edubez...@gmail.com wrote:
Hi Hans,
On Mon, Apr 8, 2013 at 6:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Eduardo
Hello Hans,
On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil hverk...@xs4all.nl wrote:
snip
# on your branch on the other hand I get a NULL pointer:
I've fixed that (v4l2_dev was never initialized), and I've also rebased my
tree
to the latest code. Can you try again?
This time I get a
Hans,
On Fri, Mar 22, 2013 at 12:45 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Fri March 22 2013 17:26:57 edubez...@gmail.com wrote:
Hello Hans,
On Fri, Mar 22, 2013 at 10:04 AM, Hans Verkuil hverk...@xs4all.nl wrote:
snip
# on your branch on the other hand I get a NULL pointer
Hans,
snip
Are you still able to test the si4713 driver? Because I have patches
I see. In fact that is my next step on my todo list for si4713. I
still have an n900 that I can fetch from my drobe, so just a matter of
booting it with newer kernel.
outstanding that I would love for
Hi Hans,
My last email didn't reach the list, so re-sending.
On Wed, Mar 20, 2013 at 5:04 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Eduardo!
On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote:
Hello Mauro and Hans,
Here are a couple of minor changes for si4713 FM transmitter
35 matches
Mail list logo
