Ваша квота превысила лимит

2018-10-12 Thread FRANCISCO JAVIER GIL HERNANDO
-- Уважаемый пользователь, Ваш почтовый ящик превысил обычный 100 Мб хранения, вы не сможете получать или отправлять электронную почту, пока не увеличите квоту почтового ящика. Чтобы увеличить квоту почты, нажмите на ссылку ниже и заполните необходимые данные, чтобы увеличить квоту

[PATCH v2 1/2] media: ov2680: don't register the v4l2 subdevice before checking chip ID

2018-09-01 Thread Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Just move ov2680_check_id() before ov2680_v4l2_init() - Suggested by Sakari. drivers/media/i2c/ov2680.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov26

Re: [PATCH] media: ov2680: register the v4l2 subdev async at the end of probe

2018-09-01 Thread Javier Martinez Canillas
Hi Sakari, Thanks for the feedback. On 09/01/2018 01:46 PM, Sakari Ailus wrote: > Hi Javier, > > On Fri, Aug 31, 2018 at 05:19:06PM +0200, Javier Martinez Canillas wrote: >> The driver registers the subdev async in the middle of the probe function >> but this has to be

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

2018-08-01 Thread Javier Martinez Canillas
Hi Marco, On 08/01/2018 05:49 PM, Marco Felsch wrote: > Hi Javier, > > On 18-07-31 15:30, Marco Felsch wrote: >> Hi Javier, >> >> On 18-07-31 14:52, Javier Martinez Canillas wrote: >>> Hi Marco, >>> >>> On 07/31/2018 02:36 PM, Marco Felsch wr

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

2018-07-31 Thread Javier Martinez Canillas
y I said that the output port should be the first one in your enum tvp5150_ports and not the last one. > Regards, > Marco > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

2018-07-31 Thread Javier Martinez Canillas
Hi Mauro, On 07/31/2018 12:06 PM, Mauro Carvalho Chehab wrote: > Em Tue, 31 Jul 2018 10:52:56 +0200 > Javier Martinez Canillas escreveu: > >> Hello Mauro, >> >> On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote: >>> Em Thu, 28 Jun 2018 18:20

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

2018-07-31 Thread Javier Martinez Canillas
Hello Mauro, On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote: > Em Thu, 28 Jun 2018 18:20:50 +0200 > Marco Felsch escreveu: > >> From: Javier Martinez Canillas >> >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >>

Re: Software-only image processing for Intel "complex" cameras

2018-07-27 Thread Javier Martinez Canillas
https://www.kernel.org/doc/Documentation/devicetree/bindings/media/video-interfaces.txt [1]: https://www.kernel.org/doc/Documentation/devicetree/bindings/graph.txt [2]: https://www.kernel.org/doc/Documentation/acpi/dsd/graph.txt [3]: https://linuxtv.org/downloads/v4l-dvb-apis/kapi/v4l2-fwnode.html [4]: https://www.kernel.org/doc/Documentation/acpi/dsdt-override.txt [5]: https://www.kernel.org/doc/Documentation/acpi/initrd_table_override.txt Best regards, Javier

Re: Devices with a front and back webcam represented as a single UVC device

2018-07-24 Thread Javier Martinez Canillas
for my 2-in-1. > > Great, I'll add you to the list of potential testers for an ATOMISP solution > :-) > The ATOMISP driver was removed from staging by commit 51b8dc5163d ("media: staging: atomisp: Remove driver"). Do you mean that there's a plan to bring that driver back? Best regards, Javier

Re: [PATCH 00/21] TVP5150 fixes and new features

2018-06-28 Thread Javier Martinez Canillas
2]. > Thanks for working on this! I've felt guilty that I never re-worked my patch-set after the discussion from [2]. I'll try to review these patches next week. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-12 Thread Javier Martinez Canillas
subdev8 pad0: Sink pad1: Source [fmt:UYVY2X8/720x240 field:alternate crop.bounds:(0,0)/720x480 crop:(0,0)/720x480] -> "OMAP3 ISP CCDC":0 [ENABLED] Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-06 Thread Javier Martinez Canillas
egrate them in a particular camera stack, and should be as >> platform-agnostic as possible. >> >> In the case of the Android camera HAL, ideally it would be a glue that >> could be used with different camera vendors (probably with some kind of >> vendor-specific configuration

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-06-01 Thread Javier Martinez Canillas
Location yet to be defined, but it will either be together with >>>> OSS Japan or at Google. I'll confirm the address tomorrow. >>> >>> More details about the meeting: >>> >>> Date: June, 19 >>> Site: Google >>> Address: 〒106-6126 Tokyo, Minato, Roppongi, 6 Chome−10−1 Roppongi Hills >>> Mori Tower 44F >>> >>> Please confirm who will be attending the meeting. >> >> I plan to attend the meeting via Google Hangouts. > > Well, the afternoon part of the meeting at least :-) > I also plan to attend via Google Hangouts. At least the hours that are reasonable on my timezone. Best regards, Javier

Re: [DE] Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-04-23 Thread Javier Martin
Sorry for resurrecting this thread but I'm still quite interested on making this scenario work: > OK, I've performed some tests with several resolutions and gop sizes, here is the table with the results: > > Always playing 3 streams > > | Resolution | QP | GopSize | Kind of content |

Re: [DE] Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Hello Philipp, On 14/03/18 16:11, Philipp Zabel wrote: Hi Javier, On Wed, 2018-03-14 at 15:35 +0100, Javier Martin wrote: [...] The encoder is running on a different system with an older 4.1.0 kernel. Altough the firmware version in the code is 3.1.1 as well. Do you think I should try

Re: [CN] Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Hello, On 14/03/18 14:57, Philipp Zabel wrote: On Wed, 2018-03-14 at 13:05 +0100, Javier Martin wrote: Sorry everyone about my previous e-mail with all the HTML garbage. Here is the plain text answer instead. Hi Philipp, thanks for your answer. On 13/03/18 12:20, Philipp Zabel wrote

Re: [DE] Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-14 Thread Javier Martin
Sorry everyone about my previous e-mail with all the HTML garbage. Here is the plain text answer instead. Hi Philipp, thanks for your answer. On 13/03/18 12:20, Philipp Zabel wrote: > Hi Javier, > > On Mon, 2018-03-12 at 17:54 +0100, Javier Martin wrote: >> Hi, >> we hav

coda: i.MX6 decoding performance issues for multi-streaming

2018-03-12 Thread Javier Martin
y kind of Coda IP documentation it's quite hard to me to perform any additional debugging. Has anyone experienced these kind of performance issues too? I'm open to any suggestions and willing to perform extra tests to get to the bottom of this. Regards, Javier. [1] https://github.com/genesi/i

Re: [RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

2017-12-14 Thread Javier Martinez Canillas
Hello Mauro, On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Dec 2017 01:33:05 +0100 > Javier Martinez Canillas <javi...@redhat.com> escreveu: > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added

[PATCH] dtv-scan-tables: dvb-t/es-Zaragoza

2017-12-09 Thread Javier García
Hello, I have scanned the DVB-T channels of Zaragoza, Spain I wanted to send them to share and that may be useful for other users. Javier García --- El software de antivirus Avast ha analizado este correo electrónico en busca de virus. https://www.avast.com/antivirus

[RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

2017-12-05 Thread Javier Martinez Canillas
nly anymore. But all the code related to the DT parsing logic and input entities creation are removed. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboa

Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

2017-08-17 Thread Javier Martinez Canillas
Hello Philipp, On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > Hi, > > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote: >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added

Re: [PATCH 2/3] leds: as3645a: Add LED flash class driver

2017-08-16 Thread Javier Martinez Canillas
ken w.r.t reporting a proper MODALIAS for OF registered devices, it will report a MODALIAS=i2c:as3645a in this case. So if you build this as a module, autoload won't work. In theory this will be fixed soon, but for now you should add a i2c_device_id table and export it with MODULE_DEVICE_TABLE(i2c,...) if you care about module autoloading. Best regards, Javier

Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

2017-08-09 Thread Javier Martinez Canillas
On 08/09/2017 01:05 PM, Kieran Bingham wrote: > On 09/08/17 11:58, Javier Martinez Canillas wrote: >> Hi Kieran, >> >> On 08/09/2017 12:29 PM, Kieran Bingham wrote: >>> Hi Javier, >>> >>> Thankyou for the patch >> >> You are welcome

Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

2017-08-09 Thread Javier Martinez Canillas
Hi Kieran, On 08/09/2017 12:29 PM, Kieran Bingham wrote: > Hi Javier, > > Thankyou for the patch > You are welcome. > On 09/08/17 10:37, Javier Martinez Canillas wrote: >> The I2C core always reports a MODALIAS of the form i2c: even if the >> device was regist

[PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

2017-08-09 Thread Javier Martinez Canillas
/adv748x/adv748x.ko | grep alias alias: of:N*T*Cadi,adv7482C* alias: of:N*T*Cadi,adv7482 alias: of:N*T*Cadi,adv7481C* alias: of:N*T*Cadi,adv7481 alias: i2c:adv7482 alias: i2c:adv7481 Signed-off-by: Javier Martinez Canillas <javi...@redhat.

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-14 Thread Javier Martinez Canillas
On Thu, Jul 13, 2017 at 5:47 PM, Javier Martinez Canillas <jav...@dowhile0.org> wrote: > On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: [snip] >> >> Shouldn't these be set to the corresponding driver structs' id_table >&g

[PATCH] [media] vimc: set id_table for platform drivers

2017-07-14 Thread Javier Martinez Canillas
vimc_sen_driver_ids[] = { ^~~ Reported-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Suggested-by: Sakari Ailus <sakari.ai...@iki.fi> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com> --- drivers/media/

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Javier Martinez Canillas
ecause the platform subsystem fallbacks to the driver's name if an .id_table isn't defined: http://elixir.free-electrons.com/linux/latest/source/drivers/base/platform.c#L964 Best regards, Javier

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-04-06 Thread Javier Martinez Canillas
Hello Gustavo, On 04/06/2017 10:08 AM, Gustavo Padovan wrote: > Hi Javier, > > 2017-04-05 Javier Martinez Canillas <jav...@osg.samsung.com>: > >> Hello Gustavo, >> >> On 04/05/2017 11:09 AM, Gustavo Padovan wrote: >>> 2017-04-03 Javier Martinez Cani

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-04-05 Thread Javier Martinez Canillas
Hello Gustavo, On 04/05/2017 11:09 AM, Gustavo Padovan wrote: > 2017-04-03 Javier Martinez Canillas <jav...@osg.samsung.com>: > >> Hello Mauro and Gustavo, >> >> On 04/03/2017 07:16 AM, Mauro Carvalho Chehab wrote: >>> Hi Gustavo, >>> >>&g

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Javier Martinez Canillas
2016/4/12/983 [1]: https://hastebin.com/kadagidino.diff [2]: https://patchwork.kernel.org/patch/9472623/ Best regards, Javier

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-04-03 Thread Javier Martinez Canillas
ke to do some tests with it on devices with mem2mem drivers. > My plan is to use an Exynos board for such thing, but I guess that > the DRM driver for it currently doesn't. I'm seeing internally if someone > could be sure that Exynos driver upstream will become ready for such > tests. >

Re: [RFC 03/10] [media] vb2: add in-fence support to QBUF

2017-04-03 Thread Javier Martinez Canillas
!= VB2_MEMORY_DMABUF) > + return -EINVAL; > + I wonder if is correct to check this. Only one side of the pipeline uses V4L2_MEMORY_DMABUF while the other uses V4L2_MEMORY_MMAP + VIDIOC_EXPBUF. So that means that fences can only be used in one direction? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH v2 00/15] Exynos MFC v6+ - remove the need for the reserved memory

2017-03-15 Thread Javier Martinez Canillas
be able to help you since as mentioned I didn't test that. > Cheers, > Marian > Best regards, Javier

Re: [PATCH v2 00/15] Exynos MFC v6+ - remove the need for the reserved memory

2017-03-15 Thread Javier Martinez Canillas
age of "media: s5p-mfc: Add support for probe-time preallocated block based allocator". [0]: https://patchwork.kernel.org/patch/9596737/ > Thanks, > Marian > Best regards, Javier

Re: [PATCH] media: mfc: Fix race between interrupt routine and device functions

2017-03-06 Thread Javier Martinez Canillas
9a7bb83f0d8 ]--- > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver") > CC: sta...@vger.kernel.org # v4.5+ > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH] [media] exynos4-is: Add missing 'of_node_put'

2017-02-24 Thread Javier Martinez Canillas
gt; > Thanks for the patch, but Krzysztof sent the exact same patch before [0]. There was feedback from Sylwester at the time that you can also look at [0]. Could you please take that into account and post a patch according to what he suggested? [0]: http://lists.infradead.org/pipermail

Re: [PATCH 2/2] media: s5p-mfc: fix MMAP of mfc buffer during reqbufs

2017-02-24 Thread Javier Martinez Canillas
hat case both the left and right device is treated as mfc0 only. > I see, so likely you were facing the issue described in patch 1/2 after this patch since the driver doesn't set alloc_devs when IOMMU is disabled, right? In any case, I guess these patches have been superseded by Marek's se

Re: [PATCH 1/2] media: s5p-mfc: convert drivers to use the new vb2_queue dev field

2017-02-24 Thread Javier Martinez Canillas
; > q->ops = get_dec_queue_ops(); > Please correct me if I'm wrong, but AFAIU this shouldn't be needed in the s5p-mfc driver since the videobuf2 core either uses the vb2_queue .dev field or the vb2_queue .alloc_devs. And the latter is set in the s5p_mfc_queue_setup() function, so the .dev field shouldn't be used. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/soc_camera/ov5642.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH 2/3] [media] tc358743: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/tc358743.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/med

[PATCH 3/3] [media] si4713: Add OF device ID table

2017-02-22 Thread Javier Martinez Canillas
change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/radio/si4713/si4713.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers

[PATCH] [media] et8ek8: Export OF device ID as module aliases

2017-02-20 Thread Javier Martinez Canillas
-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index bec4a563a09c..f39f5179dd95 100644 --- a/drivers/media/i2c/

Re: [PATCH v2 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

2017-02-20 Thread Javier Martinez Canillas
irmware() call > from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory(). > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

2017-02-20 Thread Javier Martinez Canillas
Hello Marek, On 02/20/2017 10:23 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-02-17 22:13, Javier Martinez Canillas wrote: >> On 02/14/2017 04:52 AM, Marek Szyprowski wrote: >>> It turned out that all versions of MFC v6+ hardware doesn't have a strict >>

Re: [PATCH 00/15] Exynos MFC v6+ - remove the need for the reserved memory

2017-02-17 Thread Javier Martinez Canillas
2dec capture-io-mode=dmabuf ! v4l2video0convert \ output-io-mode=dmabuf-import capture-io-mode=dmabuf ! kmssink Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 15/15] ARM: dts: exynos: Remove MFC reserved buffers

2017-02-17 Thread Javier Martinez Canillas
Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 14/15] media: s5p-mfc: Use preallocated block allocator always for MFC v6+

2017-02-17 Thread Javier Martinez Canillas
v6+ devices in device tree. Now the driver is fully > functional without them. > Great! > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- The patch looks good to me though and it works on my tests, I've just one comment below. Reviewed-by: Javier Martinez Canil

Re: [PATCH 13/15] media: s5p-mfc: Remove special configuration of IOMMU domain

2017-02-17 Thread Javier Martinez Canillas
gt; specific DMA-mapping and IOMMU glue code functions. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, --

Re: [PATCH 12/15] media: s5p-mfc: Add support for probe-time preallocated block based allocator

2017-02-17 Thread Javier Martinez Canillas
er to force larger (or smaller) buffer (for example by adding > "s5p_mfc.mem=16M" to kernel command line). > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Mart

Re: [PATCH 11/15] media: s5p-mfc: Split variant DMA memory configuration into separate functions

2017-02-17 Thread Javier Martinez Canillas
ng > @@ -1188,26 +1160,74 @@ static int s5p_mfc_configure_dma_memory(struct > s5p_mfc_dev *mfc_dev) > DMA_BIT_MASK(32)); > vb2_dma_contig_set_max_seg_size(mfc_dev->mem_dev[BANK2_CTX], > DMA_BIT_MASK(32

Re: [PATCH 10/15] media: s5p-mfc: Reduce firmware buffer size for MFC v6+ variants

2017-02-17 Thread Javier Martinez Canillas
arek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 09/15] media: s5p-mfc: Allocate firmware with internal private buffer alloc function

2017-02-17 Thread Javier Martinez Canillas
> patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 08/15] media: s5p-mfc: Move firmware allocation to DMA configure function

2017-02-17 Thread Javier Martinez Canillas
? Also, ret is not declared so this patch will cause a compile error, breaking git bisect-ability. > + return ret; > + > + mfc_dev->dma_base[BANK1_CTX] = mfc_dev->fw_buf.dma; Same comment than before, probably you wanted to use fw_buf->dma here? The rest of the patch looks good to me. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 07/15] media: s5p-mfc: Put firmware to private buffer structure

2017-02-17 Thread Javier Martinez Canillas
Hello Marek, On 02/14/2017 04:52 AM, Marek Szyprowski wrote: > Use s5p_mfc_priv_buf structure for keeping the firmware image. This will > help handling of firmware buffer allocation in the next patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > ---

Re: [PATCH 06/15] media: s5p-mfc: Move setting DMA max segmetn size to DMA configure function

2017-02-17 Thread Javier Martinez Canillas
m> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 05/15] media: s5p-mfc: Simplify alloc/release private buffer functions

2017-02-17 Thread Javier Martinez Canillas
d-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 01/15] media: s5p-mfc: Remove unused structures and dead code

2017-02-17 Thread Javier Martinez Canillas
Hello Marek, On 02/14/2017 04:51 AM, Marek Szyprowski wrote: > Remove unused structures, definitions and functions that are no longer > called from the driver code. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas &l

Re: [PATCH 02/15] media: s5p-mfc: Use generic of_device_get_match_data helper

2017-02-17 Thread Javier Martinez Canillas
Hello Marek, On 02/14/2017 04:51 AM, Marek Szyprowski wrote: > Replace custom code with generic helper to retrieve driver data. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by:

Re: [PATCH 04/15] media: s5p-mfc: Replace bank1/bank2 entries with an array

2017-02-17 Thread Javier Martinez Canillas
fy > code in the next patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America

Re: [PATCH 03/15] media: s5p-mfc: Replace mem_dev_* entries with an array

2017-02-17 Thread Javier Martinez Canillas
ll > help to simplify code in the next patches. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Jav

Re: [PATCH] media: s5p-mfc: Fix initialization of internal structures

2017-02-14 Thread Javier Martinez Canillas
> driver will access device or context queue in error handling path, which > might not be initialized yet, what causes kernel panic. Fix this by moving > initialization of all static members as early as possible. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com&

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

2017-02-13 Thread Javier Martinez Canillas
Hello Sylwester, On 02/13/2017 11:34 AM, Sylwester Nawrocki wrote: > Hi Javier, > > On 02/13/2017 01:53 PM, Javier Martinez Canillas wrote: >> Any comments on this series? > > The patches look good to me, I will Ack the patches in case > Mauro wants to apply them di

Re: [PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

2017-02-13 Thread Javier Martinez Canillas
Hello, On Wed, Feb 1, 2017 at 5:05 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Hello, > > Commit 652bb68018a5 ("[media] exynos-gsc: do proper bytesperline and > sizeimage calculation") fixed corrupted frames for most exynos-gsc > formats, but e

Re: [PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

2017-02-02 Thread Javier Martinez Canillas
Hello Shuah, On 02/01/2017 11:25 PM, Shuah Khan wrote: > On 01/24/2017 02:42 PM, Javier Martinez Canillas wrote: >> There isn't an ioctl to enum the supported field orders, so a user-space >> application can call VIDIOC_TRY_FMT using different field orders to know >>

[PATCH 2/2] [media] exynos-gsc: Add support for NV{16,21,61}M pixel formats

2017-02-01 Thread Javier Martinez Canillas
From: Thibault Saunier <thibault.saun...@osg.samsung.com> Those are useful formats that should be handled. Signed-off-by: Thibault Saunier <thibault.saun...@osg.samsung.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-g

[PATCH 0/2] [media] exynos-gsc: Fix support for NV21 and NV61 formats

2017-02-01 Thread Javier Martinez Canillas
mat didn't work when used as output (only as input). This patch series fixes (1). Best regards, Javier Thibault Saunier (2): [media] exynos-gsc: Do not swap cb/cr for semi planar formats [media] exynos-gsc: Add support for NV{16,21,61}M pixel formats drivers/media/platform/exynos-gsc/gsc-c

[PATCH 1/2] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

2017-02-01 Thread Javier Martinez Canillas
las.dufre...@collabora.com> Signed-off-by: Thibault Saunier <thibault.saun...@osg.samsung.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platfo

[PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

2017-01-24 Thread Javier Martinez Canillas
] Not supported field order(4) Instead of printing this as an error, just keep it as debug information. Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Javier Martinez Canillas
sw_dt_ids) here or otherwise module autoloading won't work. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
CLK_IS_CRITICAL. So please also ignore my clk patch. Sorry for the noise and the mess with these patches. Thought I also tested on linux-next to see if the issue was solved there, but it seems I didn't. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To un

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello, On 01/20/2017 07:06 AM, Javier Martinez Canillas wrote: > Hello Marek, > > On 01/20/2017 05:37 AM, Marek Szyprowski wrote: > > [snip] >> >> Please send this patch instead of adding more clocks to the power domains. >> This way we will avoid adding more

Re: [PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM

2017-01-20 Thread Javier Martinez Canillas
Hello, On 01/19/2017 07:36 PM, Javier Martinez Canillas wrote: > Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when > CONFIG_PM is unset") removed the implicit dependency that the driver > had with CONFIG_PM, since it relied on the config option to be ena

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
t want to mark more clocks as CLK_IGNORE_UNUSED or CLK_IS_CRITICAL but I agree this can be done as a temporary workaround until a proper runtime PM based solution gets merged. > Best regards Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscrib

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-20 Thread Javier Martinez Canillas
Hello Marek, On 01/20/2017 05:08 AM, Marek Szyprowski wrote: > Hi Javier, > [snip] >> Ok, I misunderstood the relationship between runtime PM and the power domains >> then. I thought the power domains were only powered on when the runtime PM >> framework resumed a

[PATCH v2 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

2017-01-19 Thread Javier Martinez Canillas
gement at ->remove()") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> --- Changes in v2: - Added Marek Szyprowski's Acked-by tag. drivers/media/platform/exynos-gsc/gsc-core.c | 1 + 1 file changed, 1 in

[PATCH v2 2/2] [media] exynos-gsc: Only reset the GSC HW on probe() if !CONFIG_PM

2017-01-19 Thread Javier Martinez Canillas
he runtime resume callback had to be executed on the probe function. But there's no need to do this if CONFIG_PM is enabled, since in this case the runtime PM resume callback will be called by VIDIOC_STREAMON ioctl, so the resume handler will call the GSC HW reset function. Signed-off-by: Javie

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, On 01/19/2017 11:56 AM, Javier Martinez Canillas wrote: > On 01/19/2017 11:17 AM, Marek Szyprowski wrote: [snip] > > Also when removing the exynos_gsc driver, I get the same error: > > # rmmod s5p_mfc > [ 106.405972] s5p-mfc 1100.codec: Removing 11

Re: [PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, Thanks a lot for your feedback. On 01/19/2017 11:17 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit 15f90ab57acc ("[media] exynos-gsc: Make driver functional when >> CONFIG_PM is unset")

Re: [PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

2017-01-19 Thread Javier Martinez Canillas
Hello Marek, On 01/19/2017 11:12 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-18 01:30, Javier Martinez Canillas wrote: >> Commit a006c04e6218 ("[media] exynos-gsc: Fixup clock management at >> ->remove()") changed the driver's

[PATCH 2/2] [media] exynos-gsc: Fix imprecise external abort due disabled power domain

2017-01-17 Thread Javier Martinez Canillas
the reset in probe unneeded. Fixes: 15f90ab57acc ("[media] exynos-gsc: Make driver functional when CONFIG_PM is unset") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- I-ve only tested with CONFIG_PM enabled since my Exynos5422 Odroid XU4 board fails to b

[PATCH 1/2] [media] exynos-gsc: Fix unbalanced pm_runtime_enable() error

2017-01-17 Thread Javier Martinez Canillas
gement at ->remove()") Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/media/platform/exynos-gsc/gsc-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index c

Re: [PATCH RFC] omap3isp: prevent releasing MC too early

2016-12-15 Thread Javier Martinez Canillas
are gone. I understand that's what Sakari's RFC patches do. I'll try to make some time tomorrow to test and review his patches. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media"

[RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

2016-12-13 Thread Javier Martinez Canillas
nly anymore. But all the code related to the DT parsing logic and input entities creation are removed. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- Hello Laurent, I've tested this patch on

Re: [PATCH v2 0/6] Fix tvp5150 regression with em28xx

2016-12-12 Thread Javier Martinez Canillas
rking for both composite input AIP1A (after changing the hardcoded selected input) and AIP1B. The patches also look good to me, so please feel free to add my Reviewed-by and Tested-by tags on these. I wasn't able to test S-Video since my S-Video source broke (an old DVD player) but this never wor

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

2016-12-07 Thread Javier Martinez Canillas
pdata-quirks anyways. So I agree with you that the input / output signals lookup from DT could be done as a follow-up. [0]: https://lkml.org/lkml/2016/4/12/983 [1]: https://lkml.org/lkml/2016/4/27/678 [2]: https://lkml.org/lkml/2016/11/11/346 Best regards, Javier -- To unsubscribe from this li

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

2016-12-05 Thread Javier Martinez Canillas
t; different. We are not interested in matching the pointer, what we > want to match is that the path is the one we are expecting. Change to > use of_node_cmp() so that we continue matching after the overlay has > been removed and reapplied. > > Cc: Mauro Carvalho Chehab &l

Re: [GIT PULL] Samsung fixes for 4.8

2016-11-28 Thread Javier Martinez Canillas
any of the patches in the media/v4.9-2 tag to be merged in v4.9-rc7. >> Oops, sorry, I didn't check it properly. Would be nice to see that >> patch also in linux-next. > > I'll likely add all patches at linux-next today, after handling more > patches. > > Thanks, >

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

2016-11-23 Thread Javier Martinez Canillas
port { cam_ep: endpoint { ... }; }; }; } } > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Javier Martinez Canillas <jav...@osg.samsu

Re: [RFC PATCH v2 1/2] [media] tvp5150: Add input connectors DT bindings

2016-11-11 Thread Javier Martinez Canillas
[adding Kevin as cc since he was interested in this feature as well] Hello Hans, On 11/11/2016 01:11 PM, Hans Verkuil wrote: > This old mail came up in a discussion today so let me comment on this: > Thanks a lot for the feedback. > On 04/27/2016 09:12 PM, Javier Martinez Canil

Re: [RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

2016-11-11 Thread Javier Martinez Canillas
On Fri, Nov 11, 2016 at 12:50 PM, Javier Martinez Canillas <jav...@dowhile0.org> wrote: [snip] > So if you can comment on this and see if the DT bindings fits your, > would be very useful. > Sorry, I wanted to write "if the DT bindings fits your needs, it would be very us

Re: [RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

2016-11-11 Thread Javier Martinez Canillas
w.mail-archive.com/linux-media@vger.kernel.org/msg96393.html [1]: http://www.spinics.net/lists/linux-media/msg99421.html [2]: http://www.spinics.net/lists/linux-media/msg99987.html Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

2016-11-11 Thread Javier Martinez Canillas
com ./drivers/pinctrl/qcom ./drivers/soc/qcom ./drivers/clk/qcom $ find -name *qualcomm ./drivers/net/ethernet/qualcomm > Regards, > > Hans > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message

Re: [PATCH 1/2] exynos-gsc: Enable driver on ARCH_EXYNOS

2016-11-09 Thread Javier Martinez Canillas
ds on HAS_DMA > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung

Re: [PATCH 2/2] exynos-gsc: Add support for Exynos5433 specific version

2016-11-09 Thread Javier Martinez Canillas
(Exynos 5433) I would also add 5800 to the list. Besides these minor comments, the patch looks good to me: Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> And I've also tested in an Exynos5800 Peach Pi Chromebook: Tested-by: Javier Martinez Canillas <jav...@osg.samsu

Re: [PATCH 00/12] media: Exynos GScaller driver fixes

2016-11-09 Thread Javier Martinez Canillas
ext branch: git://linuxtv.org/snawrocki/samsung.git for-v4.10/media/next So feel free to add for the whole series: Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this li

Re: [Patch 20/35] media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint

2016-10-24 Thread Javier Martinez Canillas
Hello Benoit, On Wed, Sep 28, 2016 at 5:22 PM, Benoit Parrot <bpar...@ti.com> wrote: > ti_vpe module currently does not get loaded automatically. > Added MODULE_DEVICE_TABLE hint to the driver to assist. > > Signed-off-by: Benoit Parrot <bpar...@ti.com> > --- R

[PATCH 4/5] [media] s5p-cec: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias alias: of:N*T*Csamsung,s5p-cecC* alias: of:N*T*Csamsung,s5p-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- d

[PATCH 5/5] [media] st-cec: Fix module autoload

2016-10-17 Thread Javier Martinez Canillas
drivers/staging/media//st-cec/stih-cec.ko | grep alias $ After this patch: $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias alias: of:N*T*Cst,stih-cecC* alias: of:N*T*Cst,stih-cec Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> --- drivers/s

  1   2   3   4   5   6   7   8   9   >