Thanks!
You could remove
intstatus &= ~MASK_HDMI_INT;
in line 1289 as well.
Regards,
Mats Randgaard
On 15/06/2017, 18:49, "Gustavo A. R. Silva" wrote:
Remove useless variable assignment in function tc358743_isr().
The value stored in variable _intstatus_ at line 1299 is
overw
CC: Philipp Zabel who added device tree support to this driver
Regards,
Mats Randgaard
On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote:
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2
From: Mats Randgaard
The number of CSI lanes that should be used is set to the CSI_CONTROL
register by indirectly writing to the CSI_CONFW register. When the
number of lanes is read back from the CSI_CONTROL register the value
is usually correct, but we have seen that it suddenly is 1 for a short
From: Mats Randgaard
Originally Toshiba told us that the only way to disable HDCP was to
set the receiver in repeater mode, that would make the authentication
fail because of missing software support. It has worked fine with all
the sources we and our customers has used, until it was reported
pro
From: Mats Randgaard
The control for +5V Power detection must also be updated when the EDID is
not present.
Signed-off-by: Mats Randgaard
---
drivers/media/i2c/tc358743.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 25796
From: Mats Randgaard
Signed-off-by: Mats Randgaard
---
drivers/media/i2c/tc358743.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index cc38896..e9129d1 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/dri
From: Mats Randgaard
i2c_wr() is called from ops and the interrupt service routine, while
state->wr_data is shared and unprotected, and could be overwritten.
This shared buffer is therefore replaced with a local array with fixed
size. The array has the size of one EDID block (128 bytes) + 2 byte
From: Mats Randgaard
hsync and hbackporch must also be compared
Signed-off-by: Mats Randgaard
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c
b/drivers/media/v4l2-core/v4l2-dv-timings.c
index 6a83d61
On 08/11/2015 05:18 PM, Mauro Carvalho Chehab wrote:
drivers/media/i2c/tc358743.c:148:19: warning: Variable length array is used.
As the maximum size is 1026, we can't use dynamic var, as it
would otherwise spend 1056 bytes of the stack at i2c_wr() function.
So, allocate a buffer with the allow
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC support
- HDCP repeater support
- IR support
Signed-off-by: Mats Randgaard
diff --git a/MAINTAINERS b/MAINTAINERS
index 8133cef..fb98b8d 100644
--- a/MAINTAINE
From: Mats Randgaard
Improvements based on feedback from Hans Verkuil:
- Use functions in linux/hdmi.h to print AVI info frames
- Replace private format change event with V4L2_EVENT_SOURCE_CHANGE
- Rewrite set_fmt/get_fmt
- Remove V4L2_SUBDEV_FL_HAS_DEVNODE
Other improvements since the previous
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC support
- HDCP repeater support
- IR support
Signed-off-by: Mats Randgaard
---
MAINTAINERS|6 +
drivers/media/i2c/Kconfig
On 03/30/2015 01:10 PM, Philipp Zabel wrote:
> set_pll not only skips PLL changes but also doesn't enable it in
> the first place if the rate is the same as the default values.
>
> Signed-off-by: Philipp Zabel ---
> drivers/media/i2c/tc358743.c | 5 +++-- 1 file changed, 3
> insertions(+), 2 delet
Hi Philipp,
Thank you for reviewing, testing and committing new patches to the
driver for TC358743!
Fixed in latest version of the driver:
* [media] tc358743: split set_csi into set_csi and start_csi
* [media] tc358743: also set TCLK_TRAILCNT and TCLK_POSTCNT
* [media] tc358743: don't re
On 03/30/2015 01:10 PM, Philipp Zabel wrote:
Instead of only using the visible width and height, also add the
horizontal and vertical blanking to calculate the bit rate.
I am not a CSI expert and when I look at the spreadsheet from Toshiba I
understand that the calculation of the CSI parameter
On 03/30/2015 01:10 PM, Philipp Zabel wrote:
When resetting the CPU instead of power cycling, IntMask is still set
from last boot. Instead of depending on it to be set to its reset
defaults, check the ChipID register and rewrite IntMask if needed.
Signed-off-by: Philipp Zabel
---
drivers/media
On 03/30/2015 01:10 PM, Philipp Zabel wrote:
Add support for probing the TC358743 subdevice from device tree.
The reference clock must be supplied using the common clock bindings.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 133 +--
On 03/30/2015 01:10 PM, Philipp Zabel wrote:
Add support for registering the sensor subdevice using the v4l2-async API.
Signed-off-by: Philipp Zabel
---
drivers/media/i2c/tc358743.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC support
- HDCP repeater support
- IR support
Signed-off-by: Mats Randgaard
---
MAINTAINERS|6 +
drivers/media/i2c/Kconfig
From: Mats Randgaard
Hi,
I have finally finished the second RFC for this driver.
Changes since RFC01:
- Improved code based on feedback from Hans and Philipp. For the CSI
parameters have I only written a set of values that can serve as a
starting point, since calculation of the parameters in
Hi Philipp,
Hans forwarded this patch series to me now, since I haven't received if
for some reason. I will prioritize upstreaming of the driver the next
couple of days and create a new RFC. I will also go through your patches
and give you feedback!
Regards,
Mats
On 03/30/2015 01:10 PM, Phi
Thank you again for testing this driver!
I am sorry I haven't had time to prepare a second RFC for this driver,
but I will try to do that as soon as possible.
On 02/17/2015 09:50 AM, Philipp Zabel wrote:
Hi Mats,
Am Montag, den 15.12.2014, 19:21 +0100 schrieb matra...@cisco.com:
[...]
+stati
On 01/13/2015 01:01 PM, Lars-Peter Clausen wrote:
Add myself as the maintainer for the adv7180 video subdev driver.
>
> Signed-off-by: Lars-Peter Clausen --- MAINTAINERS |
> 7 +++ 1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS index 4318f34..22bb77e 100644
> ---
Thanks for testing the driver!
On 01/08/2015 06:12 PM, Philipp Zabel wrote:
Hi Mats,
Am Montag, den 15.12.2014, 19:21 +0100 schrieb matra...@cisco.com:
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC suppo
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC support
- HDCP repeater support
- IR support
Signed-off-by: Mats Randgaard
---
MAINTAINERS|6 +
drivers/media/i2c/Kconfig
From: Mats Randgaard
v4l2-ctl-test-patterns.cpp is removed, but still listed in Android.mk.
---
utils/v4l2-ctl/Android.mk |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/utils/v4l2-ctl/Android.mk b/utils/v4l2-ctl/Android.mk
index bbd151a..2f0e5b4 100644
--- a/utils/v
Thanks for responding so quickly, Sakari!
On 12/02/2014 01:45 PM, Sakari Ailus wrote:
Hi Mats,
On Tue, Dec 02, 2014 at 12:49:07PM +0100, Mats Randgaard (matrandg) wrote:
Hi,
I am writing a driver for Toshiba TC358743 HDMI to CSI-2 bridge. The
chip has four CSI lanes. Toshiba recommends to
Hi,
I am writing a driver for Toshiba TC358743 HDMI to CSI-2 bridge. The
chip has four CSI lanes. Toshiba recommends to configure the CSI output
speed for the highest resolution the CSI interface can handle and reduce
the number of CSI lanes in use if the received video has lower
resolution. T
From: Mats Randgaard
VIDIOC_S_EDID can return error and valid result
Documentation/DocBook/media/v4l/vidioc-g-edid.xml:
"If there are more EDID blocks than the hardware can handle then
the EDID is not written, but instead the error code E2BIG is set
and blocks is set to the maximum that the hard
29 matches
Mail list logo
