Thanks!
You could remove
intstatus &= ~MASK_HDMI_INT;
in line 1289 as well.
Regards,
Mats Randgaard
On 15/06/2017, 18:49, "Gustavo A. R. Silva" wrote:
Remove useless variable assignment in function tc358743_isr().
The value stored in variable _intstatus_ a
CC: Philipp Zabel who added device tree support to this driver
Regards,
Mats Randgaard
On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote:
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption t
struct i2c_msg msg;
- u8 data[2 + n];
+
+ if ((2 + n) > sizeof(state->wr_data))
+ v4l2_warn(sd, "i2c wr reg=%04x: len=%d is too big!\n",
+ reg, 2 + n);
msg.addr = client->addr;
msg.buf = data;
Acked-by: Mats R
fbd; +
> if ((pllctl0 != pllctl0_new) || ((pllctl1 & MASK_PLL_EN) == 0)) { +
> u32 hsck = (pdata->refclk_hz * pdata->pll_fbd) / pdata->pll_prd;
Yes, that is a bug that should be fixed!
The calculation of hsck is fixed in the latest version of the
driver.
Regards,
Mats Rand
x27;t return E2BIG from G_EDID
The code seems fine to me, but I am not able to test it:
* [media] tc358743: add direct interrupt handling
* [media] tc358743: allow event subscription
The rest of the patches are commented inline.
Regards,
Mats Randgaard
On 03/30/2015 01:10 PM, Philipp Zabel
->vfrontporch + bt->vsync + bt->vbackporch;
By the way, V4L2_DV_BT_FRAME_WIDTH(bt) and V4L2_DV_BT_FRAME_HEIGHT(bt)
can be used to calculate total frame width and height.
Regards,
Mats Randgaard
u32 bits_pr_pixel =
(state->mbus_fmt_code == MEDIA_BUS_FMT_UY
INTMASK));
+ i2c_wr16(sd, INTMASK, 0x0400);
+ }
tc358743_clear_interrupt_status(sd);
Are there other registers that are not reset? If so, I think the driver
should reset them all during initialization.
Regards,
Mats Randgaard
--
To unsubscribe from this list: send the line &quo
ion of the driver.
The rest of the code seems to be a hack for your hardware.
Regards,
Mats Randgaard
.def = 0,
.flags = V4L2_CTRL_FLAG_READ_ONLY,
};
/* --- PROBE / REMOVE --- */
+#if CONFIG_OF
+static void tc358743_gpio_reset(struct tc358743_st
can not test it since the
kernel we use is too old to support async subdevs.
Regards,
Mats Randgaard
+ err = v4l2_async_register_subdev(sd);
+ if (err < 0)
+ goto err_hdl;
+
INIT_DELAYED_WORK(&state->delayed_work_enable_hotplug,
10 PM, Philipp Zabel wrote:
Hi Mats,
did you have time to work on the TC358743 driver some more in the meanwhile?
These are the changes I have made locally to v1 to get it to work on i.MX6.
regards
Philipp
Mats Randgaard (1):
[media] Driver for Toshiba TC358743 CSI-2 to HDMI bridge
Philipp Zabe
Toshiba we have now implemented start and stop of the CSI
interface without pulling CTXRST. You can see our solution in the next
RFC, and I would appreciate if you could test if that works fine for you
as well!
Regards,
Mats Randgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
om/community/linux-device-drivers
I think the web address should be http://ez.analog.com/community/video
It is written much more about ADV7180 there, and people asking questions
about video devices has been directed to the Video forum in the past.
Regards,
Mats Randgaard
> +S:Suppo
Thanks for testing the driver!
On 01/08/2015 06:12 PM, Philipp Zabel wrote:
Hi Mats,
Am Montag, den 15.12.2014, 19:21 +0100 schrieb matra...@cisco.com:
From: Mats Randgaard
The driver is tested on our hardware and all the implemented features
works as expected.
Missing features:
- CEC
Thanks for responding so quickly, Sakari!
On 12/02/2014 01:45 PM, Sakari Ailus wrote:
Hi Mats,
On Tue, Dec 02, 2014 at 12:49:07PM +0100, Mats Randgaard (matrandg) wrote:
Hi,
I am writing a driver for Toshiba TC358743 HDMI to CSI-2 bridge. The
chip has four CSI lanes. Toshiba recommends to
E since the device supports four lanes,
and set V4L2_MBUS_CSI2_CHANNEL_X according to the number of lanes in use?
Thanks,
Mats Randgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gital video? Anyone who knows?
Regards,
Mats Randgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Mats Randgaard
The following functions are added to the drivers:
- vpif_g_chip_ident
- vpif_dbg_g_register
- vpif_dbg_s_register
- vpif_log_status
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci
From: Mats Randgaard
Added functions to set and get custom DV timings.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci/vpif_capture.c | 123 ++
drivers/media/video/davinci/vpif_capture.h |1 +
drivers
From: Mats Randgaard
- The ch_params tables in vpif_capture.c and vpif_display.c are moved to a
common
table in vpif.c. Then it is easier to maintain the table.
- The field "fps" is removed from the struct vpif_channel_config_params because
it
is not used.
Signed-off-by: Mats
From: Mats Randgaard
Support for DV preset and timings added to vpif_capture and vpif_display
drivers.
Functions for debugging are added and the code is improved as well.
Mats Randgaard (5):
vpif_cap/disp: Add debug functionality
vpif: Consolidate formats from capture and display
From: Mats Randgaard
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Murali Karicheri
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci/vpif.h | 13 ++---
drivers/media/video/davinci/vpif_capture.c | 13 ++---
drivers/media/video
From: Mats Randgaard
- Added functions to set/get/query/enum DV presets for vpif_caputre and
vpif_display.
- The format specification table is extended with all the DV formats supportet
by TVP7002.
support DV formats.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers
From: Mats Randgaard
Added functions to set and get custom DV timings.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci/vpif_capture.c | 119 +++
drivers/media/video/davinci/vpif_capture.h |1
From: Mats Randgaard
The following functions are added to the drivers:
- vpif_g_chip_ident
- vpif_dbg_g_register
- vpif_dbg_s_register
- vpif_log_status
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci
From: Mats Randgaard
Support for DV preset and timings added to vpif_capture and vpif_display
drivers.
Functions for debugging are added and the code is improved as well.
Mats Randgaard (5):
vpif_cap/disp: Add debug functionality
vpif: Consolidate formats from capture and display
From: Mats Randgaard
- Added functions to set/get/query/enum DV presets for vpif_caputre and
vpif_display.
- The format specification table is extended with all the DV formats supportet
by TVP7002.
support DV formats.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers
From: Mats Randgaard
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
Acked-by: Murali Karicheri
Acked-by: Vaibhav Hiremath
---
drivers/media/video/davinci/vpif.h | 13 ++---
drivers/media/video/davinci/vpif_capture.c | 13 ++---
drivers/media/video
From: Mats Randgaard
- The ch_params tables in vpif_capture.c and vpif_display.c are moved to a
common
table in vpif.c. Then it is easier to maintain the table.
- The field "fps" is removed from the struct vpif_channel_config_params because
it
is not used.
Signed-off-by: Mats
From: Mats Randgaard
Added functions to set/get/query/enum DV presets.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers/media/video/davinci/vpif_capture.c | 143 +++-
drivers/media/video/davinci/vpif_capture.h |1 +
drivers/media/video
From: Mats Randgaard
Added functions to set and get custom DV timings.
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers/media/video/davinci/vpif_capture.c | 119 +++
drivers/media/video/davinci/vpif_capture.h |1 +
drivers/media/video/davinci
From: Mats Randgaard
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers/media/video/davinci/vpif.h | 13 ++---
drivers/media/video/davinci/vpif_capture.c | 13 ++---
drivers/media/video/davinci/vpif_display.c | 23 ---
3
From: Mats Randgaard
- The ch_params tables in vpif_capture.c and vpif_display.c are moved to a
common
table in vpif.c. Then it is easier to maintain the table.
- The new table is extended with all the DV formats supportet by TVP7002.
- The field "fps" is removed from
From: Mats Randgaard
The following functions are added to the drivers:
- vpif_g_chip_ident
- vpif_dbg_g_register
- vpif_dbg_s_register
- vpif_log_status
Signed-off-by: Mats Randgaard
Signed-off-by: Hans Verkuil
---
drivers/media/video/davinci/vpif_capture.c | 87
From: Mats Randgaard
Support for DV preset and timings added to vpif_capture and vpif_display
drivers.
Functions for debugging are added and the code is improved as well.
Mats Randgaard (5):
vpif_cap/disp: Add debug functionality
vpif: Move and extend ch_params[]
vpif_cap/disp: Added
From: Mats Randgaard
Signed-off-by: Mats Randgaard
---
drivers/media/video/tvp7002.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c
index 48f5c76..8116cd4 100644
--- a/drivers/media/video/tvp7002.c
From: Mats Randgaard
Register values changed according to the data sheet and Texas Instruments
DaVinci_PSP_03_02_00_37.
- TVP7002_RGB_COARSE_CLAMP_CTL changed to the default value in data
sheet.
- TVP7002_HPLL_PHASE_SEL deleted because the registers write to
reserved bits. The
From: Mats Randgaard
The patch "TVP7002: Changed register values" depends on
http://www.mail-archive.com/linux-media@vger.kernel.org/msg20769.html
Mats Randgaard (2):
TVP7002: Return V4L2_DV_INVALID if any of the errors occur.
TVP7002: Changed register values.
drivers/media/vid
37 matches
Mail list logo
