Re: [PATCH] [media] dib0700: Return -EINTR and unlock mutex if locking attempts fails.

2012-03-19 Thread santosh prasad nayak
Can anyone please review it ? regards Santosh On Fri, Mar 16, 2012 at 6:15 PM, santosh nayak santoshprasadna...@gmail.com wrote: From: Santosh Nayak santoshprasadna...@gmail.com In 'dib0700_i2c_xfer_new()' and 'dib0700_i2c_xfer_legacy()' we are taking two locks:                1.

Re: [PATCH] [media] dib0700: Return -EINTR and unlock mutex if locking attempts fails.

2012-03-19 Thread santosh prasad nayak
not acquire lock);                mutex_unlock(d-i2c_mutex); regards, Olivier From: santosh prasad nayak [santoshprasadna...@gmail.com] Sent: Monday, March 19, 2012 9:47 AM To: mche...@infradead.org Cc: Olivier GRENIE; pboettc...@kernellabs.com; flor

Re: [PATCH] [media] staging: use mutex_lock() in s2250_probe().

2012-03-18 Thread santosh prasad nayak
On Sun, Mar 18, 2012 at 8:13 PM, walter harms wha...@bfs.de wrote: Am 17.03.2012 18:36, schrieb santosh nayak: From: Santosh Nayak santoshprasadna...@gmail.com Use uninterruptable sleep lock  'mutex_lock()'  in place of mutex_lock_interruptible() because there is no userspace for

Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails.

2012-03-17 Thread santosh prasad nayak
Yes. You are right. Caller is interpreting 0 in opposite way of normal sequence. Thats why I misunderstood it. In general, 0 means success and on error we return -ve. Here its opposite. regards Santosh On Sat, Mar 17, 2012 at 11:48 AM, David Miller da...@davemloft.net wrote: From:

Re: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.

2012-03-17 Thread santosh prasad nayak
); - } + -- Is it ok ? regards Santosh On Fri, Mar 16, 2012 at 11:29 PM, Oliver Neukum oli...@neukum.org wrote: Am Freitag, 16. März 2012, 17:56:20 schrieb santosh prasad nayak: On Fri, Mar 16, 2012 at 10:02 PM, Oliver Neukum

Re: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.

2012-03-16 Thread santosh prasad nayak
On Fri, Mar 16, 2012 at 10:02 PM, Oliver Neukum oli...@neukum.org wrote: Am Freitag, 16. März 2012, 17:23:58 schrieb santosh nayak: From: Santosh Nayak santoshprasadna...@gmail.com In s2250_probe(), If locking attempt is interrupted by a signal then it should return -EINTR after unregistering

Re: [media] dvb: Buffer Overfolow in cx24110_set_fec

2012-03-05 Thread santosh prasad nayak
        .           } fe_code_rate_t; OR Should rate[fec], g1[fec],and g2[fec] be initialized for FEC_6_7  fec    FEC_AUTO ?? If yes, what should be the initial values ? Regards Santosh On Sun, Mar 4, 2012 at 7:11 PM, santosh prasad nayak santoshprasadna

Re: [PATCH 2/2] Driver: video: Use the macro DMA_BIT_MASK().

2012-03-05 Thread santosh prasad nayak
Can you please comment on it ? Regards Santosh On Tue, Feb 21, 2012 at 3:43 PM, santosh nayak santoshprasadna...@gmail.com wrote: From: Santosh Nayak santoshprasadna...@gmail.com Use the macro DMA_BIT_MASK instead of the constant  0x. Signed-off-by: Santosh Nayak

[media] dvb: Buffer Overfolow in cx24110_set_fec

2012-03-04 Thread santosh prasad nayak
Hi, I am getting following error: drivers/media/dvb/frontends/cx24110.c:210 cx24110_set_fec() error: buffer overflow 'rate' 7 = 8 In cx24110_set_fec, arrays rate[] , g1[], g2[] have only 7 values. typedef enum fe_code_rate { FEC_6_7, // index 7 FEC_7_8,