Em Sun, 7 Oct 2018 16:05:57 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error
> handling fixes and the Sony imx214 sensor driver. In other words, patches
> that have roughly nil changes of breaking something.
>
> Compile
Hi Hans,
On Fri, Oct 05, 2018 at 09:49:00AM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This patch series converts the last remaining drivers that use g/s_crop and
> cropcap to g/s_selection.
>
> The first two patches do some minor code cleanup.
>
> The third patch adds a new
Hi Mauro,
Final pull request for 4.20 with odd 'n ends.
Regards,
Hans
The following changes since commit 557c97b5133669297be561e6091da9ab6e488e65:
media: cec: name for RC passthrough device does not need 'RC for' (2018-10-05
11:28:13 -0400)
are available in the Git repository at:
2018年10月8日(月) 20:21 Hans Verkuil :
>
> On 10/05/2018 04:59 PM, Akinobu Mita wrote:
> > 2018年10月5日(金) 18:36 Sakari Ailus :
> >>
> >> Hi Hans,
> >>
> >> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> >>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> The video_i2c_data is
On Mon, Oct 08, 2018 at 03:29:03PM +0200, Hans Verkuil wrote:
> On 10/08/2018 03:07 PM, Greg KH wrote:
> > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
> >> Replace calls to `printk` with the appropriate `pr_*`
> >> macro.
> >>
> >> Signed-off-by: Dafna Hirschfeld
> >> ---
>
On 10/08/2018 03:07 PM, Greg KH wrote:
> On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
>> Replace calls to `printk` with the appropriate `pr_*`
>> macro.
>>
>> Signed-off-by: Dafna Hirschfeld
>> ---
>> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
>>
On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++---
>
From: Bård Eirik Winther
New 16-bit bayer options are available in tpg so enable them in vivid.
Signed-off-by: Bård Eirik Winther
---
.../media/platform/vivid/vivid-vid-common.c | 28 +++
1 file changed, 28 insertions(+)
diff --git
From: Bård Eirik Winther
Add 16-bit bayer formats to the test pattern generator, namely
V4L2_PIX_FMT_SRGGB16
V4L2_PIX_FMT_SGRBG16
V4L2_PIX_FMT_SGBRG16
V4L2_PIX_FMT_SBGGR16
Signed-off-by: Bård Eirik Winther
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 28 +++
1
From: Bård Eirik Winther
Add OpenGL support to render all v4l2 16-bit bayer formats
Signed-off-by: Bård Eirik Winther
---
utils/qv4l2/capture-win-gl.cpp | 24
1 file changed, 24 insertions(+)
diff --git a/utils/qv4l2/capture-win-gl.cpp
From: Bård Eirik Winther
Add OpenGL support to render all v4l2 16-bit bayer formats
Signed-off-by: Bård Eirik Winther
---
utils/qvidcap/capture-win-gl.cpp | 28
utils/qvidcap/v4l2-convert.glsl | 13 +
2 files changed, 37 insertions(+), 4 deletions(-)
From: Bård Eirik Winther
Add missing build status flag for qvidcap to the configuration report
Signed-off-by: Bård Eirik Winther
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
index 2765fbfc..90ef10aa 100644
--- a/configure.ac
+++
From: Bård Eirik Winther
Add the remaining 16-bit bayer formats to rle_calc_bpl, namely:
V4L2_PIX_FMT_SGBRG16
V4L2_PIX_FMT_SGRBG16
V4L2_PIX_FMT_SRGGB16
Signed-off-by: Bård Eirik Winther
---
utils/common/v4l-stream.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Replace calls to `printk` with the appropriate `pr_*`
macro.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +-
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++---
drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 28 +---
Hi all,
I would like to meet up somewhere during the ELCE to discuss userspace support
for stateless (and perhaps stateful as well?) codecs.
It is also planned as a topic during the summit, but I would prefer to prepare
for that in advance, esp. since I myself do not have any experience writing
On 10/05/2018 04:59 PM, Akinobu Mita wrote:
> 2018年10月5日(金) 18:36 Sakari Ailus :
>>
>> Hi Hans,
>>
>> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
>>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
The video_i2c_data is allocated by kzalloc and released by the video
On 10/04/2018 05:03 PM, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab
>
> Add a glossary of terms used within the media userspace API
> documentation, as several concepts are complex enough to cause
> misunderstandings.
>
> Signed-off-by: Mauro Carvalho Chehab
With the
On Sat, 2018-10-06 at 07:36 +, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/media/platform/imx-pxp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/imx-pxp.c
> b/drivers/media/platform/imx-pxp.c
> index
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Mon Oct 8 05:00:09 CEST 2018
media-tree git hash:557c97b5133669297be561e6091da9ab6e488e65
media_build
I am contacting you because my office noticed you have an unclaimed Inheritance
contact me immediately for further details.
Hi Mauro,
This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error
handling fixes and the Sony imx214 sensor driver. In other words, patches
that have roughly nil changes of breaking something.
Compile tested with and without both subdev uAPI and MC on x86-64, plus on
arm as
Hi Dafna,
Thanks for you patch.
On 10/6/18 4:21 PM, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8
> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c |
Hi, dear user of vger.kernel.org
We have installed one RAT software into you device.
For this moment your email account is hacked (see on "from address", I messaged
you from your account).
Your password for linux-media@vger.kernel.org: 123456
I have downloaded all confidential information from
--
I, Mikhail Fridman have selected you specifically as one of my
beneficiaries for my Charitable Donation of $5 Million Dollars,
Check the link below for confirmation:
https://www.rt.com/business/343781-mikhail-fridman-will-charity/
I await your earliest response.
Best Regards,
Mikhail
On 10/07/2018 10:39 AM, Dafna Hirschfeld wrote:
> Hi,
> As part of applying to the outreachy program,
> I compiled the code in https://gitlab.collabora.com/koike/v4l2-codec.git
> I get errors running it.
> When I install vicodec.ko I see in the kernel log:
>
> [10752.727509] vicodec vicodec.0:
Hi,
As part of applying to the outreachy program,
I compiled the code in https://gitlab.collabora.com/koike/v4l2-codec.git
I get errors running it.
When I install vicodec.ko I see in the kernel log:
[10752.727509] vicodec vicodec.0: Device registered as /dev/video2
[10752.727534] vicodec
On 10/07/2018 01:03 AM, Sasha Levin wrote:
> On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote:
>> Replace calls to `printk` with the appropriate `pr_*`
>> macro.
>
> Hi Dafna,
>
> I'd encourage you to look into the dev_ family of print functions (such
> as dev_info() ). They can
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Oct 7 05:00:09 CEST 2018
media-tree git hash:557c97b5133669297be561e6091da9ab6e488e65
media_build
--
I am Mavis Wanczyk i know you may not know me but am the latest
largest US Powerball lottery winner of $758.7m just of recent, am
currently helping out people in need of financial assistance, i know
it's hard to believe anything on the internet, so if you don't need
my help please
On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote:
Replace calls to `printk` with the appropriate `pr_*`
macro.
Hi Dafna,
I'd encourage you to look into the dev_ family of print functions (such
as dev_info() ). They can avoid having to repeat the driver name in
every print
I am in the military unit here in Afghanistan, we have some amount of funds
that we want to move out of the country. My partners and I need a good partner
someone we can trust. It is risk free and legal. Reply to this email:
hornbeckmajorden...@gmail.com
Regards,
Major Dennis Hornbeck.
Replace calls to `printk` with the appropriate `pr_*`
macro.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8
drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 14 ++
drivers/media/usb/pvrusb2/pvrusb2-main.c | 4 ++--
--
I am Mavis Wanczyk i know you may not know me but am the latest
largest US Powerball lottery winner of $758.7m just of recent, am
currently helping out people in need of financial assistance, i know
it's hard to believe anything on the internet, so if you don't need
my help please
Good Day,
Please accept my apologies for writing you a surprise letter.I am
Mr.Ahmed Owain, account Manager with an investment bank here in
Burkina Faso.I have a very important business I want to discuss with
you.There is a draft account opened in my firm by a long-time client
of our bank.I have
Hi Ettore,
On 10/05/2018 07:33 PM, ektor5 wrote:
> This series of patches aims to add CEC functionalities to SECO
> devices, in particular UDOO X86.
>
> The communication is achieved via Braswell SMBus (i2c-i801) to the
> onboard STM32 microcontroller that handles the CEC signals. The driver
>
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/media/platform/imx-pxp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
index b76cd0e..229c23a 100644
--- a/drivers/media/platform/imx-pxp.c
+++
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Oct 6 05:00:13 CEST 2018
media-tree git hash:557c97b5133669297be561e6091da9ab6e488e65
media_build
If probe fails, the kernel will print the error code. There's no need to
driver to do that.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9714.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c
index
Hi Raj, others,
One fix and one cleanup for the dw9807 and dw9714 drivers. The dw9807
driver had the same issue than what you fixed in dw9714.
Sakari Ailus (2):
dw9714: Remove useless error message
dw9807: Fix probe error handling
drivers/media/i2c/dw9714.c | 2 +-
v4l2_async_unregister_subdev() may not be called without
v4l2_async_register_subdev() being called first. Fix this.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9807-vcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9807-vcm.c
Em Thu, 04 Oct 2018 23:06:02 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote:
> > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu:
> > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote:
On Fri, 2018-10-05 at 13:49 -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 05 Oct 2018 12:37:43 -0300
> Ezequiel Garcia escreveu:
>
> > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > > Em Thu, 04 Oct 2018 20:39:31 -0300
> > > Ezequiel Garcia escreveu:
> > >
> > > > On
Em Fri, 05 Oct 2018 12:37:43 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Oct 2018 20:39:31 -0300
> > Ezequiel Garcia escreveu:
> >
> > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > > On Fri, 2018-09-28
On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Oct 2018 20:39:31 -0300
> Ezequiel Garcia escreveu:
>
> > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > > On 09/17/2018 07:30 PM, Ezequiel
On Mon, Sep 24, 2018 at 01:34:46AM +0900, Akinobu Mita wrote:
> This patchset adds support for changing frame interval and runtime PM for
> video-i2c driver. This also adds an helper macro to v4l2 common
> internal API that is used to to find a suitable frame interval.
>
> There are a couple of
Em Fri, 5 Oct 2018 16:34:28 +0200
Oliver Freyermuth escreveu:
> Dear Mauro,
>
> thanks! Just to clarify, the issue I described in
> https://bugzilla.kernel.org/show_bug.cgi?id=199323
> was on an Intel x86_64 system, with an onboard USB Controller handled by the
> standard xhci driver,
> so
The three following Hauppauge USB DVB devices have IR receivers, but
lacked the support in mceusb to enable it:
- WinTV-HVR-935C
- WinTV-HVR-955Q
- WinTV-HVR-975
Tested HVR-955Q and HVR-975 plus RC5 remote and irw, works as intended.
Signed-off-by: Brad Love
---
drivers/media/rc/mceusb.c | 9
Hi Mita-san,
On Fri, Oct 05, 2018 at 11:59:20PM +0900, Akinobu Mita wrote:
> 2018年10月5日(金) 18:36 Sakari Ailus :
> >
> > Hi Hans,
> >
> > On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > > The video_i2c_data is allocated by
2018年10月5日(金) 18:36 Sakari Ailus :
>
> Hi Hans,
>
> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > The video_i2c_data is allocated by kzalloc and released by the video
> > > device's release callback. The release callback is
Dear Mauro,
thanks! Just to clarify, the issue I described in
https://bugzilla.kernel.org/show_bug.cgi?id=199323
was on an Intel x86_64 system, with an onboard USB Controller handled by the
standard xhci driver,
so this does not affect RPi alone.
Cheers and thanks,
Oliver
Am 05.10.18
As pointed at:
https://bugzilla.kernel.org/show_bug.cgi?id=199323
This patch causes a bad effect on RPi. I suspect that the root
cause is at the USB RPi driver, with uses high priority
interrupts instead of normal ones. Anyway, as this patch
is mostly a cleanup, better to revert it.
This
As pointed at:
https://bugzilla.kernel.org/show_bug.cgi?id=199323
This patch causes a bad effect on RPi. I suspect that the root
cause is at the USB RPi driver, with uses high priority
interrupts instead of normal ones. Anyway, as this patch
is mostly a cleanup, better to revert it.
This
Function alignments are off by 1 space, as reported by
checkpatch.pl --strict.
Fix those.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/imx355.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/imx355.c
Function alignments are off by 1 space, as reported by
checkpatch.pl --strict.
Fix those.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/imx319.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/imx319.c
This pull request fixes various CEC bugs. The following patches are also
CCed to stable for 4.18:
cec: add new tx/rx status bits to detect aborts/timeouts
adv7604: when the EDID is cleared, unconfigure CEC as well
adv7842: when the EDID is cleared, unconfigure CEC as well
Hi Mauro,
Here are fixes for the Omnivision sensor drivers. Please pull.
The following changes since commit f492fb4f5b41e8e62051e710369320e9ffa7a1ea:
media: MAINTAINERS: Fix entry for the renamed dw9807 driver (2018-10-05
08:40:00 -0400)
are available in the git repository at:
Hi,
On 05-10-18 13:55, Mauro Carvalho Chehab wrote:
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
Hi All,
On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
Hi Hans,
Thanks for looking into. I remember MJPEG vs. JPEG being a source
of confusion for me a few years ago, so
Hi Mauro,
Here are drivers for Sony imx319 and imx355 sensors and an unlocked version
of v4l2_ctrl_grab() which is used by the driver.
Since v1, I've rebased this on the current master --- with the fwnode
patches.
Please pull.
The diff is here and effectively the same for both drivers:
diff
Em Fri, 05 Oct 2018 08:53:14 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 4 Oct 2018 21:12:24 -0300
> > Ezequiel Garcia escreveu:
> >
> > > From: Shunqian Zheng
> > >
> > > Add V4L2_PIX_FMT_JPEG_RAW format that does not
Em Thu, 04 Oct 2018 20:39:31 -0300
Ezequiel Garcia escreveu:
> On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote:
> > > > This series adds support for JPEG encoding via the
Am Freitag, 5. Oktober 2018, 02:12:22 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for RK3288 SoC.
>
> Fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to 4.21
Am Freitag, 5. Oktober 2018, 02:12:23 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for the RK3399 SoC.
>
> Also, fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
> Hi All,
>
> On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
> >
> > Hi Hans,
> >
> > Thanks for looking into. I remember MJPEG vs. JPEG being a source
> > of confusion for me a few years ago, so clarification is greatly
> >
On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 4 Oct 2018 21:12:24 -0300
> Ezequiel Garcia escreveu:
>
> > From: Shunqian Zheng
> >
> > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> > JPEG header in the output frame.
> >
> > Signed-off-by: Shunqian Zheng
Em Mon, 01 Oct 2018 08:42:56 -0400
Nicolas Dufresne escreveu:
> Hello Hans,
>
> Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit :
> > It turns out that we have both JPEG and Motion-JPEG pixel formats defined.
> >
> > Furthermore, some drivers support one, some the other and some
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Em Thu, 4 Oct 2018 21:12:24 -0300
Ezequiel Garcia escreveu:
> From: Shunqian Zheng
>
> Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> JPEG header in the output frame.
>
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Ezequiel Garcia
> ---
>
Hi Hans,
I like this series, nice work!
On 2018-10-05 09:49:00 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This patch series converts the last remaining drivers that use g/s_crop and
> cropcap to g/s_selection.
>
> The first two patches do some minor code cleanup.
>
> The third patch
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:11 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now vidioc_cropcap is only used to return the pixelaspect, so
> rename it accordingly.
>
> Signed-off-by: Hans Verkuil
For the v4l2 and rcar-vin changes:
Reviewed-by: Niklas Söderlund
On 10/05/18 12:47, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your work.
>
> On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Now that all drivers have dropped vidioc_g/s_crop we can remove
>> support for them in the V4L2 core.
>>
>> Signed-off-by: Hans
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now that all drivers have dropped vidioc_g/s_crop we can remove
> support for them in the V4L2 core.
>
> Signed-off-by: Hans Verkuil
If the quirk patch hurt my head this makes me smile!
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:03 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Some old Samsung drivers use the legacy crop API incorrectly:
> the crop and compose targets are swapped. Normally VIDIOC_G_CROP
> will return the CROP rectangle of a CAPTURE stream and
Hi Mauro,
On Fri, Oct 05, 2018 at 06:29:36AM -0400, Mauro Carvalho Chehab wrote:
> There are several coding style issues at those definitions,
> and the previous patchset added even more.
>
> Address the trivial ones by first calling:
>
> ./scripts/checkpatch.pl --strict --fix-inline
>
Em Fri, 5 Oct 2018 13:08:25 +0300
Sakari Ailus escreveu:
> > > This is still over 80 here. I think we could think of abbreviating what's
> > > in the function name, not limiting to the endpoint. I think I'd prefer to
> > > leave that for 4.21 as there's not much time anymore.
> >
> > Yes, I
Em Fri, 5 Oct 2018 13:06:04 +0300
Sakari Ailus escreveu:
> > > > - unsigned int i;
> > >
> > > I'd like to keep this here.
> >
> > Why? IMHO, it makes harder to read (yet, if you insist, I'm ok with
> > both ways).
>
> Generally loop, temporary, return etc. variables are nice
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:02 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This ensures that they won't be used in kernel code.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> include/uapi/linux/v4l2-common.h | 28
There are several coding style issues at those definitions,
and the previous patchset added even more.
Address the trivial ones by first calling:
./scripts/checkpatch.pl --strict --fix-inline
include/media/v4l2-async.h include/media/v4l2-fwnode.h
include/media/v4l2-mediabus.h
The fwnode patchset added a several new warnings, as identified by
checkpatch.pl --strict.
Those are at the core stuff, and makes harder to review patches there.
In order to fully address checkpatch.pl, we still need to:
- Add SPDX headers;
- Rename functions.
Let's do those on
The v4l2_fwnode_reference_parse_int_props() has a big name, causing
it to cause coding style warnings. Also, it depends on a const
struct embedded indide a function.
Rearrange the logic in order to move the struct declaration out
of such function and use it inside this function.
That cleans up
There is already a typedef for the parse endpoint function.
However, instead of using it, it is redefined at the C file
(and on one of the function headers).
Replace them by the function typedef, in order to cleanup
several related coding style warnings.
Signed-off-by: Mauro Carvalho Chehab
---
Hi Mauro,
On Fri, Oct 05, 2018 at 07:12:02AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 10:55:58 +0300
> Sakari Ailus escreveu:
...
> > > @@ -436,8 +437,7 @@ static int __v4l2_fwnode_endpoint_parse(struct
> > > fwnode_handle *fwnode,
> > > if (mbus_type !=
Hi Marek,
On Fri, Oct 05, 2018 at 10:01:41AM +0200, Marek Szyprowski wrote:
> Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common")
> and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from
> videobuf") moved videobuf2 framework source code finally to
>
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:01 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Drop the deprecated _ACTIVE part.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 8
> 1 file changed, 4
Em Fri, 5 Oct 2018 10:55:58 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote:
> > There are several coding style issues at those definitions,
> > and the previous patchset added even more.
> >
> > Address the trivial ones by
On Fri, Oct 05, 2018 at 06:52:20AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:01:18 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Feel free to ignore the comments on the first patch regarding the functions
> > below. There are other issues there though.
> >
> > On
On Fri, Oct 05, 2018 at 06:54:49AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:03:10 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > > The v4l2_fwnode_reference_parse_int_props() has a big name,
Em Fri, 5 Oct 2018 11:03:10 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > The v4l2_fwnode_reference_parse_int_props() has a big name, causing
> > it to cause coding style warnings. Also, it depends on a const
> > struct
Em Fri, 5 Oct 2018 11:01:18 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> Feel free to ignore the comments on the first patch regarding the functions
> below. There are other issues there though.
>
> On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote:
> > There is already a
Hi Hans,
On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > The video_i2c_data is allocated by kzalloc and released by the video
> > device's release callback. The release callback is called when
> > video_unregister_device() is
On Fri, Oct 05, 2018 at 09:37:11AM +0200, Hans Verkuil wrote:
> On 10/05/2018 12:21 AM, Sean Young wrote:
> > An RC device is does not need to be called 'RC for'. Simply the name
> > will suffice.
> >
> > Signed-off-by: Sean Young
>
> Reviewed-by: Hans Verkuil
>
> OK if I take this patch? I
On 10/02/18 18:17, Akinobu Mita wrote:
> 2018年10月1日(月) 18:40 Hans Verkuil :
>>
>> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
>>> The video_i2c_data is allocated by kzalloc and released by the video
>>> device's release callback. The release callback is called when
>>> video_unregister_device()
On Fri, Oct 5, 2018 at 5:38 PM Hans Verkuil wrote:
>
> On 10/05/2018 10:16 AM, Tomasz Figa wrote:
> > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote:
> >>
> >> On 10/05/2018 05:12 AM, Tomasz Figa wrote:
> >>> Hi Hans,
> >>>
> >>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote:
>
>
On 10/05/2018 10:16 AM, Tomasz Figa wrote:
> On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote:
>>
>> On 10/05/2018 05:12 AM, Tomasz Figa wrote:
>>> Hi Hans,
>>>
>>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote:
Hi all,
I'm looking at removing the last users of
This adds the Rockchip VPU JPEG encoder staging driver.
Note: this goes on top of the request_api branch!
It does not use the request API as such, but it would otherwise conflict
with that series, so it is easier to just base it on top of the request_api
branch.
You will get a linker warning
On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote:
>
> On 10/05/2018 05:12 AM, Tomasz Figa wrote:
> > Hi Hans,
> >
> > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote:
> >>
> >> Hi all,
> >>
> >> I'm looking at removing the last users of vidioc_g/s_crop from the driver
> >> and
> >> I came
Hi Mauro,
Feel free to ignore the comments on the first patch regarding the functions
below. There are other issues there though.
On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote:
> There is already a typedef for the parse endpoint function.
> However, instead of using it,
Hi Mauro,
On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> The v4l2_fwnode_reference_parse_int_props() has a big name, causing
> it to cause coding style warnings. Also, it depends on a const
> struct embedded indide a function.
>
> Rearrange the logic in order to move
Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common")
and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from
videobuf") moved videobuf2 framework source code finally to
drivers/media/common/videobuf2 directory, so update relevant paths in
MAINTAINERS file.
Hi Mauro,
On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote:
> There are several coding style issues at those definitions,
> and the previous patchset added even more.
>
> Address the trivial ones by first calling:
>
> ./scripts/checkpatch.pl --strict --fix-inline
>
1501 - 1600 of 130834 matches
Mail list logo
