[PATCH 2/3] media: stkwebcam: Bugfix for not correctly initialized camera

2018-11-23 Thread Andreas Pape
stk_start_stream can only be called successfully if stk_initialise and stk_setup_format are called before. When using e.g. cheese it was observed that stk_initialise and stk_setup_format have not been called before which leads to no picture in that software whereas other tools like guvcview worked

[PATCH 1/3] media: stkwebcam: Support for ASUS A6VM notebook added.

2018-11-23 Thread Andreas Pape
The ASUS A6VM notebook has a built in stk11xx webcam which is mounted in a way that the video is vertically and horizontally flipped. Therefore this notebook is added to the special handling in the driver to automatically flip the video into the correct orientation. Signed-off-by: Andreas Pape

[PATCH 0/3] Fix for webcam issues with ASUS A6VM

2018-11-23 Thread Andreas Pape
This set of patches makes the Syntek USB webcam integrated into Asus A6VM notebooks accessible again. Andreas Pape (3): media: stkwebcam: Support for ASUS A6VM notebook added. media: stkwebcam: Bugfix for not correctly initialized camera media: stkwebcam: Bugfix for wrong return values

[PATCH 3/3] media: stkwebcam: Bugfix for wrong return values

2018-11-23 Thread Andreas Pape
usb_control_msg returns in case of a successfully sent message the number of sent bytes as a positive number. Don't use this value as a return value for stk_camera_read_reg, as a non-zero return value is used as an error condition in some cases when stk_camera_read_reg is called. Signed-off-by:

Re: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-23 Thread Eugen.Hristev
On 21.11.2018 16:50, Ken Sloat wrote: >>> From: Ken Sloat >>> >>> In some usages isc->raw_fmt will not be initialized. If this is the >>> case, it is very possible that a NULL struct de-reference will occur, >>> as this member is referenced many times. > >> Hello Ken, > >> Do you have any

Re: 'bad remote port parent' warnings

2018-11-23 Thread Fabio Estevam
Hi Sakari, On Fri, Nov 23, 2018 at 10:35 AM Sakari Ailus wrote: > Makes sense. This is not necessarily a fatal error. Could you send a patch? Yes, I have just sent it. Thanks

[PATCH] media: v4l2-fwnode: Demote warning to debug level

2018-11-23 Thread Fabio Estevam
On a imx6q-wandboard the following warnings are observed: [4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote port parent [4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote port parent As explained by Philipp Zabel: "There are empty endpoint nodes (without

Re: 'bad remote port parent' warnings

2018-11-23 Thread Sakari Ailus
Hi Fabio, Philipp, On Thu, Nov 22, 2018 at 05:17:44PM -0200, Fabio Estevam wrote: > Hi Philipp, > > On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote: > > > There are empty endpoint nodes (without remote-endpoint property) > > labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device

Re: [PATCH] media: vb2: be sure to free on errors

2018-11-23 Thread Hans Verkuil
On 11/23/2018 01:07 PM, Mauro Carvalho Chehab wrote: > As reported by smatch: > drivers/media/common/videobuf2/videobuf2-core.c: > drivers/media/common/videobuf2/videobuf2-core.c:2159 vb2_mmap() warn: > inconsistent returns 'mutex:>mmap_lock'. > Locked on: line 2148 > Unlocked on: line

[PATCH] media: vb2: be sure to free on errors

2018-11-23 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/common/videobuf2/videobuf2-core.c: drivers/media/common/videobuf2/videobuf2-core.c:2159 vb2_mmap() warn: inconsistent returns 'mutex:>mmap_lock'. Locked on: line 2148 Unlocked on: line 2100 line 2108 line 2113

[PATCH] vivid: fix smatch warnings

2018-11-23 Thread Hans Verkuil
Reorganize code to fix two smatch warnings: drivers/media/platform/vivid/vivid-core.c: drivers/media/platform/vivid/vivid-core.c:889 vivid_create_instance() warn: potentially one past the end of array 'dev->query_dv_timings_qmenu[dev->query_dv_timings_size]'

[PATCH] media: seco-cec: declare ops as static const

2018-11-23 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/platform/seco-cec/seco-cec.c:338:21: warning: symbol 'secocec_cec_adap_ops' was not declared. Should it be static? This struct should be static. Also, it is const, so declare it as such. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH] seco-cec: fix Makefile

2018-11-23 Thread Hans Verkuil
Fix the incorrect obj-y. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/seco-cec/Makefile b/drivers/media/platform/seco-cec/Makefile index 09900b087d02..a3f2c6bd3ac0 100644 --- a/drivers/media/platform/seco-cec/Makefile +++ b/drivers/media/platform/seco-cec/Makefile @@ -1

[PATCH v4l-utils] keytable: do not install bpf protocols decoders with execute permission

2018-11-23 Thread Sean Young
The rpm packaging system will try to extract debug information, which fails since there is no build id. This can be avoided by removing the execute permission. BPF relocatable files are executable anyway so this is the right thing to do. See:

[PATCH 1/2] media: sum6i-csi: Fix a few coding style issues

2018-11-23 Thread Mauro Carvalho Chehab
Make checkpatch.pl happier by running it on strict mode and using the --fix-inline to solve some issues. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 9 - drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 +-

[PATCH 2/2] media: sun6i-csi: manually fix other coding style issues

2018-11-23 Thread Mauro Carvalho Chehab
There are a few other coding style issues reported by checkpatch while in --strict mode. Fix the ones that make sense. Signed-off-by: Mauro Carvalho Chehab --- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 9 +++ .../platform/sunxi/sun6i-csi/sun6i_csi_reg.h | 24 +--

[GIT PULL FOR v4.21 v2] mem2mem, venus and vb2 fixes/improvements

2018-11-23 Thread Hans Verkuil
(Fixed my SoB mess) The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git

[GIT PULL FOR v4.21 v2] Various fixes/improvements

2018-11-23 Thread Hans Verkuil
The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100: media: vidioc_cropcap -> vidioc_g_pixelaspect (2018-11-20 13:57:21 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.20d3 for you to fetch changes up to

[GIT PULL FOR v4.21 v2] Various fixes

2018-11-23 Thread Hans Verkuil
(fixed my SoB mess in this v2) Various fixes, mostly related to issues found by syzbot. The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are available in

[GIT PULL FOR v4.21 v2] Various fixes

2018-11-23 Thread Hans Verkuil
(fixed up my SoB mess) Just one note: the "cec: keep track of outstanding transmits" is CC-ed to stable for v4.18 and up, but I prefer to wait until v4.21 before merging it to give it more test time. It is not something that happens in normal usage, so delaying this isn't a problem. Regards,

[GIT PULL FOR v4.21 v2] Various fixes (coda, rcar, pxp, others)

2018-11-23 Thread Hans Verkuil
Fixed my SoB mess. Regards, Hans The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are available in the Git repository at:

Re: [PATCH v2 4/4] [DO NOT MERGE] ARM: dts: sun8i: Add CAM500B camera module to the Nano Pi M1+

2018-11-22 Thread Jagan Teki
On Wed, Nov 14, 2018 at 8:29 PM Maxime Ripard wrote: > > From: Mylène Josserand > > The Nano Pi M1+ comes with an optional sensor based on the ov5640 from > Omnivision. Enable the support for it in the DT. > > Signed-off-by: Mylène Josserand > Signed-off-by: Maxime Ripard > --- >

cron job: media_tree daily build: WARNINGS

2018-11-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 23 05:00:11 CET 2018 media-tree git hash:8e782fcf78275f505194e767c515202d4fd274bc media_build

Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements

2018-11-22 Thread Mauro Carvalho Chehab
Hi Hans, Em Thu, 22 Nov 2018 23:26:07 +0100 Hans Verkuil escreveu: > On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 8 May 2018 12:48:45 +0200 > > Hans Verkuil escreveu: > > > >> Fixes/improvements all over the place. > >> > >> Changes since v1: > >> > >> Replaced "media:

Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements

2018-11-22 Thread Hans Verkuil
On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 12:48:45 +0200 > Hans Verkuil escreveu: > >> Fixes/improvements all over the place. >> >> Changes since v1: >> >> Replaced "media: media-device: fix ioctl function types" with the v2 version >> of that patch. My fault, I

Re: [PATCH] vim2m: use cancel_delayed_work_sync instead of flush_schedule_work

2018-11-22 Thread Hans Verkuil
On 11/07/2018 03:04 PM, Hans Verkuil wrote: > The use of flush_schedule_work() made no sense and caused a syzkaller error. > Replace with the correct cancel_delayed_work_sync(). > > Signed-off-by: Hans Verkuil Mistyped that SoB, this should of course be: Signed-off-by: Hans Verkuil Regards,

Hello Dear.

2018-11-22 Thread mrsmimilove
Hello Dear My name is Doctor smith Tracy, I am 26 years old medical doctor from USA united state of America. presently working and living in the UK United kingdom, my mum is from french why my father is from USA, I was just going through the Internet search when i saw your profile and like it,

Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements

2018-11-22 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 12:48:45 +0200 Hans Verkuil escreveu: > Fixes/improvements all over the place. > > Changes since v1: > > Replaced "media: media-device: fix ioctl function types" with the v2 version > of that patch. My fault, I missed Sakari's request for a change of v1. You should

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-22 Thread Ezequiel Garcia
On Thu, 2018-11-22 at 19:20 +0900, Tomasz Figa wrote: > Hi Ezequiel, > > On Thu, Nov 22, 2018 at 4:59 AM Ezequiel Garcia > wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > > platforms. > > > >

Re: [GIT PULL FOR v4.21] Various fixes

2018-11-22 Thread Mauro Carvalho Chehab
Hi Hans, Em Wed, 7 Nov 2018 11:31:14 +0100 Hans Verkuil escreveu: > Just one note: the "cec: keep track of outstanding transmits" is CC-ed to > stable > for v4.18 and up, but I prefer to wait until v4.21 before merging it to give > it > more test time. It is not something that happens in

Re: Bug in stkwebcam?

2018-11-22 Thread Kieran Bingham
Hi Andreas, On 22/11/2018 19:23, Andreas Pape wrote: > Hello, > > I recently updated my old 2006 Asus A6VM notebook with the latest 32bit > Ubuntu 18.04 LTS (kernel 4.15.0) and found out that the driver for the > webcam (Syntek USB2.0, USB ID 174f:a311) was not working. I only got error >

Bug in stkwebcam?

2018-11-22 Thread Andreas Pape
Hello, I recently updated my old 2006 Asus A6VM notebook with the latest 32bit Ubuntu 18.04 LTS (kernel 4.15.0) and found out that the driver for the webcam (Syntek USB2.0, USB ID 174f:a311) was not working. I only got error messages like "Sensor resetting failed" in dmesg when starting guvcview

Re: 'bad remote port parent' warnings

2018-11-22 Thread Fabio Estevam
Hi Philipp, On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote: > There are empty endpoint nodes (without remote-endpoint property) > labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees > for board DT implementers' convenience. See commit 2539f517acbdc ("ARM: > dts:

Re: 'bad remote port parent' warnings

2018-11-22 Thread Philipp Zabel
On Tue, 2018-11-20 at 10:10 -0200, Fabio Estevam wrote: > Hi, > > On a imx6q-wandboard running linux-next 20181120 there the following warnings: > > [4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote > port parent > [4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux:

[PATCH v5] media: video-i2c: support runtime PM

2018-11-22 Thread Akinobu Mita
AMG88xx has a register for setting operating mode. This adds support runtime PM by changing the operating mode. The instruction for changing sleep mode to normal mode is from the reference specifications. https://docid81hrs3j1.cloudfront.net/medialibrary/2017/11/PANA-S-A0002141979-1.pdf Cc:

[yavta PATCH 1/1] Zero dev in main()

2018-11-22 Thread Sakari Ailus
From: Sakari Ailus This is necessary since video_open() may not be always called soon Signed-off-by: Sakari Ailus --- yavta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/yavta.c b/yavta.c index c7986bd..de5376d 100644 --- a/yavta.c +++ b/yavta.c @@ -342,7 +342,6 @@

[PATCH v9 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by: Rui Miguel Silva --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0abecc528dac..afa2ad3c5600 100644 --- a/MAINTAINERS +++

[PATCH v9 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-11-22 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v9 03/13] media: staging/imx7: add imx7 CSI subdev driver

2018-11-22 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media-csi.c | 1354

[PATCH v9 04/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-11-22 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1135 2 files changed, 1136 insertions(+) create mode

[PATCH v9 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-11-22 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva ---

[PATCH v9 02/13] media: staging/imx: rearrange group id to take in account IPU

2018-11-22 Thread Rui Miguel Silva
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with

[PATCH v9 11/13] media: staging/imx: add i.MX7 entries to TODO file

2018-11-22 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 ---

[PATCH v9 10/13] media: imx7.rst: add documentation for i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files

[PATCH v9 05/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v9 01/13] media: staging/imx: refactor imx media device probe

2018-11-22 Thread Rui Miguel Silva
Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile| 1 +

[PATCH v9 12/13] media: video-mux: add bayer formats

2018-11-22 Thread Rui Miguel Silva
Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c index

[PATCH v9 07/13] ARM: dts: imx7s: add multiplexer controls

2018-11-22 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH v9 06/13] ARM: dts: imx7s: add mipi phy power domain

2018-11-22 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi

[PATCH v9 00/13] media: staging/imx7: add i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

Re: [PATCH v2 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-22 Thread Matt Ranostay
On Thu, Nov 22, 2018 at 12:57 AM Hans Verkuil wrote: > > On 11/22/2018 04:52 AM, Matt Ranostay wrote: > > Add initial support for MLX90640 thermal cameras which output an 32x24 > > greyscale pixel image along with 2 rows of coefficent data. > > > > Because of this the data outputed is really

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 10:46 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Thu, Nov 22, 2018 at 04:06:36PM +0900, Tomasz Figa wrote: > > Hi Ning, > > > > On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A > > wrote: > > > > > > Hello everyone > > > > > > when we need to setup media pipeline, eg,

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-22 Thread Sakari Ailus
Hi Tomasz, On Thu, Nov 22, 2018 at 04:06:36PM +0900, Tomasz Figa wrote: > Hi Ning, > > On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A wrote: > > > > Hello everyone > > > > when we need to setup media pipeline, eg, for camera capture, media-ctl > > needs to be called multiple time to setup media

Re: [PATCH] media: video-i2c: don't use msleep for 1ms - 20ms

2018-11-22 Thread Hans Verkuil
On 11/20/2018 04:27 PM, Akinobu Mita wrote: > Documentation/timers/timers-howto.txt says: > > "msleep(1~20) may not do what the caller intends, and will often sleep > longer (~20 ms actual sleep for any value given in the 1~20ms range)." > > So replace msleep(2) by usleep_range(2000, 3000).

Re: [PATCH v2 3/4] ARM: dts: sun8i: Add the H3/H5 CSI controller

2018-11-22 Thread Chen-Yu Tsai
On Thu, Nov 22, 2018 at 7:45 PM Jagan Teki wrote: > > On Wed, Nov 14, 2018 at 8:29 PM Maxime Ripard > wrote: > > > > From: Mylène Josserand > > > > The H3 and H5 features the same CSI controller that was initially found on > > the A31. > > > > Add a DT node for it. > > > > Signed-off-by:

[GIT PULL for 4.21] Sensor and CSI driver patches

2018-11-22 Thread Sakari Ailus
Hi Mauro, Here are a bunch of sensor driver improvements as well as a driver for the Allwinner CSI parallel bridge. Finally, a small uAPI documentation fix to better document the metadata capture buffers as well as interaction between frame interval and format. Please pull. The following

[GIT FIXES FOR v4.20] Revert "media: dt-bindings: Document the Rockchip VPU bindings"

2018-11-22 Thread Hans Verkuil
The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100: media: vidioc_cropcap -> vidioc_g_pixelaspect (2018-11-20 13:57:21 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.20n for you to fetch changes up to

Re: [PATCH v2 3/4] ARM: dts: sun8i: Add the H3/H5 CSI controller

2018-11-22 Thread Jagan Teki
On Wed, Nov 14, 2018 at 8:29 PM Maxime Ripard wrote: > > From: Mylène Josserand > > The H3 and H5 features the same CSI controller that was initially found on > the A31. > > Add a DT node for it. > > Signed-off-by: Mylène Josserand > Signed-off-by: Maxime Ripard > --- >

[PATCH for v4.4] Revert "media: videobuf2-core: don't call memop 'finish' when queueing"

2018-11-22 Thread Hans Verkuil
This reverts commit 46431d9c28f6859f8e568ac7db92137f1da31100. This commit fixes a bug in upstream commit a136f59c0a1f ("vb2: Move buffer cache synchronisation to prepare from queue") which isn't present in 4.4. So as a result you get an UNBALANCED message in the kernel log if this patch is

[PATCH for v4.9] Revert "media: videobuf2-core: don't call memop 'finish' when queueing"

2018-11-22 Thread Hans Verkuil
This reverts commit 9ac47200b51cb09d2f15dbefa67e0412741d98aa. This commit fixes a bug in upstream commit a136f59c0a1f ("vb2: Move buffer cache synchronisation to prepare from queue") which isn't present in 4.9. So as a result you get an UNBALANCED message in the kernel log if this patch is

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-22 Thread Sakari Ailus
On Tue, Nov 20, 2018 at 09:21:50AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 20 Nov 2018 12:49:46 +0200 > Sakari Ailus escreveu: > > > Hi Greg, > > > > On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: >

Re: [PATCH] media: ov2680: fix null dereference at power on

2018-11-22 Thread Sakari Ailus
Hi Rui, On Wed, Nov 21, 2018 at 10:59:55AM +, Rui Miguel Silva wrote: > Swapping the order between v4l2 subdevice registration and checking chip id in > b7a417628abf ("media: ov2680: don't register the v4l2 subdevice before > checking chip ID") > makes the mode restore to use the sensor

Re: [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 7:29 PM Hans Verkuil wrote: > > Hi Ezeguiel, > > Just saw Tomasz' in-depth review and decided to drop this pull request. > > He found a few too many issues and I prefer those are addressed first. > > Sorry, still more work for you, on to v11! I'm really sorry for the late

Re: [PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-22 Thread Tomasz Figa
On Thu, Nov 22, 2018 at 4:58 AM Ezequiel Garcia wrote: > > Add the Video Processing Unit node for the RK3399 SoC. > > Also, fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Signed-off-by: Ezequiel Garcia > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi |

Re: [PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-22 Thread Tomasz Figa
Hi Ezequiel, On Thu, Nov 22, 2018 at 4:17 AM Ezequiel Garcia wrote: > > Add the Video Processing Unit node for RK3288 SoC. > > Fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Signed-off-by: Ezequiel Garcia > --- > arch/arm/boot/dts/rk3288.dtsi | 14

Re: [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder

2018-11-22 Thread Hans Verkuil
Hi Ezeguiel, Just saw Tomasz' in-depth review and decided to drop this pull request. He found a few too many issues and I prefer those are addressed first. Sorry, still more work for you, on to v11! Regards, Hans On 11/22/2018 10:39 AM, Hans Verkuil wrote: > The following changes

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-22 Thread Tomasz Figa
Hi Ezequiel, On Thu, Nov 22, 2018 at 4:59 AM Ezequiel Garcia wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia Sorry for being late to the party. Please see

[PATCH] dib0900: fix smatch warnings

2018-11-22 Thread Hans Verkuil
drivers/media/dvb-frontends/dib0090.c: drivers/media/dvb-frontends/dib0090.c:1075 dib0090_pwm_gain_reset() warn: '*_ramp_pwm_normal' 2590696709486571520 can't fit into 65535 '*bb_ramp' drivers/media/dvb-frontends/dib0090.c: drivers/media/dvb-frontends/dib0090.c:1083 dib0090_pwm_gain_reset()

[GIT FIXES FOR v4.20] gspca regression fix

2018-11-22 Thread Hans Verkuil
The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100: media: vidioc_cropcap -> vidioc_g_pixelaspect (2018-11-20 13:57:21 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.20m for you to fetch changes up to

Re: [PATCH v8 03/12] media: staging/imx7: add imx7 CSI subdev driver

2018-11-22 Thread Rui Miguel Silva
Hi Sakari, thanks for all the reviews. On Wed 21 Nov 2018 at 22:29, Sakari Ailus wrote: Hi Rui, On Wed, Nov 21, 2018 at 11:15:49AM +, Rui Miguel Silva wrote: This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva ---

Re: [PATCH v10 1/4] media: dt-bindings: Document the Rockchip VPU bindings

2018-11-22 Thread Hans Verkuil
On 11/21/2018 08:16 PM, Ezequiel Garcia wrote: > Add devicetree binding documentation for Rockchip Video Processing > Unit IP. > > Reviewed-by: Rob Herring > Signed-off-by: Ezequiel Garcia This one has been merged already. Regards, Hans > --- > .../bindings/media/rockchip-vpu.txt

Re: [PATCH v8 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Hi Sakari, On Wed 21 Nov 2018 at 22:16, Sakari Ailus wrote: Hi Rui, On Wed, Nov 21, 2018 at 11:15:51AM +, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob

[GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder

2018-11-22 Thread Hans Verkuil
The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100: media: vidioc_cropcap -> vidioc_g_pixelaspect (2018-11-20 13:57:21 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-jpeg for you to fetch changes up to

Re: [PATCH v8 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-22 Thread Rui Miguel Silva
Hi Hans, On Wed 21 Nov 2018 at 11:53, Hans Verkuil wrote: On 11/21/2018 12:15 PM, Rui Miguel Silva wrote: Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU

Re: [PATCH 1/1] v4l: uAPI doc: Changing frame interval won't change format

2018-11-22 Thread Hans Verkuil
On 11/21/2018 06:33 PM, Sakari Ailus wrote: > Document that changing the frame interval has no effect on frame size. > While this was the assumption in the API, it was not documented as such. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Thanks! Hans > --- >

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-22 Thread Zhang, Ning A
Tomasz, Thank you for your answers. learned a lot. BR. Ning. 在 2018-11-22四的 16:06 +0900,Tomasz Figa写道: > Hi Ning, > > On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A m> wrote: > > > > Hello everyone > > > > when we need to setup media pipeline, eg, for camera capture, > > media-ctl > > needs

Re: [PATCH v2 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-22 Thread Hans Verkuil
On 11/22/2018 04:52 AM, Matt Ranostay wrote: > Add initial support for MLX90640 thermal cameras which output an 32x24 > greyscale pixel image along with 2 rows of coefficent data. > > Because of this the data outputed is really 32x26 and needs the two rows > removed after using the coefficent

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Tomasz Figa
Hi Ning, On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A wrote: > > Hello everyone > > when we need to setup media pipeline, eg, for camera capture, media-ctl > needs to be called multiple time to setup media link and subdev > formats, or similar code in a single application. this will use >

cron job: media_tree daily build: WARNINGS

2018-11-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 22 05:00:11 CET 2018 media-tree git hash:5200ab6a32d6055428896a49ec9e3b1652c1a100 media_build

[PATCH v2 1/2] media: video-i2c: check if chip struct has set_power function

2018-11-21 Thread Matt Ranostay
Not all future supported video chips will always have power management support, and so it is important to check before calling set_power() is defined. Signed-off-by: Matt Ranostay --- drivers/media/i2c/video-i2c.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-)

[PATCH v2 0/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-21 Thread Matt Ranostay
Add initial support for Melexis line of thermal cameras. This is the first part of processing pipeline in which the real processing is done in userspace using the V4L2 camera data. Dependency patchset series: https://patchwork.kernel.org/cover/10650541/ Changes from v1: * add

[PATCH v2 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-21 Thread Matt Ranostay
Add initial support for MLX90640 thermal cameras which output an 32x24 greyscale pixel image along with 2 rows of coefficent data. Because of this the data outputed is really 32x26 and needs the two rows removed after using the coefficent information to generate processed images in userspace.

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-21 Thread Alexandre Courbot
On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: > > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag' where the

is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Zhang, Ning A
Hello everyone when we need to setup media pipeline, eg, for camera capture, media-ctl needs to be called multiple time to setup media link and subdev formats, or similar code in a single application. this will use multiple IOCTLs on "/dev/mediaX" and "/dev/v4l2-subdevY". to setup media

Re: [PATCH v8 04/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-11-21 Thread kbuild test robot
Hi Rui, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] media: staging/imx7: fix platform_no_drv_owner.cocci warnings

2018-11-21 Thread kbuild test robot
From: kbuild test robot drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 181331ab8acb ("media:

Re: [PATCH v8 01/12] media: staging/imx: refactor imx media device probe

2018-11-21 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v8 03/12] media: staging/imx7: add imx7 CSI subdev driver

2018-11-21 Thread Sakari Ailus
Hi Rui, On Wed, Nov 21, 2018 at 11:15:49AM +, Rui Miguel Silva wrote: > This add the media entity subdevice and control driver for the i.MX7 > CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Kconfig |9 +- >

Re: [PATCH v8 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-21 Thread Sakari Ailus
Hi Rui, On Wed, Nov 21, 2018 at 11:15:51AM +, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > Reviewed-by: Rob Herring > Acked-by: Sakari Ailus > --- >

[PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-21 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 +

[PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v10 0/4] Add Rockchip VPU JPEG encoder

2018-11-21 Thread Ezequiel Garcia
This series is based on Mauro's master branch, with the following patch applied: https://patchwork.kernel.org/patch/10676149/ Hans, If you think the driver is now ready, I'd like to merge only patches 1/4 and 4/4 (the driver per-se) via the media tree. The devicetree changes could go via

[PATCH v10 1/4] media: dt-bindings: Document the Rockchip VPU bindings

2018-11-21 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 +++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH 1/1] v4l: uAPI doc: Changing frame interval won't change format

2018-11-21 Thread Sakari Ailus
Document that changing the frame interval has no effect on frame size. While this was the assumption in the API, it was not documented as such. Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/vidioc-g-parm.rst | 3 +++

[RFCv4 PATCH 3/3] vimc: add property test code

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add properties to entities and pads to be able to test the properties API. Signed-off-by: Hans Verkuil --- drivers/media/platform/vimc/vimc-common.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/media/platform/vimc/vimc-common.c

[RFCv4 PATCH 0/3] This RFC patch series implements properties for the media controller.

2018-11-21 Thread Hans Verkuil
The main changes since RFCv3 are: - Add entity index to media_v2_pad - Add source/sink pad index to media_v2_link - Add owner_idx and owner type flags to media_v2_prop An updated v4l2-ctl and v4l2-compliance that can report properties is available here:

[RFCv4 PATCH 1/3] uapi/linux/media.h: add property support

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add a new topology struct that includes properties and adds index fields to quickly find references from one object to another in the topology arrays. Signed-off-by: Hans Verkuil --- include/uapi/linux/media.h | 88 -- 1 file changed, 84

[RFCv4 PATCH 2/3] media controller: add properties support

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add support for properties. In this initial implementation properties can be added to entities and pads. In addition, properties can be nested. Since this patch adds the topology_idx to the graph objects it is now easy to fill in the index fields in the topology to allow

RE: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-21 Thread Ken Sloat
>> From: Ken Sloat >> >> In some usages isc->raw_fmt will not be initialized. If this is the >> case, it is very possible that a NULL struct de-reference will occur, >> as this member is referenced many times. > Hello Ken, > Do you have any confidence that just by avoiding the NULL

<    1   2   3   4   5   6   7   8   9   10   >