Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread David Härdeman
Hi, the problem with triggering a keypress as soon as 32 bits have been received (i.e. before the trailing silence is detected) is that it would cause phantom keypresses on some other protocols (I'm thinking of NEC48, which does exist in the wild). Now, the question is why the trailing

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
On 2014-06-12 12:42, David Härdeman wrote: Hi, Hi, thanks for the response the problem with triggering a keypress as soon as 32 bits have been received (i.e. before the trailing silence is detected) Just for clarity: this patch does wait for the trailing silence. It does NOT wait for the

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread David Härdeman
On 2014-06-12 13:22, Niels Laukens wrote: On 2014-06-12 12:42, David Härdeman wrote: Hi, Hi, thanks for the response the problem with triggering a keypress as soon as 32 bits have been received (i.e. before the trailing silence is detected) Just for clarity: this patch does wait for the

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
On 2014-06-12 13:51, David Härdeman wrote: On 2014-06-12 13:22, Niels Laukens wrote: In that case, the alternative would be to start a timer when the TRAILING_SPACE is entered, and trigger the key-event after, say 2 bit-times. Another alternative is fix the driver to implement a timeout so

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread David Härdeman
On 2014-06-12 14:12, Niels Laukens wrote: On 2014-06-12 13:51, David Härdeman wrote: On 2014-06-12 13:22, Niels Laukens wrote: In that case, the alternative would be to start a timer when the TRAILING_SPACE is entered, and trigger the key-event after, say 2 bit-times. Another alternative is

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
On 2014-06-12 14:42, David Härdeman wrote: Could you paste the output from lsmod? At the end of this mail. Where did you get the driver? Is it this one? http://www.tbsdtv.com/download/document/common/tbs-linux-drivers_v140425.zip Yes, inside the zip is `linux-tbs-drivers.tar.bz2`, where the

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-11 Thread Niels Laukens
I have not received any response on this email... so I hope to bump this thread back to the more active region in most people's in-boxes. On 2014-05-31 10:37, Niels Laukens wrote: Hi, I believe I've found a bug in the NEC decoder for InfraRed remote controls. The problem manifests itself as

[BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-05-31 Thread Niels Laukens
Hi, I believe I've found a bug in the NEC decoder for InfraRed remote controls. The problem manifests itself as an extra keypress that happens when pushing different buttons in rapid succession. I can reproduce the problem easily (but not always) by pushing DOWN, DOWN, UP in rapid succession. I