Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Hans Verkuil
Hi Marek, Are you planning a RFCv2 for this? I've been implementing vb2 in an internal driver and this initialization order of vb2 is a bit of a pain to be honest. Regards, Hans On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: This patch introduces

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Marek Szyprowski
Hello, On Tuesday, August 23, 2011 12:11 PM Hans Verkuil wrote: Are you planning a RFCv2 for this? I've been implementing vb2 in an internal driver and this initialization order of vb2 is a bit of a pain to be honest. (snipped) Yes, I will post it till the end of the week. I'm sorry for

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-08-23 Thread Hans Verkuil
On Tuesday, August 23, 2011 12:14:17 Marek Szyprowski wrote: Hello, On Tuesday, August 23, 2011 12:11 PM Hans Verkuil wrote: Are you planning a RFCv2 for this? I've been implementing vb2 in an internal driver and this initialization order of vb2 is a bit of a pain to be honest.

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-07-24 Thread Pawel Osciak
Hi Jon and Marek, On Thu, Jun 30, 2011 at 15:18, Jonathan Corbet cor...@lwn.net wrote: On Wed, 29 Jun 2011 16:10:45 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: I do still wonder why this is an issue - why not pass the buffers through to the driver at VIDIOC_QBUF time?  I assume

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-07-06 Thread Marek Szyprowski
Hello, On Friday, July 01, 2011 12:18 AM Jonathan Corbet wrote: On Wed, 29 Jun 2011 16:10:45 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: I do still wonder why this is an issue - why not pass the buffers through to the driver at VIDIOC_QBUF time? I assume there must be a

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-30 Thread Jonathan Corbet
On Wed, 29 Jun 2011 16:10:45 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: I do still wonder why this is an issue - why not pass the buffers through to the driver at VIDIOC_QBUF time? I assume there must be a reason for doing things this way, I'd like to understand what it is.

[PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is called. This resolves the most common case when the driver needs to know buffer addresses

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Laurent Pinchart
Hi Marek, On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is called. This

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 12:45 PM Laurent Pinchart wrote: On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Hans Verkuil
On Wednesday, June 29, 2011 12:44:48 Laurent Pinchart wrote: Hi Marek, On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Hans Verkuil
On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is called. This resolves the

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 1:15 PM Hans Verkuil wrote: On Wednesday, June 29, 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the

RE: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Marek Szyprowski
Hello, On Wednesday, June 29, 2011 1:02 PM Hans Verkuil wrote: On Wednesday, June 29, 2011 12:44:48 Laurent Pinchart wrote: Hi Marek, On Wednesday 29 June 2011 11:49:06 Marek Szyprowski wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Jonathan Corbet
On Wed, 29 Jun 2011 11:49:06 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is