Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-28 Thread Sakari Ailus
On Wed, Jan 21, 2015 at 10:39:05AM +0100, Jacek Anaszewski wrote: > I agree. I think that led-sources-cnt is redundant. A list property > can be read using of_prop_next_u32 function. I missed that and thus > proposed putting led-sources-cnt in each sub-node to be able to read > led-sources list wit

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-21 Thread Jacek Anaszewski
On 01/20/2015 06:40 PM, Pavel Machek wrote: On Tue 2015-01-20 11:29:16, Rob Herring wrote: On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski wrote: On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: On 01/16/2015 02:48 PM, Rob Herring wrote: [...] You may want to add something like led-out

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-20 Thread Pavel Machek
On Tue 2015-01-20 11:29:16, Rob Herring wrote: > On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski > wrote: > > On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: > >> > >> On 01/16/2015 02:48 PM, Rob Herring wrote: > > [...] > > >>> You may want to add something like led-output-cnt or led-driver-

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-20 Thread Rob Herring
On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski wrote: > On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: >> >> On 01/16/2015 02:48 PM, Rob Herring wrote: [...] >>> You may want to add something like led-output-cnt or led-driver-cnt in >>> the parent so you know the max list size. >> >> >> Why

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-20 Thread Jacek Anaszewski
On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: On 01/16/2015 02:48 PM, Rob Herring wrote: On Fri, Jan 16, 2015 at 3:07 AM, Jacek Anaszewski wrote: On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski wrote: On 01/12/2015 05:55 PM, Rob Herring wrote

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Jacek Anaszewski
On 01/16/2015 02:48 PM, Rob Herring wrote: On Fri, Jan 16, 2015 at 3:07 AM, Jacek Anaszewski wrote: On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski wrote: On 01/12/2015 05:55 PM, Rob Herring wrote: Adding Mark B and Liam... On Mon, Jan 12, 2

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Rob Herring
On Fri, Jan 16, 2015 at 3:07 AM, Jacek Anaszewski wrote: > On 01/15/2015 03:24 PM, Rob Herring wrote: >> >> On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski >> wrote: >>> >>> On 01/12/2015 05:55 PM, Rob Herring wrote: Adding Mark B and Liam... On Mon, Jan 12, 2015 at 10:

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Sylwester Nawrocki
Hi, On 15/01/15 22:03, Pavel Machek wrote: >> Perhaps we could use the 'reg' property to describe actual connections, >> > I'm not sure if it's better than a LED specific property, e.g. >> > >> > max77387@52 { >> > compatible = "nxp,max77387"; >> > #address-cells = <2>; >> >

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Jacek Anaszewski
On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski wrote: On 01/12/2015 05:55 PM, Rob Herring wrote: Adding Mark B and Liam... On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski wrote: On 01/12/2015 02:52 PM, Rob Herring wrote: On Mon, Jan 12,

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-15 Thread Pavel Machek
Hi! > Perhaps we could use the 'reg' property to describe actual connections, > I'm not sure if it's better than a LED specific property, e.g. > > max77387@52 { > compatible = "nxp,max77387"; > #address-cells = <2>; > #size-cells = <0>; > reg = <0x52>; > > f

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-15 Thread Mark Brown
On Thu, Jan 15, 2015 at 08:24:26AM -0600, Rob Herring wrote: > On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski > > I am aware that it may be tempting to treat LED devices as common > > regulators, but they have their specific features which gave a > > reason for introducing LED class for them. B

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-15 Thread Rob Herring
On Thu, Jan 15, 2015 at 6:33 AM, Sylwester Nawrocki wrote: > On 12/01/15 18:06, Mark Brown wrote: >> On Mon, Jan 12, 2015 at 10:55:29AM -0600, Rob Herring wrote: >>> > On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski > > There are however devices that don't fall into this category, i.e. the

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-15 Thread Rob Herring
On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski wrote: > On 01/12/2015 05:55 PM, Rob Herring wrote: >> >> Adding Mark B and Liam... >> >> On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski >> wrote: >>> >>> On 01/12/2015 02:52 PM, Rob Herring wrote: On Mon, Jan 12, 2015 at 2:32 A

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-15 Thread Sylwester Nawrocki
On 12/01/15 18:06, Mark Brown wrote: > On Mon, Jan 12, 2015 at 10:55:29AM -0600, Rob Herring wrote: >> > On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski >>> > > There are however devices that don't fall into this category, i.e. they >>> > > have many outputs, that can be connected to a single LE

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-13 Thread Jacek Anaszewski
On 01/12/2015 05:55 PM, Rob Herring wrote: Adding Mark B and Liam... On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski wrote: On 01/12/2015 02:52 PM, Rob Herring wrote: On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski wrote: On 01/09/2015 07:33 PM, Rob Herring wrote: On Fri, Jan 9, 2015

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Mark Brown
On Mon, Jan 12, 2015 at 10:55:29AM -0600, Rob Herring wrote: > On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski > > There are however devices that don't fall into this category, i.e. they > > have many outputs, that can be connected to a single LED or to many LEDs > > and the driver has to know

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Rob Herring
Adding Mark B and Liam... On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski wrote: > On 01/12/2015 02:52 PM, Rob Herring wrote: >> >> On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski >> wrote: >>> On 01/09/2015 07:33 PM, Rob Herring wrote: On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Jacek Anaszewski
On 01/12/2015 02:52 PM, Rob Herring wrote: On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski wrote: On 01/09/2015 07:33 PM, Rob Herring wrote: On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski wrote: Add a property for defining the device outputs the LED represented by the DT child node is

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Rob Herring
On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski wrote: > On 01/09/2015 07:33 PM, Rob Herring wrote: >> >> On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski >> wrote: >>> >>> Add a property for defining the device outputs the LED >>> represented by the DT child node is connected to. >>> >>> Signe

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Jacek Anaszewski
On 01/09/2015 07:33 PM, Rob Herring wrote: On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski wrote: Add a property for defining the device outputs the LED represented by the DT child node is connected to. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-09 Thread Rob Herring
On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski wrote: > Add a property for defining the device outputs the LED > represented by the DT child node is connected to. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Rob Herring > Cc: Pawel

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-09 Thread Pavel Machek
On Fri 2015-01-09 16:22:53, Jacek Anaszewski wrote: > Add a property for defining the device outputs the LED > represented by the DT child node is connected to. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Rob Herring > Cc: Pawel Moll

[PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-09 Thread Jacek Anaszewski
Add a property for defining the device outputs the LED represented by the DT child node is connected to. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- Documentati