Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-05-06 Thread Sakari Ailus
Hi Jacek, On Mon, Apr 28, 2014 at 01:27:27PM +0200, Jacek Anaszewski wrote: ... +static void max77693_brightness_set_work(struct work_struct *work) +{ + struct max77693_led *led = + container_of(work, struct max77693_led, work_brightness_set); + int ret; + + mutex_lock(led-lock);

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-28 Thread Jacek Anaszewski
Hi Sakari, On 04/23/2014 05:52 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the answers to my comments! :-) On Thu, Apr 17, 2014 at 11:23:06AM +0200, Jacek Anaszewski wrote: On 04/16/2014 07:26 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-23 Thread Sakari Ailus
Hi Jacek, Thanks for the answers to my comments! :-) On Thu, Apr 17, 2014 at 11:23:06AM +0200, Jacek Anaszewski wrote: On 04/16/2014 07:26 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at 04:56:54PM +0200, Jacek Anaszewski wrote: This patch

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-17 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 04/16/2014 07:26 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at 04:56:54PM +0200, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-16 Thread Lee Jones
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface or through V4L2 subdevice when the support for V4L2 Flash sub-devices is enabled. Device supports up to two leds which can work in flash and torch mode.

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-16 Thread Sakari Ailus
Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at 04:56:54PM +0200, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface or through V4L2 subdevice when the support

[PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-11 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface or through V4L2 subdevice when the support for V4L2 Flash sub-devices is enabled. Device supports up to two leds which can work in flash and torch mode. Leds can