Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Mauro Carvalho Chehab
Em 18-08-2011 15:11, Chris Rankin escreveu: > Two more patches: > > a) clean up resources more reliably if em28xx_init_dev() fails, > b) move two printk() statements outside the mutex lock > > Cheers, > Chris > > Signed-off-by: Chris Rankin > Chris, Please, never send two patches at the same

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Mauro Carvalho Chehab
Em 18-08-2011 12:56, Chris Rankin escreveu: > On 18/08/11 19:43, Devin Heitmueller wrote: >> You would be well served to break this into a patch series, as it tends to >> be difficult to review a whole series of changes in a single patch. You seem >> to be mixed in a bunch of "useless" changes al

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
The final patch removes the unplug/replug deadlock by not holding the device mutex during dvb_init(). However, this mutex has already been locked during device initialisation by em28xx_usb_probe() and is not released again until all extensions have been initialised successfully. The device mut

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
This patch closes the race on the device and extension lists at USB disconnect time. Previously, the device was removed from the device list during em28xx_release_resources(), and then passed to the em28xx_close_extension() function so that all extensions could run their fini() operations. Howev

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
Next patch: By default, the DVB framework tries to put a frontend to sleep after it has been shut down. This obviously doesn't work for a USB device that has been disconnected, and can result in occasional errors in dmesg about I2C writes failing with error code -19. The patch works by nulling

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
Two more patches: a) clean up resources more reliably if em28xx_init_dev() fails, b) move two printk() statements outside the mutex lock Cheers, Chris Signed-off-by: Chris Rankin --- linux-3.0/drivers/media/video/em28xx/em28xx-cards.c.orig 2011-08-18 22:42:03.0 +0100 +++ linux-3.0/dri

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
On 18/08/11 19:44, Devin Heitmueller wrote: You would be well served to break this into a patch series, as it tends to be difficult to review a whole series of changes in a single patch. Here are the first three patches: - release the alt_max_pkt_size buffer. - use atomic bit operations for em

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
On 18/08/11 19:43, Devin Heitmueller wrote: You would be well served to break this into a patch series, as it tends to be difficult to review a whole series of changes in a single patch. You seem to be mixed in a bunch of "useless" changes alongside functional changes. For example, if you're tr

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Devin Heitmueller
On Thu, Aug 18, 2011 at 2:43 PM, Devin Heitmueller wrote: > On Thu, Aug 18, 2011 at 1:52 PM, Chris Rankin wrote: >> Hi, >> >> Here's my latest patch for the em28xx / em28xx-dvb modules, which addresses >> the following problems: >> >> a) Locking problem when unplugging and then replugging USB ada

Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Devin Heitmueller
On Thu, Aug 18, 2011 at 1:52 PM, Chris Rankin wrote: > Hi, > > Here's my latest patch for the em28xx / em28xx-dvb modules, which addresses > the following problems: > > a) Locking problem when unplugging and then replugging USB adapter. > b) Race conditions between adding/removing devices from the

[PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e

2011-08-18 Thread Chris Rankin
Hi, Here's my latest patch for the em28xx / em28xx-dvb modules, which addresses the following problems: a) Locking problem when unplugging and then replugging USB adapter. b) Race conditions between adding/removing devices from the devlist, while simultaneously loading/unloading extension mod