Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-24 Thread Mauro Carvalho Chehab
Em 05-11-2011 15:57, Lawrence Rust escreveu: On Sat, 2011-11-05 at 18:38 +0100, Andreas Oberritter wrote: [snip] I don't get how this could be useful. MythTV knows what delivery system it wants to use, so it should pass this information to the kernel. Trying to set an invalid delivery system

[PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-05 Thread Lawrence Rust
Hi, I believe that I have found a problem with dtv_property_cache updating when handling the legacy API. This was introduced between 2.6.39 and 3.0. dtv_property_cache_submit() in dvb_frontend.c tests the field delivery_system and if it's a legacy type (including SYS_UNDEFINED) then it calls

Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-05 Thread Andreas Oberritter
On 05.11.2011 16:19, Lawrence Rust wrote: Hi, I believe that I have found a problem with dtv_property_cache updating when handling the legacy API. This was introduced between 2.6.39 and 3.0. dtv_property_cache_submit() in dvb_frontend.c tests the field delivery_system and if it's a

Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-05 Thread Lawrence Rust
On Sat, 2011-11-05 at 17:39 +0100, Andreas Oberritter wrote: [snip] How does MythTV set the parameters (i.e. using which interface, calls)? If using S2API, it should also set DTV_DELIVERY_SYSTEM. The following kern.log excerpt shows MythTV setting up the card: Nov 5 11:54:52 cyclops kernel: [

Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-05 Thread Andreas Oberritter
On 05.11.2011 18:20, Lawrence Rust wrote: On Sat, 2011-11-05 at 17:39 +0100, Andreas Oberritter wrote: [snip] How does MythTV set the parameters (i.e. using which interface, calls)? If using S2API, it should also set DTV_DELIVERY_SYSTEM. The following kern.log excerpt shows MythTV setting

Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache

2011-11-05 Thread Lawrence Rust
On Sat, 2011-11-05 at 18:38 +0100, Andreas Oberritter wrote: [snip] I don't get how this could be useful. MythTV knows what delivery system it wants to use, so it should pass this information to the kernel. Trying to set an invalid delivery system must fail. Using SYS_UNDEFINED as a pre-set