Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Greg Kroah-Hartman
On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote: > Hello Greg, > First, I appreciate you taking the time to educate me. I used the checkpatch > script on the file I fixed and he reported the line as an error. Do you > consider all checkpatch warnings/error/checks as coding style fixes?

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Ran Algawi
Hello Greg, I apperaciate you taking the time to educate me. Do you consider all checkpatch errors/warnnings/checks as code style fixes? With regards, Ran A.

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Greg KH
On Sat, Feb 11, 2017 at 12:41:29AM +0200, Ran Algawi wrote: > Fixed an error where the system was given a code in the form of decimal > instead of octal. It's not really an "error", right? Please be more descriptive of exactly what is going on here (hint, it's a coding style warning...) thanks,

[PATCH] Staging: media: bcm2048: Fixed an error

2017-02-10 Thread Ran Algawi
Fixed an error where the system was given a code in the form of decimal instead of octal. Signed-off-by: Ran Algawi --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/stagi