Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-18 Thread Sylwester Nawrocki
On 12/17/2010 05:35 PM, Sylwester Nawrocki wrote: Hi HeungJun, On 12/17/2010 07:42 AM, Kim, HeungJun wrote: Hi Sylwester, Thanks for some comments. I'll reflects this comments for the next version patch. It's clear that there is a few things I missed. It's better to let's talk about this

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-17 Thread Sylwester Nawrocki
Hi HeungJun, On 12/17/2010 07:42 AM, Kim, HeungJun wrote: Hi Sylwester, Thanks for some comments. I'll reflects this comments for the next version patch. It's clear that there is a few things I missed. It's better to let's talk about this rest things, as Mr. Park said. But, I wanna

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Kim, HeungJun
Hi Hans, 2010-12-16 오후 4:27, Hans Verkuil 쓴 글: Thanks for the reminder, I missed this patch. Review comments are below. snip + +/* MACRO */ +#define e_check_w(fn, cat, byte, val, bitwidth) do {\ +int ret;\ +ret

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Hans Verkuil
Hi Hans, 2010-12-16 ¿ÀÈÄ 4:27, Hans Verkuil ¾´ ±Û: Thanks for the reminder, I missed this patch. Review comments are below. snip + +/* MACRO */ +#define e_check_w(fn, cat, byte, val, bitwidth)do {\ + int ret;\ +

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Sylwester Nawrocki
Hi HeungJun, Please see my comments below. On 12/10/2010 08:40 AM, Kim, HeungJun wrote: This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. -- Hello, This is an initial version of I2C/V4L2 subdev driver for M5MOLS camera sensor using MIPI interface from Fujitsu. This sensor

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Kim, HeungJun
Hi Sylwester, Thanks for some comments. I'll reflects this comments for the next version patch. It's clear that there is a few things I missed. It's better to let's talk about this rest things, as Mr. Park said. But, I wanna remind one thing, and know your exact thiking. about MACROs. I

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-15 Thread Kim, HeungJun
Hi Hans, Any comments? Just ping. Thanks. Regards, HeungJun Kim 2010-12-10 오후 4:40, Kim, HeungJun 쓴 글: This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. -- Hello, This is an initial version of I2C/V4L2 subdev driver for M5MOLS camera sensor using MIPI interface

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-15 Thread Hans Verkuil
Thanks for the reminder, I missed this patch. Review comments are below. On Friday, December 10, 2010 08:40:27 Kim, HeungJun wrote: This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. -- Hello, This is an initial version of I2C/V4L2 subdev driver for M5MOLS camera

[PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-09 Thread Kim, HeungJun
This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. -- Hello, This is an initial version of I2C/V4L2 subdev driver for M5MOLS camera sensor using MIPI interface from Fujitsu. This sensor supports various resolution at various fps on Monitoring(as we know preview),