Re: [PATCH] bttv: fix mutex use before init

2010-12-17 Thread Torsten Kaiser
On Wed, Dec 15, 2010 at 10:45 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: While your patch fixes the issue, it has some other troubles, like to the presence of lock code at free_btres_lock(). It is possible to fix, but the better is to just use the core-assisted locking schema.

Re: [PATCH] bttv: fix mutex use before init

2010-12-17 Thread Brandon Philips
On 19:45 Wed 15 Dec 2010, Mauro Carvalho Chehab wrote: Em 15-12-2010 16:44, Chris Clayton escreveu: On Tuesday 14 December 2010, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock * add a

Re: [PATCH] bttv: fix mutex use before init

2010-12-17 Thread Mauro Carvalho Chehab
Em 17-12-2010 14:07, Brandon Philips escreveu: On 19:45 Wed 15 Dec 2010, Mauro Carvalho Chehab wrote: Em 15-12-2010 16:44, Chris Clayton escreveu: On Tuesday 14 December 2010, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND

Re: [PATCH] bttv: fix mutex use before init

2010-12-16 Thread Chris Clayton
On Wednesday 15 December 2010, Mauro Carvalho Chehab wrote: Em 15-12-2010 16:44, Chris Clayton escreveu: On Tuesday 14 December 2010, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock

Re: [PATCH] bttv: fix mutex use before init

2010-12-15 Thread Chris Clayton
On Tuesday 14 December 2010, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock * add a mutex_init(btv-init.cap.vb_lock) to the setup of init in bttv_probe() That seems like a

Re: [PATCH] bttv: fix mutex use before init

2010-12-15 Thread Mauro Carvalho Chehab
Em 15-12-2010 16:44, Chris Clayton escreveu: On Tuesday 14 December 2010, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock * add a mutex_init(btv-init.cap.vb_lock) to the setup of init in

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Dave Young
On Mon, Dec 13, 2010 at 04:30:24PM -0800, Brandon Philips wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock * add a mutex_init(btv-init.cap.vb_lock) to the setup of init in bttv_probe() That seems

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Torsten Kaiser
On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips bran...@ifup.org wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote:  * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock  * add a mutex_init(btv-init.cap.vb_lock) to the setup of init in bttv_probe() That

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Torsten Kaiser
On Tue, Dec 14, 2010 at 9:56 PM, Torsten Kaiser just.for.l...@googlemail.com wrote: Using the card also still works, but I think I found out what was causing sporadic shutdown problems with 37-rc kernels: When I try to exit tvtime it gets stuck in an uninterruptible D state and can't be

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Brandon Philips
On 21:56 Tue 14 Dec 2010, Torsten Kaiser wrote: On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips bran...@ifup.org wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote:  * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock  * add a

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Brandon Philips
On 22:13 Tue 14 Dec 2010, Torsten Kaiser wrote: On Tue, Dec 14, 2010 at 9:56 PM, Torsten Kaiser just.for.l...@googlemail.com wrote: Using the card also still works, but I think I found out what was causing sporadic shutdown problems with 37-rc kernels: When I try to exit tvtime it gets

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Dave Young
On Wed, Dec 15, 2010 at 5:43 AM, Brandon Philips bran...@ifup.org wrote: On 21:56 Tue 14 Dec 2010, Torsten Kaiser wrote: On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips bran...@ifup.org wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote:  * change fh-cap.vb_lock in bttv_open() AND

Re: [PATCH] bttv: fix mutex use before init

2010-12-14 Thread Torsten Kaiser
On Tue, Dec 14, 2010 at 10:43 PM, Brandon Philips bran...@ifup.org wrote: On 21:56 Tue 14 Dec 2010, Torsten Kaiser wrote: On Tue, Dec 14, 2010 at 1:30 AM, Brandon Philips bran...@ifup.org wrote: On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote:  * change fh-cap.vb_lock in bttv_open() AND

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Dave Young
On Sun, Dec 12, 2010 at 05:13:47PM +0100, Torsten Kaiser wrote: On Sun, Dec 12, 2010 at 2:15 PM, Dave Young hidave.darks...@gmail.com wrote: oops happen in bttv_open while locking uninitialized mutex fh-cap.vb_lock add mutex_init before usage I have seen the same problem twice since I

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Torsten Kaiser
On Mon, Dec 13, 2010 at 3:04 PM, Dave Young hidave.darks...@gmail.com wrote: On Sun, Dec 12, 2010 at 05:13:47PM +0100, Torsten Kaiser wrote: On Sun, Dec 12, 2010 at 2:15 PM, Dave Young hidave.darks...@gmail.com wrote: oops happen in bttv_open while locking uninitialized mutex fh-cap.vb_lock

Re: [PATCH] bttv: fix mutex use before init

2010-12-13 Thread Brandon Philips
On 17:13 Sun 12 Dec 2010, Torsten Kaiser wrote: * change fh-cap.vb_lock in bttv_open() AND radio_open() to btv-init.cap.vb_lock * add a mutex_init(btv-init.cap.vb_lock) to the setup of init in bttv_probe() That seems like a reasonable suggestion. An openSUSE user submitted this bug to our

[PATCH] bttv: fix mutex use before init

2010-12-12 Thread Dave Young
oops happen in bttv_open while locking uninitialized mutex fh-cap.vb_lock add mutex_init before usage Signed-off-by: Dave Young hidave.darks...@gmail.com Tested-by: Chris Clayton chris2...@googlemail.com --- drivers/media/video/bt8xx/bttv-driver.c |2 ++ 1 file changed, 2 insertions(+) ---

Re: [PATCH] bttv: fix mutex use before init

2010-12-12 Thread Torsten Kaiser
On Sun, Dec 12, 2010 at 2:15 PM, Dave Young hidave.darks...@gmail.com wrote: oops happen in bttv_open while locking uninitialized mutex fh-cap.vb_lock add mutex_init before usage I have seen the same problem twice since I switched of the BKL in 2.6.37-rc2, but only had the time today to search