Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-05 Thread Mauro Carvalho Chehab
Em 05-05-2011 09:44, Simon Farnsworth escreveu: > On Thursday 5 May 2011, Mauro Carvalho Chehab wrote: >> There are a few new warnings with your code: >> >> drivers/media/video/cx18/cx18-mailbox.c: In function >> ‘cx18_mdl_send_to_videobuf’: drivers/media/video/cx18/cx18-mailbox.c:206: >> warning:

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-05 Thread Simon Farnsworth
On Thursday 5 May 2011, Mauro Carvalho Chehab wrote: > There are a few new warnings with your code: > > drivers/media/video/cx18/cx18-mailbox.c: In function > ‘cx18_mdl_send_to_videobuf’: drivers/media/video/cx18/cx18-mailbox.c:206: > warning: passing argument 1 of ‘ktime_get_ts’ from incompatibl

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-05 Thread Mauro Carvalho Chehab
Hi Simon, Em 04-05-2011 06:32, Simon Farnsworth escreveu: > On Tuesday 3 May 2011, Andy Walls wrote: >> Simon, >> >> If these two changes are going in, please also bump the driver version to >> 1.5.0 in cx18-version.c. These changes are significant enough >> perturbation. >> >> End users are goi

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-04 Thread Mauro Carvalho Chehab
Em 04-05-2011 06:32, Simon Farnsworth escreveu: > On Tuesday 3 May 2011, Andy Walls wrote: >> Simon, >> >> If these two changes are going in, please also bump the driver version to >> 1.5.0 in cx18-version.c. These changes are significant enough >> perturbation. >> >> End users are going to look

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-04 Thread Simon Farnsworth
On Tuesday 3 May 2011, Andy Walls wrote: > Simon, > > If these two changes are going in, please also bump the driver version to > 1.5.0 in cx18-version.c. These changes are significant enough > perturbation. > > End users are going to look to driver version 1.4.1 as the first version > for prop

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2011 20:38, Andy Walls escreveu: > On Tue, 2011-05-03 at 20:01 -0300, Mauro Carvalho Chehab wrote: >> Em 03-05-2011 19:51, Andy Walls escreveu: >>> Simon Farnsworth wrote: > > >>> Simon, >>> >>> If these two changes are going in, please also bump the driver >> version to 1.5.0 in cx18-

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Andy Walls
On Tue, 2011-05-03 at 20:01 -0300, Mauro Carvalho Chehab wrote: > Em 03-05-2011 19:51, Andy Walls escreveu: > > Simon Farnsworth wrote: > > Simon, > > > > If these two changes are going in, please also bump the driver > version to 1.5.0 in cx18-version.c. These changes are significant > enoug

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2011 19:51, Andy Walls escreveu: > Simon Farnsworth wrote: > >> The initial version of this patch (commit >> d5976931639176bb655d96b9f8d959f79e9e) had some issues: >> >> * It didn't correctly calculate the size of the YUV buffer for 4:2:2, >> resulting in capture sometimes being of

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Andy Walls
Simon Farnsworth wrote: >The initial version of this patch (commit >d5976931639176bb655d96b9f8d959f79e9e) had some issues: > > * It didn't correctly calculate the size of the YUV buffer for 4:2:2, > resulting in capture sometimes being offset by 1/3rd of a picture. > > * There were a lot of

Re: [PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Hans Verkuil
Hi Simon, On Tuesday, May 03, 2011 13:57:40 Simon Farnsworth wrote: > The initial version of this patch (commit > d5976931639176bb655d96b9f8d959f79e9e) had some issues: > > * It didn't correctly calculate the size of the YUV buffer for 4:2:2, >resulting in capture sometimes being offset

[PATCH] cx18: Clean up mmap() support for raw YUV

2011-05-03 Thread Simon Farnsworth
The initial version of this patch (commit d5976931639176bb655d96b9f8d959f79e9e) had some issues: * It didn't correctly calculate the size of the YUV buffer for 4:2:2, resulting in capture sometimes being offset by 1/3rd of a picture. * There were a lot of variables duplicating informatio