Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-27 Thread Helmut Grohne
On Sat, Aug 25, 2018 at 01:32:47PM +0200, Sakari Ailus wrote: > On Fri, Aug 24, 2018 at 02:05:17PM +0200, Helmut Grohne wrote: > > Take for instance MT9M024. The data sheet > > (http://www.mouser.com/ds/2/308/MT9M024-D-606228.pdf) allows deducing > > the following limits: > > > > const struct

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-25 Thread Sakari Ailus
On Fri, Aug 24, 2018 at 02:05:17PM +0200, Helmut Grohne wrote: > Hi Laurent, > > Thank you for taking the time to reply to my patch and to my earlier > questions. > > On Thu, Aug 23, 2018 at 01:12:15PM +0200, Laurent Pinchart wrote: > > Could you please share numbers, ideally when run in kernel s

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-24 Thread Helmut Grohne
Hi Laurent, Thank you for taking the time to reply to my patch and to my earlier questions. On Thu, Aug 23, 2018 at 01:12:15PM +0200, Laurent Pinchart wrote: > Could you please share numbers, ideally when run in kernel space ? Can you explain the benefits of profiling this inside the kernel rath

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-24 Thread Helmut Grohne
Hi Sakari, Thank you for taking the time to look into the issue. On Thu, Aug 23, 2018 at 01:30:12PM +0200, Sakari Ailus wrote: > Knowing the formula, the limits as well as the external clock frequency, it > should be relatively straightforward to come up with a functional pixel > clock value. Was

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-23 Thread Sakari Ailus
Hi Helmut, On Thu, Aug 23, 2018 at 09:52:09AM +0200, Helmut Grohne wrote: > Clock frequencies are not exact values, but rather imprecise, physical > properties. The present pll computation however, treats them as exact. > It tries to compute parameters that attain the requested pix_clock > exactly

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-23 Thread Laurent Pinchart
Hi Helmut, Thank you for the patch. On Thursday, 23 August 2018 10:52:09 EEST Helmut Grohne wrote: > Clock frequencies are not exact values, but rather imprecise, physical > properties. The present pll computation however, treats them as exact. > It tries to compute parameters that attain the req

[PATCH] media: aptina-pll: allow approximating the requested pix_clock

2018-08-23 Thread Helmut Grohne
Clock frequencies are not exact values, but rather imprecise, physical properties. The present pll computation however, treats them as exact. It tries to compute parameters that attain the requested pix_clock exactly. Failing that, it gives up. The new implementation approximates the requested pix