Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-30 Thread Laurent Pinchart
Hi Prabhakar, On Monday 30 September 2013 18:57:01 Prabhakar Lad wrote: > On Mon, Sep 23, 2013 at 8:18 AM, Prabhakar Lad wrote: > > On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: > >> On 09/20/2013 10:11 AM, Prabhakar Lad wrote: > >>> OK I will, just send out a fix up patch which fixes

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-30 Thread Prabhakar Lad
Hi All, On Mon, Sep 23, 2013 at 8:18 AM, Prabhakar Lad wrote: > Hi Sylwester, > > On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki > wrote: >> Hi Prabhakar, >> >> On 09/20/2013 10:11 AM, Prabhakar Lad wrote: >>> OK I will, just send out a fix up patch which fixes the mismatch between >>> name

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-24 Thread Mark Brown
On Mon, Sep 23, 2013 at 01:50:51PM +0200, Laurent Pinchart wrote: > Isn't regulator_get_optional() intended for devices that can have supplies > unconnected in normal use ? The ADV7343 supplies are mandatory from a > hardware > point of view, so I think we should use regulator_get(). Otherwise

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-24 Thread Mark Brown
On Tue, Sep 24, 2013 at 11:44:57AM +0200, Laurent Pinchart wrote: > On Monday 23 September 2013 15:33:10 Stephen Warren wrote: > > So I think you want to make the supply properties mandatory in DT (since > > some form of supply is mandatory in HW), yet make the driver support > > broken DTs which

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-24 Thread Laurent Pinchart
On Monday 23 September 2013 15:33:10 Stephen Warren wrote: > On 09/23/2013 05:50 AM, Laurent Pinchart wrote: > > On Monday 23 September 2013 08:18:52 Prabhakar Lad wrote: > >> On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: > >>> On 09/20/2013 10:11 AM, Prabhakar Lad wrote: > OK I w

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-23 Thread Prabhakar Lad
On Tue, Sep 24, 2013 at 3:03 AM, Stephen Warren wrote: > On 09/23/2013 05:50 AM, Laurent Pinchart wrote: >> On Monday 23 September 2013 08:18:52 Prabhakar Lad wrote: >>> On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: On 09/20/2013 10:11 AM, Prabhakar Lad wrote: > OK I will, ju

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-23 Thread Stephen Warren
On 09/23/2013 05:50 AM, Laurent Pinchart wrote: > On Monday 23 September 2013 08:18:52 Prabhakar Lad wrote: >> On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: >>> On 09/20/2013 10:11 AM, Prabhakar Lad wrote: OK I will, just send out a fix up patch which fixes the mismatch between >>

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-23 Thread Laurent Pinchart
On Monday 23 September 2013 08:18:52 Prabhakar Lad wrote: > On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: > > On 09/20/2013 10:11 AM, Prabhakar Lad wrote: > >> OK I will, just send out a fix up patch which fixes the mismatch between > >> names for the rc-cycle, and later send out a pat

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-22 Thread Prabhakar Lad
Hi Sylwester, On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: > Hi Prabhakar, > > On 09/20/2013 10:11 AM, Prabhakar Lad wrote: >> OK I will, just send out a fix up patch which fixes the mismatch between >> names for the rc-cycle, and later send out a patch which removes the >> platform

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-20 Thread Sylwester Nawrocki
Hi Prabhakar, On 09/20/2013 10:11 AM, Prabhakar Lad wrote: > OK I will, just send out a fix up patch which fixes the mismatch between > names for the rc-cycle, and later send out a patch which removes the > platform data usage for next release with proper DT bindings. I think the binding need to

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-20 Thread Prabhakar Lad
Hi Sylwester, On Fri, Sep 20, 2013 at 1:19 AM, Sylwester Nawrocki wrote: > On 09/19/2013 06:06 PM, Prabhakar Lad wrote: >> >> On Mon, Sep 16, 2013 at 9:54 PM, Stephen Warren >> wrote: >>> >>> On 09/13/2013 11:23 PM, Prabhakar Lad wrote: On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren >>

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-19 Thread Sylwester Nawrocki
On 09/19/2013 06:06 PM, Prabhakar Lad wrote: On Mon, Sep 16, 2013 at 9:54 PM, Stephen Warren wrote: On 09/13/2013 11:23 PM, Prabhakar Lad wrote: On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren wrote: On 09/13/2013 05:57 AM, Prabhakar Lad wrote: From: "Lad, Prabhakar" This patch fixes the D

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-19 Thread Prabhakar Lad
Hi Stephen, On Mon, Sep 16, 2013 at 9:54 PM, Stephen Warren wrote: > On 09/13/2013 11:23 PM, Prabhakar Lad wrote: >> Hi Stephen, >> >> This patch should have been marked as RFC. >> >> Thanks for the review. >> >> On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren >> wrote: >>> On 09/13/2013 05:57

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-16 Thread Stephen Warren
On 09/13/2013 11:23 PM, Prabhakar Lad wrote: > Hi Stephen, > > This patch should have been marked as RFC. > > Thanks for the review. > > On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren wrote: >> On 09/13/2013 05:57 AM, Prabhakar Lad wrote: >>> From: "Lad, Prabhakar" >>> >>> This patch fixes th

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-13 Thread Prabhakar Lad
Hi Stephen, This patch should have been marked as RFC. Thanks for the review. On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren wrote: > On 09/13/2013 05:57 AM, Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch fixes the DT binding properties of adv7343 decoder. >> The pdata which

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-13 Thread Stephen Warren
On 09/13/2013 05:57 AM, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > This patch fixes the DT binding properties of adv7343 decoder. > The pdata which was being read from the DT property, is removed > as this can done internally in the driver using cable detection > register. > > This patch

[PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-13 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch fixes the DT binding properties of adv7343 decoder. The pdata which was being read from the DT property, is removed as this can done internally in the driver using cable detection register. This patch also removes the pdata of ADV7343 which was passed from DA850