Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-19 Thread Tomasz Figa
Hi Ping-chung, On Tue, Jul 17, 2018 at 3:53 PM Chen, Ping-chung wrote: > > Hi Sakari, > > Some of suggestions below has been added in to [PATCH v2] or [PATCH v3]. > We will fix others in PATCH v4 soon. I don't see v2 or v3 on linux-media (or my inbox). Where were they sent? I'd like to review

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-17 Thread Chen, Ping-chung
@vger.kernel.org; Yeh, Andy ; tf...@chromium.org Subject: Re: [PATCH] media: imx208: Add imx208 camera sensor driver Hi Ping-chung, Thanks for the patch. Please see my comments below. On Tue, Jul 10, 2018 at 03:15:36PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" >

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread sakari.ai...@linux.intel.com
ux-media@vger.kernel.org > > Cc: sakari.ai...@linux.intel.com; Yeh, Andy ; > > tf...@chromium.org; Chen, Ping-chung > > Subject: [PATCH] media: imx208: Add imx208 camera sensor driver > > +}; > > + > > +static int imx208_enum_mbus_code(struct v4l2_su

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread Sakari Ailus
Hi Ping-chung, Thanks for the patch. Please see my comments below. On Tue, Jul 10, 2018 at 03:15:36PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the >

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-10 Thread kbuild test robot
Hi Ping-chung, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-10 Thread kbuild test robot
Hi Ping-chung, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-10 Thread Yeh, Andy
> Subject: [PATCH] media: imx208: Add imx208 camera sensor driver > +}; > + > +static int imx208_enum_mbus_code(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_mbus_code_enum *cod

[PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-10 Thread Ping-chung Chen
From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 +