Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-08-03 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/02/2016 08:03 PM, Robert Jarzmik wrote: >> Hans Verkuil writes: >> [ 1509.773051] pxa27x-camera pxa27x-camera.0: >> s_fmt_vid_cap(pix=48x32:56595559) >> [ 1509.777213] pxa27x-camera pxa27x-camera.0: current_fmt->fourcc: 0x56595559 >> RJK: Here we switch to 48x3

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-08-03 Thread Hans Verkuil
On 08/02/2016 08:03 PM, Robert Jarzmik wrote: > Hans Verkuil writes: > > Hi Hans, > > Working further on the pxa_camera conversion out of soc_camera, I hit a > problem > of dma being very long, in running v4l2-compliance -f. > > After digging a bit, I realized that the video buffer queued wa

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-08-02 Thread Robert Jarzmik
Hans Verkuil writes: Hi Hans, Working further on the pxa_camera conversion out of soc_camera, I hit a problem of dma being very long, in running v4l2-compliance -f. After digging a bit, I realized that the video buffer queued was a 640x480 format, while the s_fmt_vid_cap() lastly called was a 4

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
On 03/11/2016 04:40 PM, Robert Jarzmik wrote: > Hans Verkuil writes: > >> On 03/11/2016 02:41 PM, Robert Jarzmik wrote: >>> Hans Verkuil writes: >> One area where I would like to see some helper functions is with respect to >> format/media bus processing. I played with this a little bit but it i

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > On 03/11/2016 02:41 PM, Robert Jarzmik wrote: >> Hans Verkuil writes: > One area where I would like to see some helper functions is with respect to > format/media bus processing. I played with this a little bit but it is > surprisingly > hard to do. A lot of devices have

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
On 03/11/2016 02:41 PM, Robert Jarzmik wrote: > Hans Verkuil writes: > >> Hi Robert, >> >> A quick review below. >> >> I assume this is the first step to moving the pxa_camera driver out of >> soc-camera? > Hi Hans, > > It probably is. The next step would be the soc_camera adherence removal. I >

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Robert Jarzmik
Hans Verkuil writes: > Hi Robert, > > A quick review below. > > I assume this is the first step to moving the pxa_camera driver out of > soc-camera? Hi Hans, It probably is. The next step would be the soc_camera adherence removal. I already began the work, but it's still in very early draft ugly

Re: [PATCH] media: platform: pxa_camera: convert to vb2

2016-03-11 Thread Hans Verkuil
Hi Robert, A quick review below. I assume this is the first step to moving the pxa_camera driver out of soc-camera? On 03/09/2016 06:17 PM, Robert Jarzmik wrote: > Convert pxa_camera from videobuf to videobuf2. > > As the soc_camera was already compatible with videobuf2, the port is > quite st

[PATCH] media: platform: pxa_camera: convert to vb2

2016-03-09 Thread Robert Jarzmik
Convert pxa_camera from videobuf to videobuf2. As the soc_camera was already compatible with videobuf2, the port is quite straightforward. The only special port of this code is that if the vb2 to prepare is "too big" in terms of size for the new capture format, the pxa_camera will accept it anywa