Hi Javier,
On Friday 29 July 2011 14:31:12 javier Martin wrote:
> All right,
> it works like a charm for me.
>
> It took me a bit to figure out that binning and skipping is controlled
> through ratio between cropping window size and actual format size but
> it is clear now.
>
> Just one thing; b
All right,
it works like a charm for me.
It took me a bit to figure out that binning and skipping is controlled
through ratio between cropping window size and actual format size but
it is clear now.
Just one thing; both VFLIP (this one is my fault) and HFLIP controls
change the pixel format of th
On Friday 29 July 2011 11:10:48 javier Martin wrote:
> Hi Laurent,
> I've been reviewing and testing your patch as promised.
>
> On 27 July 2011 19:51, Laurent Pinchart
>
> wrote:
> >> > +static int mt9p031_pll_enable(struct mt9p031 *mt9p031)
> >> > +{
> >> > + struct i2c_client *client = v4l2
Hi Laurent,
I've been reviewing and testing your patch as promised.
On 27 July 2011 19:51, Laurent Pinchart
wrote:
>> > +static int mt9p031_pll_enable(struct mt9p031 *mt9p031)
>> > +{
>> > + struct i2c_client *client = v4l2_get_subdevdata(&mt9p031->subdev);
>> > + int ret;
>> > +
>> > + ret
On Wed, Jul 27, 2011 at 07:51:36PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
Hi Laurent,
> On Wednesday 27 July 2011 12:13:05 Sakari Ailus wrote:
> > Hi Laurent,
> >
> > Thanks for the patch. I have a few comments below.
>
> Thanks for the review. Please see my answers to your comments below.
Hi Sylwester,
Thanks for the review.
On Wednesday 27 July 2011 19:34:36 Sylwester Nawrocki wrote:
> On 07/27/2011 11:13 AM, Laurent Pinchart wrote:
[snip]
> > +static int mt9p031_probe(struct i2c_client *client,
> > + const struct i2c_device_id *did)
> > +{
> > + str
Hi Sakari,
On Wednesday 27 July 2011 12:13:05 Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch. I have a few comments below.
Thanks for the review. Please see my answers to your comments below. Javier,
there's one question for you as well.
> On Wed, Jul 27, 2011 at 11:13:01AM +0200,
Hi Laurent, Javier,
On 07/27/2011 11:13 AM, Laurent Pinchart wrote:
> From: Javier Martin
>
> The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly
> Micron) controlled through I2C.
>
> The driver creates a V4L2 subdevice. It currently supports skipping,
> cropping, automatic binning
Hi Laurent,
I really was looking forward to your patch.
Tomorrow i have the day off, so I will look at this on Friday.
I will review and test your patch and send you my comments.
--
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabr
Hi Laurent,
Thanks for the patch. I have a few comments below.
On Wed, Jul 27, 2011 at 11:13:01AM +0200, Laurent Pinchart wrote:
> From: Javier Martin
>
> The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly
> Micron) controlled through I2C.
>
> The driver creates a V4L2 subdevice
From: Javier Martin
The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly
Micron) controlled through I2C.
The driver creates a V4L2 subdevice. It currently supports skipping,
cropping, automatic binning, and gain, exposure, h/v flip and test
pattern controls.
Signed-off-by: Javier M
11 matches
Mail list logo
