On Fri, 30 Jan 2009, morimoto.kunin...@renesas.com wrote:
>
> Dear Guennadi
>
> > > On my opinion, not only calling set_bus_param but also
> > > try_fmt is important for tw9910.
> > > Because tw9910 needs "INTERLACE" mode, and sh_mobile_ceu
> > > sets "is_interlace flag" in try_fmt.
> >
> > Ooh
Dear Guennadi
> > On my opinion, not only calling set_bus_param but also
> > try_fmt is important for tw9910.
> > Because tw9910 needs "INTERLACE" mode, and sh_mobile_ceu
> > sets "is_interlace flag" in try_fmt.
>
> Ooh, this is wrong. As we discussed before - try_fmt shall not perform any
> co
On Fri, 30 Jan 2009, morimoto.kunin...@renesas.com wrote:
> On my opinion, not only calling set_bus_param but also
> try_fmt is important for tw9910.
> Because tw9910 needs "INTERLACE" mode, and sh_mobile_ceu
> sets "is_interlace flag" in try_fmt.
Ooh, this is wrong. As we discussed before - try_
Dear Guennadi
Thank you for checking patch.
> camera - you will see, that almost all of them have a test "if (pixfmt),"
> i.e., they have to differentiate between the two cases. And not only
(snip)
> cropping for both, but the recently added mt9t031 does support scaling,
> so, it is indeed im
Hi Morimoto-san,
On Fri, 30 Jan 2009, morimoto.kunin...@renesas.com wrote:
> > > I attached stupid 4 patches.
> (snip)
> > Thanks for the patches, please, give me a couple of days for review.
> (snip)
> >> Yes, I'm (going to be) reviewing them, as soon as I find some time.
>
> If you have not re
Dear Guennadi
> > I attached stupid 4 patches.
(snip)
> Thanks for the patches, please, give me a couple of days for review.
(snip)
>> Yes, I'm (going to be) reviewing them, as soon as I find some time.
If you have not reviewed now, please use attached one.
It use more clever way I think.
000
On Thu, 29 Jan 2009 11:00:41 +0100 (CET)
Guennadi Liakhovetski wrote:
> On Thu, 29 Jan 2009, Mauro Carvalho Chehab wrote:
>
> > On Tue, 27 Jan 2009 08:53:23 +0100 (CET)
> > Guennadi Liakhovetski wrote:
> >
> > Hi Guennadi,
> >
> > I'm understanding that you're reviewing this patch and other o
On Thu, 29 Jan 2009, Mauro Carvalho Chehab wrote:
> On Tue, 27 Jan 2009 08:53:23 +0100 (CET)
> Guennadi Liakhovetski wrote:
>
> Hi Guennadi,
>
> I'm understanding that you're reviewing this patch and other ones for
> soc_camera and will send me a PULL request after reviewing those stuff.
Yes,
On Tue, 27 Jan 2009 08:53:23 +0100 (CET)
Guennadi Liakhovetski wrote:
Hi Guennadi,
I'm understanding that you're reviewing this patch and other ones for
soc_camera and will send me a PULL request after reviewing those stuff. I've
updated patchwork to reflect this.
Thanks,
Mauro
> On Tue, 27 Ja
On Tue, 27 Jan 2009, morimoto.kunin...@renesas.com wrote:
> Dear Guennadi
>
> > > what is the best way to us ???
> > > or do I miss understanding ???
> >
> > Fix behaviour if no S_FMT is done.
>
> I attached stupid 4 patches.
> I would like to hear your opinion.
> please check it.
>
> I wonder
Dear Guennadi
> > what is the best way to us ???
> > or do I miss understanding ???
>
> Fix behaviour if no S_FMT is done.
I attached stupid 4 patches.
I would like to hear your opinion.
please check it.
I wonder is there any soc_camera that works without
calling S_FMT though set_bus_param is
On Mon, 26 Jan 2009, morimoto.kunin...@renesas.com wrote:
>
> Dear Guennadi
>
> > > This is probably because you don't setup a default mode in
> > > sh_mobile_ceu_camera.c or ov772x.c if S_FMT is never called. This should
> > > be fixed. I'm not sure if other drivers would deliver anything mea
Dear Guennadi
> > This is probably because you don't setup a default mode in
> > sh_mobile_ceu_camera.c or ov772x.c if S_FMT is never called. This should
> > be fixed. I'm not sure if other drivers would deliver anything meaningful
> > without a call to S_FMT - has to be tested / fixed...
> (s
Dear Guennadi
> > If pixfmt is 0, it said "Format 0 not found" to me.
>
> Yes, this will be fixed by this:
>
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg00161.html
wow !!
I will use this. thank you.
> > If sh_mobile_ceu use V4L2_FIELD_NONE on sh_mobile_ceu_init_videobuf,
> >
On Mon, 26 Jan 2009, morimoto.kunin...@renesas.com wrote:
>
> Dear Guennadi
>
> > Have you tested with v4l-dvb/v4l2-apps/test/capture_example.c? I think it
> > wouldn't work, because it first calls S_CROP, and then S_FMT, and even
> > with this your patch you'd fail S_CROP if S_FMT hadn't been
Dear Guennadi
> Have you tested with v4l-dvb/v4l2-apps/test/capture_example.c? I think it
> wouldn't work, because it first calls S_CROP, and then S_FMT, and even
> with this your patch you'd fail S_CROP if S_FMT hadn't been called before
> (priv->fmt == NULL). Am I right?
hmm.. I would like
On Fri, 23 Jan 2009, Kuninori Morimoto wrote:
> ov772x_set_fmt had returned NULL when pixfmt is 0,
> although it mean only geometry change.
> This patch modify this problem.
>
> Signed-off-by: Kuninori Morimoto
> ---
> drivers/media/video/ov772x.c | 13 -
> 1 files changed, 8 inse
ov772x_set_fmt had returned NULL when pixfmt is 0,
although it mean only geometry change.
This patch modify this problem.
Signed-off-by: Kuninori Morimoto
---
drivers/media/video/ov772x.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/ov7
18 matches
Mail list logo
