Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-27 Thread Niklas Söderlund
Hi Kieran, Thanks for your patch. I took it for a spin on my Koelsch and it worked nicely. Acked-by: Niklas Söderlund On 2017-04-25 15:55:00 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 11:00:30AM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2017-04-26 09:23:20 +0200, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > > > From: Kieran Bingham

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Niklas Söderlund
Hi Simon, Thanks for your feedback. On 2017-04-26 09:23:20 +0200, Simon Horman wrote: > Hi Kieran, > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > > From: Kieran Bingham > > > > The rvin_digital_notify_bound() call dereferences

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 08:48:25AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/04/17 08:23, Simon Horman wrote: > > Hi Kieran, > > > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> The

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Kieran Bingham
Hi Simon, On 26/04/17 08:23, Simon Horman wrote: > Hi Kieran, > > On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> The rvin_digital_notify_bound() call dereferences the subdev->dev >> pointer to obtain the

Re: [PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-26 Thread Simon Horman
Hi Kieran, On Tue, Apr 25, 2017 at 03:55:00PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The rvin_digital_notify_bound() call dereferences the subdev->dev > pointer to obtain the of_node. On some error paths, this dev node can be > set as

[PATCH] rcar-vin: Use of_nodes as specified by the subdev

2017-04-25 Thread Kieran Bingham
From: Kieran Bingham The rvin_digital_notify_bound() call dereferences the subdev->dev pointer to obtain the of_node. On some error paths, this dev node can be set as NULL. The of_node is mapped into the subdevice structure on initialisation, so this is a