Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-31 Thread Sergei Shtylyov
Hello. On 08/25/2015 05:25 PM, Hans Verkuil wrote: rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method call fails (e.g. due to I2C error). This doesn't work very well when a camera being used outputs NTSC which has different order of fields and resolution. Let us stop

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-25 Thread Laurent Pinchart
Hi Sergei, On Tuesday 25 August 2015 00:58:07 Sergei Shtylyov wrote: > On 08/21/2015 12:51 AM, Laurent Pinchart wrote: > >> rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() > >> method call fails (e.g. due to I2C error). This doesn't work very well > >> when a camera being used

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-25 Thread Hans Verkuil
On 08/19/15 23:02, Sergei Shtylyov wrote: > rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method > call > fails (e.g. due to I2C error). This doesn't work very well when a camera > being > used outputs NTSC which has different order of fields and resolution. Let > us >

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-24 Thread Sergei Shtylyov
hello. On 08/21/2015 12:51 AM, Laurent Pinchart wrote: rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method call fails (e.g. due to I2C error). This doesn't work very well when a camera being used outputs NTSC which has different order of fields and resolution. Let us

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-20 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Thursday 20 August 2015 00:02:17 Sergei Shtylyov wrote: > rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method > call fails (e.g. due to I2C error). This doesn't work very well when a > camera being used outputs NTSC which has differe

[PATCH] rcar_vin: propagate querystd() error upstream

2015-08-19 Thread Sergei Shtylyov
rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method call fails (e.g. due to I2C error). This doesn't work very well when a camera being used outputs NTSC which has different order of fields and resolution. Let us stop pretending and return the actual error (which would p