Re: [PATCH] s2255drv: port to videobuf2

2014-02-05 Thread Hans Verkuil
On 02/05/2014 10:44 PM, Dean Anderson wrote: > On 2014-02-04 04:04, Hans Verkuil wrote: >> Hi Dean, >> >> On 02/03/14 18:06, Dean Anderson wrote: >>> On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier

Re: [PATCH] s2255drv: port to videobuf2

2014-02-05 Thread Dean Anderson
On 2014-02-04 04:04, Hans Verkuil wrote: Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a s

Re: [PATCH] s2255drv: port to videobuf2

2014-02-04 Thread Dean Anderson
On 2014-02-04 04:04, Hans Verkuil wrote: Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a s

Re: [PATCH] s2255drv: port to videobuf2

2014-02-04 Thread Hans Verkuil
Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: > On 2014-02-03 03:51, Hans Verkuil wrote: >> Hi Dean, >> >> Some specific comments below, but first two general comments: >> >> It is easier to review if at least the removal of the old s2255_fh struct >> was done as a separate patch. It's always g

Re: [PATCH] s2255drv: port to videobuf2

2014-02-03 Thread Hans Verkuil
Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a separate patch. It's always good to try and keep the changes in patches as small as possible. The actual vb2 conversion is always a 'big b