Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-02-23 Thread Németh Márton
Hi Guennadi, Guennadi Liakhovetski wrote: Hi Németh On Tue, 9 Feb 2010, Guennadi Liakhovetski wrote: Ok, I modified your patch a bit, how about the below version? If you agree, I'll commit it in that form (after converting to utf-8): From: Márton Németh nm...@freemail.hu The first two

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-02-12 Thread Guennadi Liakhovetski
Hi Németh On Tue, 9 Feb 2010, Guennadi Liakhovetski wrote: Ok, I modified your patch a bit, how about the below version? If you agree, I'll commit it in that form (after converting to utf-8): From: Márton Németh nm...@freemail.hu The first two parameters of soc_camera_limit_side() are

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-02-09 Thread Guennadi Liakhovetski
On Thu, 28 Jan 2010, Németh Márton wrote: Guennadi Liakhovetski wrote: On Wed, 27 Jan 2010, Németh Márton wrote: Guennadi Liakhovetski wrote: You didn't reply to my most important objection: On Wed, 27 Jan 2010, Németh Márton wrote: diff -r 31eaa9423f98

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-28 Thread Guennadi Liakhovetski
On Wed, 27 Jan 2010, Németh Márton wrote: Guennadi Liakhovetski wrote: You didn't reply to my most important objection: On Wed, 27 Jan 2010, Németh Márton wrote: diff -r 31eaa9423f98 linux/include/media/soc_camera.h --- a/linux/include/media/soc_camera.h Mon Jan 25 15:04:15

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-28 Thread Németh Márton
Guennadi Liakhovetski wrote: On Wed, 27 Jan 2010, Németh Márton wrote: Guennadi Liakhovetski wrote: You didn't reply to my most important objection: On Wed, 27 Jan 2010, Németh Márton wrote: diff -r 31eaa9423f98 linux/include/media/soc_camera.h --- a/linux/include/media/soc_camera.h

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-27 Thread Guennadi Liakhovetski
On Sat, 23 Jan 2010, Németh Márton wrote: From: Márton Németh nm...@freemail.hu The parameters of soc_camera_limit_side() are either a pointer to a structure element from v4l2_rect, or constants. The structure elements of the v4l2_rect are signed (see linux/videodev2.h) so do the

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-27 Thread Németh Márton
Guennadi Liakhovetski wrote: On Sat, 23 Jan 2010, Németh Márton wrote: From: Márton Németh nm...@freemail.hu The parameters of soc_camera_limit_side() are either a pointer to a structure element from v4l2_rect, or constants. The structure elements of the v4l2_rect are signed (see

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-27 Thread Guennadi Liakhovetski
On Wed, 27 Jan 2010, Németh Márton wrote: Guennadi Liakhovetski wrote: [snip] And these: if (output_w max(512U, input_w / 2)) { if (output_h max(384U, input_h / 2)) { would now produce compiler warnings... Have you actually tried to compile your patch? You'll also

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-27 Thread Guennadi Liakhovetski
You didn't reply to my most important objection: On Wed, 27 Jan 2010, Németh Márton wrote: diff -r 31eaa9423f98 linux/include/media/soc_camera.h --- a/linux/include/media/soc_camera.hMon Jan 25 15:04:15 2010 -0200 +++ b/linux/include/media/soc_camera.hWed Jan 27 20:49:57 2010

Re: [PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-27 Thread Németh Márton
Guennadi Liakhovetski wrote: You didn't reply to my most important objection: On Wed, 27 Jan 2010, Németh Márton wrote: diff -r 31eaa9423f98 linux/include/media/soc_camera.h --- a/linux/include/media/soc_camera.h Mon Jan 25 15:04:15 2010 -0200 +++ b/linux/include/media/soc_camera.h

[PATCH] soc_camera: match signedness of soc_camera_limit_side()

2010-01-23 Thread Németh Márton
From: Márton Németh nm...@freemail.hu The parameters of soc_camera_limit_side() are either a pointer to a structure element from v4l2_rect, or constants. The structure elements of the v4l2_rect are signed (see linux/videodev2.h) so do the computations also with signed values. This will remove