Re: [PATCH] tw9910: color format check is added on set_fmt

2009-02-01 Thread Guennadi Liakhovetski
On Tue, 27 Jan 2009, Kuninori Morimoto wrote: Signed-off-by: Kuninori Morimoto morimoto.kunin...@renesas.com Why is this needed? Do you see any possibility for tw9910 to be called with an unsupported format? Thanks Guennadi --- drivers/media/video/tw9910.c | 13 + 1 files

Re: [PATCH] tw9910: color format check is added on set_fmt

2009-02-01 Thread morimoto . kuninori
Dear Guennadi Signed-off-by: Kuninori Morimoto morimoto.kunin...@renesas.com Why is this needed? Do you see any possibility for tw9910 to be called with an unsupported format? for example, capture_example -f use V4L2_PIX_FMT_YUYV. but tw9910 support only V4L2_PIX_FMT_VYUY now. If you

Re: [PATCH] tw9910: color format check is added on set_fmt

2009-02-01 Thread Guennadi Liakhovetski
On Mon, 2 Feb 2009, morimoto.kunin...@renesas.com wrote: Signed-off-by: Kuninori Morimoto morimoto.kunin...@renesas.com Why is this needed? Do you see any possibility for tw9910 to be called with an unsupported format? for example, capture_example -f use V4L2_PIX_FMT_YUYV. but

Re: [PATCH] tw9910: color format check is added on set_fmt

2009-02-01 Thread morimoto . kuninori
Dear Guennadi If you think this patch is unnecessary, please ignore it. Could you please test whether you indeed can get an unsupported format in your driver. If so, this is a bug at a higher level and we'll have to fix it there. I'll drop this patch for now. tw9910 driver can not

[PATCH] tw9910: color format check is added on set_fmt

2009-01-30 Thread Kuninori Morimoto
Signed-off-by: Kuninori Morimoto morimoto.kunin...@renesas.com --- drivers/media/video/tw9910.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c index 1a9c6fd..57027c0 100644 ---