Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-13 Thread Laurent Pinchart
Hi Jonathan, On Monday 12 September 2011 19:22:33 Jonathan Nieder wrote: Laurent Pinchart wrote: I've just sent a pull request to Mauro. Thanks! Looks good to me, for what little that's worth. My only nits are that in the future it might be nice to Cc: stable and credit testers so they

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-12 Thread Laurent Pinchart
Hi Jonathan, On Monday 12 September 2011 03:16:14 Jonathan Nieder wrote: Laurent Pinchart wrote: On Wednesday 07 September 2011 17:32:41 Josh Boyer wrote: On Wed, Sep 07, 2011 at 12:29:08AM +0200, Laurent Pinchart wrote: drivers/media/video/uvc/uvc_entity.c |2 +- 1 files changed, 1

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-12 Thread Jonathan Nieder
Laurent Pinchart wrote: I've just sent a pull request to Mauro. Thanks! Looks good to me, for what little that's worth. My only nits are that in the future it might be nice to Cc: stable and credit testers so they can grep through commit logs to find out if the kernel is fixed. -- To

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-11 Thread Jonathan Nieder
Hi Laurent and Mauro, Laurent Pinchart wrote: On Wednesday 07 September 2011 17:32:41 Josh Boyer wrote: On Wed, Sep 07, 2011 at 12:29:08AM +0200, Laurent Pinchart wrote: drivers/media/video/uvc/uvc_entity.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patch should fix

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-08 Thread Laurent Pinchart
Hi Josh, On Wednesday 07 September 2011 17:32:41 Josh Boyer wrote: On Wed, Sep 07, 2011 at 12:29:08AM +0200, Laurent Pinchart wrote: The uvc_mc_register_entity() function wrongfully selects the media_entity associated with a UVC entity when creating links. This results in access to

Re: [PATCH] uvcvideo: Fix crash when linking entities

2011-09-07 Thread Josh Boyer
On Wed, Sep 07, 2011 at 12:29:08AM +0200, Laurent Pinchart wrote: The uvc_mc_register_entity() function wrongfully selects the media_entity associated with a UVC entity when creating links. This results in access to uninitialized media_entity structures and can hit a BUG_ON statement in

[PATCH] uvcvideo: Fix crash when linking entities

2011-09-06 Thread Laurent Pinchart
The uvc_mc_register_entity() function wrongfully selects the media_entity associated with a UVC entity when creating links. This results in access to uninitialized media_entity structures and can hit a BUG_ON statement in media_entity_create_link(). Fix it. Signed-off-by: Laurent Pinchart