Re: [PATCH] uvcvideo: Fix uvc_fixup_video_ctrl() format search

2012-08-07 Thread Stephan Lachowsky
Hi Laurent, On 19/02/11 12:35, Laurent Pinchart wrote: Hi Stephan, On Friday 28 January 2011 03:04:33 Stephan Lachowsky wrote: The scheme used to index format in uvc_fixup_video_ctrl() is not robust: format index is based on descriptor ordering, which does not necessarily match bFormatIndex or

Re: [PATCH] uvcvideo: Fix uvc_fixup_video_ctrl() format search

2011-02-19 Thread Stephan Lachowsky
On Feb 19, 2011, at 4:35 AM, Laurent Pinchart wrote: > > Thanks for the patch. It's missing your Signed-off-by line, can I add it ? You may. Signed-off-by: Stephan Lachowsky -- Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord.

Re: [PATCH] uvcvideo: Fix uvc_fixup_video_ctrl() format search

2011-02-19 Thread Laurent Pinchart
Hi Stephan, On Friday 28 January 2011 03:04:33 Stephan Lachowsky wrote: > The scheme used to index format in uvc_fixup_video_ctrl() is not robust: > format index is based on descriptor ordering, which does not necessarily > match bFormatIndex ordering. Searching for first matching format will > p

[PATCH] uvcvideo: Fix uvc_fixup_video_ctrl() format search

2011-01-27 Thread Stephan Lachowsky
The scheme used to index format in uvc_fixup_video_ctrl() is not robust: format index is based on descriptor ordering, which does not necessarily match bFormatIndex ordering. Searching for first matching format will prevent uvc_fixup_video_ctrl() from using the wrong format/frame to make adjustmen

[PATCH] uvcvideo: Fix uvc_fixup_video_ctrl() format search

2011-01-27 Thread Stephan Lachowsky
The scheme used to index format in uvc_fixup_video_ctrl() is not robust: format index is based on descriptor ordering, which does not necessarily match bFormatIndex ordering. Searching for first matching format will prevent uvc_fixup_video_ctrl() from using the wrong format/frame to make adjustmen