Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-08 Thread Steve Longerbeam
Hi Jan, On 05/08/2018 07:13 AM, Jan Lübbe wrote: Hi, On Mon, 2018-05-07 at 11:21 -0700, Steve Longerbeam wrote: In other words, if the sensor bus is parallel, only 8-bit bus UYVY_2x8 and YUYV_2x8 can be routed to the IC pad or component packed/unpacked by the IDMAC pad. All other sensor

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-08 Thread Jan Lübbe
Hi, On Mon, 2018-05-07 at 11:21 -0700, Steve Longerbeam wrote: > On 05/07/2018 07:23 AM, Jan Lübbe wrote: > > On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: > > > I reviewed this patch series, and while I don't have any > > > objections to the code-level changes, but my question > > >

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-07 Thread Steve Longerbeam
On 05/07/2018 07:23 AM, Jan Lübbe wrote: Hi Steve, thanks for reviewing! On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: I reviewed this patch series, and while I don't have any objections to the code-level changes, but my question is more specifically about how the IPU/CSI deals

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-07 Thread Jan Lübbe
Hi Steve, thanks for reviewing! On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: > I reviewed this patch series, and while I don't have any > objections to the code-level changes, but my question > is more specifically about how the IPU/CSI deals with > receiving RGB565 over a parallel

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-05 Thread Steve Longerbeam
Hi Jan, Philipp, I reviewed this patch series, and while I don't have any objections to the code-level changes, but my question is more specifically about how the IPU/CSI deals with receiving RGB565 over a parallel bus. My understanding was that if the CSI receives RGB565 over a parallel 8-bit

[PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-03 Thread Jan Luebbe
The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic mode on the parallel bus, compared to a specific mode on MIPI CSI-2. To handle this, we extend imx_media_pixfmt with a cycles per pixel field, which is used for generic formats on the parallel bus. Before actually adding