Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-12-12 Thread Mel Gorman
On Mon, Dec 12, 2011 at 03:51:55PM +0100, Michal Nazarewicz wrote: > >On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote: > >>From: Michal Nazarewicz > >>diff --git a/mm/compaction.c b/mm/compaction.c > >>index 6afae0e..09c9702 100644 > >>--- a/mm/compaction.c > >>+++ b/mm/compaction

Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-12-12 Thread Michal Nazarewicz
On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz diff --git a/mm/compaction.c b/mm/compaction.c index 6afae0e..09c9702 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -111,7 +111,10 @@ skip: next: pfn += isolated; - p

Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-12-12 Thread Mel Gorman
On Mon, Dec 12, 2011 at 03:35:03PM +0100, Michal Nazarewicz wrote: > >On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote: > >>From: Michal Nazarewicz > >>diff --git a/mm/compaction.c b/mm/compaction.c > >>index 6afae0e..09c9702 100644 > >>--- a/mm/compaction.c > >>+++ b/mm/compaction

Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-12-12 Thread Michal Nazarewicz
On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz diff --git a/mm/compaction.c b/mm/compaction.c index 6afae0e..09c9702 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -111,7 +111,10 @@ skip: next: pfn += isolated; - p

Re: [PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-12-12 Thread Mel Gorman
On Fri, Nov 18, 2011 at 05:43:10PM +0100, Marek Szyprowski wrote: > From: Michal Nazarewicz > > This commit introduces zone_pfn_same_memmap() function which checkes s/checkes/checks/ > whether two PFNs within the same zone have struct pages within the > same memmap. s/memmap/same sparsemem se

[PATCH 03/11] mm: mmzone: introduce zone_pfn_same_memmap()

2011-11-18 Thread Marek Szyprowski
From: Michal Nazarewicz This commit introduces zone_pfn_same_memmap() function which checkes whether two PFNs within the same zone have struct pages within the same memmap. This check is needed because in general pointer arithmetic on struct pages may lead to invalid pointers. On memory models