Re: [PATCH 03/16] lirc_dev: correct error handling

2017-06-17 Thread David Härdeman
On Sun, May 28, 2017 at 04:04:30PM +0100, Sean Young wrote: >On Sun, May 28, 2017 at 10:23:37AM +0200, David Härdeman wrote: >> On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: >> >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: >> >> If an error is generated,

Re: [PATCH 03/16] lirc_dev: correct error handling

2017-05-28 Thread Sean Young
On Sun, May 28, 2017 at 10:23:37AM +0200, David Härdeman wrote: > On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: > >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: > >> If an error is generated, nonseekable_open() shouldn't be called. > > > >There is no harm in calling

Re: [PATCH 03/16] lirc_dev: correct error handling

2017-05-28 Thread David Härdeman
On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: >> If an error is generated, nonseekable_open() shouldn't be called. > >There is no harm in calling nonseekable_open(), so this commit is >misleading. I'm not sure why you

Re: [PATCH 03/16] lirc_dev: correct error handling

2017-05-21 Thread Sean Young
On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: > If an error is generated, nonseekable_open() shouldn't be called. There is no harm in calling nonseekable_open(), so this commit is misleading. Sean > > Signed-off-by: David Härdeman > --- >

[PATCH 03/16] lirc_dev: correct error handling

2017-05-01 Thread David Härdeman
If an error is generated, nonseekable_open() shouldn't be called. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index