I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> Signed-off-by: Baole Ni <baolex...@intel.com> --- drivers/media/tuners/mt20xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/mt20xx.c b/drivers/media/tuners/mt20xx.c index 9e03104..eff1852 100644 --- a/drivers/media/tuners/mt20xx.c +++ b/drivers/media/tuners/mt20xx.c @@ -12,19 +12,19 @@ #include "mt20xx.h" static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "enable verbose debug messages"); /* ---------------------------------------------------------------------- */ static unsigned int optimize_vco = 1; -module_param(optimize_vco, int, 0644); +module_param(optimize_vco, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static unsigned int tv_antenna = 1; -module_param(tv_antenna, int, 0644); +module_param(tv_antenna, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static unsigned int radio_antenna; -module_param(radio_antenna, int, 0644); +module_param(radio_antenna, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* ---------------------------------------------------------------------- */ -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
