I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com>
Signed-off-by: Baole Ni <baolex...@intel.com>
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index 83e9a3e..83c3c22 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -81,11 +81,11 @@ MODULE_PARM_DESC(init_pause_msec, "hardware initialization
settling delay");
module_param(procreload, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(procreload,
"Attempt init failure recovery with firmware reload");
-module_param_array(tuner, int, NULL, 0444);
+module_param_array(tuner, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(tuner,"specify installed tuner type");
-module_param_array(video_std, int, NULL, 0444);
+module_param_array(video_std, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(video_std,"specify initial video standard");
-module_param_array(tolerance, int, NULL, 0444);
+module_param_array(tolerance, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(tolerance,"specify stream error tolerance");
/* US Broadcast channel 3 (61.25 MHz), to help with testing */
@@ -93,9 +93,9 @@ static int default_tv_freq = 61250000L;
/* 104.3 MHz, a usable FM station for my area */
static int default_radio_freq = 104300000L;
-module_param_named(tv_freq, default_tv_freq, int, 0444);
+module_param_named(tv_freq, default_tv_freq, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(tv_freq, "specify initial television frequency");
-module_param_named(radio_freq, default_radio_freq, int, 0444);
+module_param_named(radio_freq, default_radio_freq, int, S_IRUSR | S_IRGRP |
S_IROTH);
MODULE_PARM_DESC(radio_freq, "specify initial radio frequency");
#define PVR2_CTL_WRITE_ENDPOINT 0x01
--
2.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
