Re: [PATCH 1/1] media: Use common test pattern menu entries

2018-12-04 Thread sakari . ailus
On Tue, Nov 27, 2018 at 07:19:52PM +0800, Bingbu Cao wrote: > > On 11/27/2018 05:33 PM, Sakari Ailus wrote: > > diff --git a/include/uapi/linux/v4l2-controls.h > > b/include/uapi/linux/v4l2-controls.h > > index 998983a6e6b7..a74ff6f1ac88 100644 > > --- a/include/uapi/linux/v4l2-controls.h > >

Re: [RESEND PATCH 1/1] media: Use common test pattern menu entries

2018-11-27 Thread Sakari Ailus
On Tue, Nov 27, 2018 at 01:11:42PM +0100, Luca Ceresoli wrote: > Hi Sakari, Bingbu, > > On 27/11/18 10:34, Sakari Ailus wrote: > > While the test pattern menu itself is not standardised, many devices > > support the same test patterns. Aligning the menu entries helps the user > > space to use the

Re: [RESEND PATCH 1/1] media: Use common test pattern menu entries

2018-11-27 Thread Luca Ceresoli
Hi Sakari, Bingbu, On 27/11/18 10:34, Sakari Ailus wrote: > While the test pattern menu itself is not standardised, many devices > support the same test patterns. Aligning the menu entries helps the user > space to use the interface, and adding macros for the menu entry strings > helps to keep

Re: [PATCH 1/1] media: Use common test pattern menu entries

2018-11-27 Thread Bingbu Cao
On 11/27/2018 05:33 PM, Sakari Ailus wrote: While the test pattern menu itself is not standardised, many devices support the same test patterns. Aligning the menu entries helps the user space to use the interface, and adding macros for the menu entry strings helps to keep them aligned. I like

[RESEND PATCH 1/1] media: Use common test pattern menu entries

2018-11-27 Thread Sakari Ailus
While the test pattern menu itself is not standardised, many devices support the same test patterns. Aligning the menu entries helps the user space to use the interface, and adding macros for the menu entry strings helps to keep them aligned. Signed-off-by: Sakari Ailus --- Fixed Andy's email.

[PATCH 1/1] media: Use common test pattern menu entries

2018-11-27 Thread Sakari Ailus
While the test pattern menu itself is not standardised, many devices support the same test patterns. Aligning the menu entries helps the user space to use the interface, and adding macros for the menu entry strings helps to keep them aligned. Signed-off-by: Sakari Ailus ---