Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-18 Thread Pavel Machek
Hi! > If someone has analyzed the existing voice coil lens controllers and could > share the result, in term of what parameters need to be controlled by the > system and how they should be controlled, that would be very appreciated. > Even > better would be a real userspace implementation of

Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-17 Thread Laurent Pinchart
Hello, On Saturday 18 Jun 2016 00:11:49 Pavel Machek wrote: > Hi! > > >> I also don't think the FOCUS_ABSOLUTE controls is a really good one for > >> the voice coil lens current. I expect more voice coil lens controls > >> (linear vs. PWM mode, ringing compensation...) to be needed so I think >

Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-17 Thread Pavel Machek
Hi! > >I also don't think the FOCUS_ABSOLUTE controls is a really good one for > >the voice coil lens current. I expect more voice coil lens controls > >(linear vs. PWM mode, ringing compensation...) to be needed so I think > >it's worth a new class. Well, I do agree that that the new class is

Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-17 Thread Pavel Machek
Hi! > - > + > + > + Voice Coil Control Reference > + > + The Voice Coil class controls are used to control voice > + coil lens devices. These are very simple devices that consist of > + a voice coil, a spring and a lens. The current applied on a "on the"? > + voice

Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-12 Thread Ivaylo Dimitrov
Hi, On 12.06.2016 23:41, Sakari Ailus wrote: From: Sakari Ailus Add a V4L2 control class for voice coil lens driver devices. These are simple devices that are used to move a camera lens from its resting position. Signed-off-by: Sakari Ailus

[PATCH 1/1] v4l: Add camera voice coil lens control class, current control

2016-06-12 Thread Sakari Ailus
From: Sakari Ailus Add a V4L2 control class for voice coil lens driver devices. These are simple devices that are used to move a camera lens from its resting position. Signed-off-by: Sakari Ailus --- Hi Pavel, I also don't think the