Re: [PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-26 Thread Sakari Ailus
Hi Helmut, On Tue, Sep 25, 2018 at 08:33:29AM +0200, Helmut Grohne wrote: > On Mon, Sep 24, 2018 at 04:42:27PM +0200, Sakari Ailus wrote: > > --- a/drivers/media/i2c/mt9t112.c > > +++ b/drivers/media/i2c/mt9t112.c > > @@ -888,12 +888,6 @@ static int mt9t112_get_selection(struct v4l2_subdev > >

Re: [PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-25 Thread jacopo mondi
Hi Helmut, On Tue, Sep 25, 2018 at 08:33:29AM +0200, Helmut Grohne wrote: > On Mon, Sep 24, 2018 at 04:42:27PM +0200, Sakari Ailus wrote: > > --- a/drivers/media/i2c/mt9t112.c > > +++ b/drivers/media/i2c/mt9t112.c > > @@ -888,12 +888,6 @@ static int mt9t112_get_selection(struct v4l2_subdev > >

Re: [PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-25 Thread Helmut Grohne
On Mon, Sep 24, 2018 at 04:42:27PM +0200, Sakari Ailus wrote: > --- a/drivers/media/i2c/mt9t112.c > +++ b/drivers/media/i2c/mt9t112.c > @@ -888,12 +888,6 @@ static int mt9t112_get_selection(struct v4l2_subdev *sd, > sel->r.width = MAX_WIDTH; > sel->r.height =

Re: [PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-24 Thread Sakari Ailus
On Mon, Sep 24, 2018 at 04:47:07PM +0200, Hans Verkuil wrote: > On 09/24/2018 04:42 PM, Sakari Ailus wrote: > > The V4L2 sub-device API does not support the crop default target. A number > > of drivers apparently still did support this, likely as it was needed by > > the SoC camera framework. Drop

Re: [PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-24 Thread Hans Verkuil
On 09/24/2018 04:42 PM, Sakari Ailus wrote: > The V4L2 sub-device API does not support the crop default target. A number > of drivers apparently still did support this, likely as it was needed by > the SoC camera framework. Drop support for the default crop rectaingle in > sub-device drivers, and

[PATCH 1/1] v4l: Remove support for crop default target in subdev drivers

2018-09-24 Thread Sakari Ailus
The V4L2 sub-device API does not support the crop default target. A number of drivers apparently still did support this, likely as it was needed by the SoC camera framework. Drop support for the default crop rectaingle in sub-device drivers, and use the bround in SoC camera instead. Reported-by: