Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-25 Thread Laurent Pinchart
Hello, On Sunday 21 October 2012 20:52:21 Sylwester Nawrocki wrote: On 10/20/2012 12:20 AM, Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These

Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-22 Thread Guennadi Liakhovetski
Hi Sylwester On Sun, 21 Oct 2012, Sylwester Nawrocki wrote: Hi Guennadi, On 10/20/2012 12:20 AM, Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running

Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-22 Thread Sylwester Nawrocki
On 10/22/2012 11:14 AM, Guennadi Liakhovetski wrote: On Sun, 21 Oct 2012, Sylwester Nawrocki wrote: On 10/20/2012 12:20 AM, Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers

Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-22 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. Here are a few comments in addition to what Sylwester already mentioned. On Saturday 20 October 2012 00:20:20 Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their

Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-22 Thread Laurent Pinchart
Hi Guennadi, A couple more comments. On Saturday 20 October 2012 00:20:20 Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should

Re: [PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-21 Thread Sylwester Nawrocki
Hi Guennadi, On 10/20/2012 12:20 AM, Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers.

[PATCH 1/2] media: V4L2: add temporary clock helpers

2012-10-19 Thread Guennadi Liakhovetski
Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This should be performed, using the generic clock framework. Unfortunately