Re: [PATCH 1/3] [media] uvcvideo: variable size controls (fwd)

2017-07-15 Thread Julia Lawall
There is a double free on data if the goto is taken on line 1815. julia -- Forwarded message -- Date: Sat, 15 Jul 2017 21:07:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH

Re: [PATCH 1/3] [media] uvcvideo: variable size controls

2017-07-15 Thread Philipp Zabel
Hi Laurent, Am Samstag, den 15.07.2017, 12:49 +0300 schrieb Laurent Pinchart: > Hi Philipp, > > Thank you for the patch. Thank you for the review. > On Friday 14 Jul 2017 22:14:22 Philipp Zabel wrote: > > Some USB webcam controllers have extension unit controls that report > > different

Re: [PATCH 1/3] [media] uvcvideo: variable size controls

2017-07-15 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Friday 14 Jul 2017 22:14:22 Philipp Zabel wrote: > Some USB webcam controllers have extension unit controls that report > different lengths via GET_LEN, depending on internal state. If I ever need to hire a hardware designer, I'll make sure to reject any

[PATCH 1/3] [media] uvcvideo: variable size controls

2017-07-14 Thread Philipp Zabel
Some USB webcam controllers have extension unit controls that report different lengths via GET_LEN, depending on internal state. Add a flag to mark these controls as variable length and issue GET_LEN before GET/SET_CUR transfers to verify the current length. Signed-off-by: Philipp Zabel