Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-20 Thread Pierre-Hugues Husson
2017-10-20 10:12 GMT+02:00 Russell King - ARM Linux : > On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote: >> @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev, >> goto err_isfr; >> } >> >> + hdmi->cec_clk =

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-20 Thread Russell King - ARM Linux
On Sat, Oct 14, 2017 at 12:53:35AM +0200, Pierre-Hugues Husson wrote: > @@ -2382,6 +2383,18 @@ __dw_hdmi_probe(struct platform_device *pdev, > goto err_isfr; > } > > + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec"); > + if (IS_ERR(hdmi->cec_clk)) { > +

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-20 Thread Hans Verkuil
On 14/10/17 10:16, Hans Verkuil wrote: > On 10/14/2017 12:53 AM, Pierre-Hugues Husson wrote: >> The documentation already mentions "cec" optional clock, but >> currently the driver doesn't enable it. >> >> Signed-off-by: Pierre-Hugues Husson > > Acked-by: Hans Verkuil

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-14 Thread Fabio Estevam
Hi Pierre, On Sat, Oct 14, 2017 at 10:21 AM, Pierre-Hugues Husson wrote: > As far as I understand, dw_hdmi_cec_enable only gates > the CEC clock inside the Synopsis IP, > but the SOC still has to provide a specific CEC clock to it. > To enable such an external CEC clock, the

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-14 Thread Pierre-Hugues Husson
Hi Fabio, 2017-10-14 2:18 GMT+02:00 Fabio Estevam : > Hi Pierre-Hugues, > > On Fri, Oct 13, 2017 at 7:53 PM, Pierre-Hugues Husson wrote: >> The documentation already mentions "cec" optional clock, but >> currently the driver doesn't enable it. > > The cec clock

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-14 Thread Hans Verkuil
On 10/14/2017 12:53 AM, Pierre-Hugues Husson wrote: > The documentation already mentions "cec" optional clock, but > currently the driver doesn't enable it. > > Signed-off-by: Pierre-Hugues Husson Acked-by: Hans Verkuil Thanks! Hans > --- >

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-13 Thread Fabio Estevam
Hi Pierre-Hugues, On Fri, Oct 13, 2017 at 7:53 PM, Pierre-Hugues Husson wrote: > The documentation already mentions "cec" optional clock, but > currently the driver doesn't enable it. The cec clock is enabled at dw_hdmi_cec_enable().

[PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-13 Thread Pierre-Hugues Husson
The documentation already mentions "cec" optional clock, but currently the driver doesn't enable it. Signed-off-by: Pierre-Hugues Husson --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 + 1 file changed, 17 insertions(+) diff --git