Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Hans Verkuil
On 09/26/2013 12:57 AM, Laurent Pinchart wrote: On Wednesday 25 September 2013 18:31:51 Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] +/* I2C I/O operations */ +static s32 adv_smbus_read_byte_data(struct

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Hans Verkuil
On 09/25/2013 10:36 PM, Valentine wrote: On 09/25/2013 10:33 PM, Guennadi Liakhovetski wrote: Hi Valentine, On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote:

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Hans Verkuil
On 09/25/2013 12:21 PM, Laurent Pinchart wrote: Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Laurent Pinchart
Hi Hans, On Thursday 26 September 2013 08:57:43 Hans Verkuil wrote: On 09/25/2013 12:21 PM, Laurent Pinchart wrote: Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-26 Thread Laurent Pinchart
Hi Hans, On Thursday 26 September 2013 08:31:58 Hans Verkuil wrote: On 09/26/2013 12:57 AM, Laurent Pinchart wrote: On Wednesday 25 September 2013 18:31:51 Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip]

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/24/2013 06:17 PM, Hans Verkuil wrote: Hi Valentine, Hi Hans, On Tue 24 September 2013 15:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Guennadi Liakhovetski
Hi Valentine, On Wed, 25 Sep 2013, Valentine wrote: On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Wed, 25 Sep 2013, Valentine wrote: On 09/24/2013 07:54 PM, Guennadi Liakhovetski wrote: Hi Valentine, Hi Guennadi, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Guennadi Liakhovetski
On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] Using module parameters has a disadvantage, that all instances of this driver will get the same values, and it is quite possible to have several HDMI receivers in a system, I

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] Using module parameters has a disadvantage, that all instances of this driver will get the same values, and it is quite possible to have

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Guennadi Liakhovetski
Hi Valentine, On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] Using module parameters has a disadvantage, that all instances of

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 24 September 2013 17:54:11 Guennadi Liakhovetski wrote: Hi Valentine, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Valentine
On 09/25/2013 10:33 PM, Guennadi Liakhovetski wrote: Hi Valentine, On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 08:31 PM, Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] Using module parameters has a

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Laurent Pinchart
Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Laurent Pinchart
On Wednesday 25 September 2013 12:21:04 Laurent Pinchart wrote: Hi Valentine, Thank you for the patch. Please see below for a couple of comments (in addition to Hans' and Guennadi's comments). On Tuesday 24 September 2013 17:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-25 Thread Laurent Pinchart
On Wednesday 25 September 2013 18:31:51 Guennadi Liakhovetski wrote: On Wed, 25 Sep 2013, Valentine wrote: On 09/25/2013 06:08 PM, Guennadi Liakhovetski wrote: [snip] +/* I2C I/O operations */ +static s32 adv_smbus_read_byte_data(struct i2c_client *client, u8 command)

[PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Valentine Barshak
This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com --- drivers/media/i2c/Kconfig | 11 +

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Hans Verkuil
Hi Valentine, On Tue 24 September 2013 15:38:34 Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Thanks for the patch! I have a

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Guennadi Liakhovetski
Hi Valentine, On Tue, 24 Sep 2013, Valentine Barshak wrote: This adds ADV7611/ADV7612 Dual Port Xpressview 225 MHz HDMI Receiver support. The code is based on the ADV7604 driver, and ADV7612 patch by Shinobu Uehara shinobu.uehara...@renesas.com Signed-off-by: Valentine Barshak

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Guennadi Liakhovetski
Hi Hans On Tue, 24 Sep 2013, Hans Verkuil wrote: Shouldn't the interrupt_service_routine() op be implemented as well? Usually these drivers will generate interrupts if e.g. the format changes. Should it? AFAIU, .interrupt_service_routine() is a subde operation to be called by a bridge

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Hans Verkuil
On 09/24/2013 06:19 PM, Guennadi Liakhovetski wrote: Hi Hans On Tue, 24 Sep 2013, Hans Verkuil wrote: Shouldn't the interrupt_service_routine() op be implemented as well? Usually these drivers will generate interrupts if e.g. the format changes. Should it? AFAIU,

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Andy Walls
Hans Verkuil hverk...@xs4all.nl wrote: On 09/24/2013 06:19 PM, Guennadi Liakhovetski wrote: Hi Hans On Tue, 24 Sep 2013, Hans Verkuil wrote: Shouldn't the interrupt_service_routine() op be implemented as well? Usually these drivers will generate interrupts if e.g. the format changes.