Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-13 Thread Binoy Jayan
Hi Arnd, On 9 June 2017 at 16:06, Arnd Bergmann wrote: >> Thank you for pointing out that. I'll check the >> concurrency part. By the way why do we need mutex_destoy? >> To debug an aberrate condition? > > At first I suspected the down() here was added for the same > purpose as a

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-09 Thread Arnd Bergmann
On Fri, Jun 9, 2017 at 6:37 AM, Binoy Jayan wrote: > On 8 June 2017 at 20:40, Arnd Bergmann wrote: >> On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: >>> The semaphore 'cmd_mutex' is used as a simple mutex, so >>> it should be

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Binoy Jayan
On 8 June 2017 at 20:40, Arnd Bergmann wrote: > On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: >> The semaphore 'cmd_mutex' is used as a simple mutex, so >> it should be written as one. Semaphores are going away in the future. >> >> Signed-off-by:

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Arnd Bergmann
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: > The semaphore 'cmd_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > --- > @@ -1283,7 +1283,7 @@

[PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

2017-06-08 Thread Binoy Jayan
The semaphore 'cmd_mutex' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/media/pci/ngene/ngene-core.c | 12 ++-- drivers/media/pci/ngene/ngene.h | 2 +- 2 files