Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

2014-10-24 Thread Peter Griffin
Hi Srini, Sorry seems I never replied to this. drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer from integer without a cast [enabled by default] rc_dev-rstc = reset_control_get(dev, NULL); Is managing the reset line actually optional though? I can't test atm as I

Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

2014-09-24 Thread Srinivas Kandagatla
Hi Pete, On 23/09/14 19:02, Peter Griffin wrote: Hi Srini, On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: This patch fixes a compilation error while building with the random kernel configuration. drivers/media/rc/st_rc.c: In function 'st_rc_probe': drivers/media/rc/st_rc.c:281:2: error:

Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

2014-09-24 Thread Maxime Coquelin
Hi Srini, Peter, On 09/24/2014 10:12 AM, Srinivas Kandagatla wrote: Hi Pete, On 23/09/14 19:02, Peter Griffin wrote: Hi Srini, On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: This patch fixes a compilation error while building with the random kernel configuration.

Re: [STLinux Kernel] [PATCH 1/3] media: st-rc: move to using reset_control_get_optional

2014-09-23 Thread Peter Griffin
Hi Srini, On Mon, 22 Sep 2014, Srinivas Kandagatla wrote: This patch fixes a compilation error while building with the random kernel configuration. drivers/media/rc/st_rc.c: In function 'st_rc_probe': drivers/media/rc/st_rc.c:281:2: error: implicit declaration of function

[PATCH 1/3] media: st-rc: move to using reset_control_get_optional

2014-09-22 Thread Srinivas Kandagatla
This patch fixes a compilation error while building with the random kernel configuration. drivers/media/rc/st_rc.c: In function 'st_rc_probe': drivers/media/rc/st_rc.c:281:2: error: implicit declaration of function 'reset_control_get' [-Werror=implicit-function-declaration] rc_dev-rstc =