Re: [PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-25 Thread javier Martin
Hi Guennadi, thank you for your review. >>       u32                     frame_count; >> +     struct vb2_alloc_ctx    *alloc_ctx; >> +}; >> + >> +enum mx2_buffer_state { >> +     MX2_STATE_NEEDS_INIT = 0, >> +     MX2_STATE_PREPARED   = 1, >> +     MX2_STATE_QUEUED     = 2, >> +     MX2_STATE_ACT

Re: [PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-25 Thread Guennadi Liakhovetski
On Wed, 25 Jan 2012, Guennadi Liakhovetski wrote: > This patch seems incomplete to me? On the one hand you're saying, you only > work with i.MX27, but you've left > > static void mx27_camera_frame_done(struct mx2_camera_dev *pcdev, int state) > { > struct videobuf_buffer *vb; > > TBH, I d

Re: [PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-25 Thread Guennadi Liakhovetski
This patch seems incomplete to me? On the one hand you're saying, you only work with i.MX27, but you've left static void mx27_camera_frame_done(struct mx2_camera_dev *pcdev, int state) { struct videobuf_buffer *vb; TBH, I don't understand how you've tested this patch: it doesn't compile

[PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-20 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 277 ++ 1 files changed, 128 insertions(+), 149 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 68038e7..290ac9d 100644 --- a/drivers/medi